Tickets :: [#7970] Constants in Horde_Data need to be refactored to class constants

6.0.0-RC7

6/18/26

History
Attachments
Comment
Watch
Download

Summary	Constants in Horde_Data need to be refactored to class constants
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	Horde Developers (at) , mrubinsk (at) horde (dot) org
Requester	horde (at) smartsector (dot) hu
Created	2/9/09 (6338 days ago)
Due
Updated	2/10/09 (6337 days ago)
Assigned	2/9/09 (6338 days ago)
Resolved	2/10/09 (6337 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

2212	horde (at) smartsector (dot) hu	Comment #6	Reply to this comment
A look at kronolith in cvs shows the file is included properly, so I'm going to go ahead and close this. Feel free to re-open if the problem persists and please be sure to pick the correct version number. yes it was GIT master. sorry again.

3512	Michael Rubinsky	Comment #5 State ⇒ Resolved	Reply to this comment
Indeed, I just assumed it was git, since the problem described does exist...well, it did exist before I committed the Horde_Data changes. A look at kronolith in cvs shows the file is included properly, so I'm going to go ahead and close this. Feel free to re-open if the problem persists and please be sure to pick the correct version number.

4011	Jan Schneider	Comment #4	Reply to this comment
The reporter mentioned this was Kronolith 2.3. Which version is it?

1811	Michael Rubinsky	Summary ⇒ Constants in Horde_Data need to be refactored to class constants

3511	Michael Rubinsky	Comment #3 Version ⇒ Git master Queue ⇒ Horde Framework Packages	Reply to this comment
Moving to framework queue since this is an issue with the Data library that needs to be corrected for it to work with Horde 4 / autoloading.

911	Michael Rubinsky	Comment #2 State ⇒ Assigned Assigned to Horde Developers Assigned to Michael Rubinsky	Reply to this comment
Actually, that class can be autoloaded. The correct fix here is to refactor those constants to be class constants.

2310	horde (at) smartsector (dot) hu	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ include missing in data.php Queue ⇒ Kronolith Milestone ⇒ Patch ⇒ No State ⇒ Unconfirmed	Reply to this comment
in the kronolith/data.php cause error / notice messages when we choose the import/export function. the solution is simply we need include the: require_once 'Horde/Data.php'; at line 9. errors was: Notice: Use of undefined constant IMPORT_CSV - assumed 'IMPORT_CSV' in /usr/share/horde/kronolith/data.php on line 36 Notice: Use of undefined constant IMPORT_MAPPED - assumed 'IMPORT_MAPPED' in /usr/share/horde/kronolith/data.php on line 37 Notice: Use of undefined constant IMPORT_DATETIME - assumed 'IMPORT_DATETIME' in /usr/share/horde/kronolith/data.php on line 38 Notice: Use of undefined constant IMPORT_FILE - assumed 'IMPORT_FILE' in /usr/share/horde/kronolith/data.php on line 49 Notice: Use of undefined constant IMPORT_FILE - assumed 'IMPORT_FILE' in /usr/share/horde/kronolith/data.php on line 55 Notice: Use of undefined constant IMPORT_FILE - assumed 'IMPORT_FILE' in /usr/share/horde/kronolith/data.php on line 187 Notice: Undefined offset: 11 in /usr/share/horde/kronolith/data.php on line 306 Warning: Invalid argument supplied for foreach() in /usr/share/horde/kronolith/data.php on line 306