Summary | Unable to retrieve list of holidays |
Queue | Kronolith |
Queue Version | FRAMEWORK_3 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | |
Requester | adrieder (at) sbox (dot) tugraz (dot) at |
Created | 02/06/2009 (5997 days ago) |
Due | 02/07/2009 (5996 days ago) |
Updated | 01/12/2010 (5657 days ago) |
Assigned | 02/06/2009 (5997 days ago) |
Resolved | 02/11/2009 (5992 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
Fix passing date to Date_Holidays.
Bug: 7961http://git.horde.org/diff.php/kronolith/lib/Driver/holidays.php?rt=horde-git&r1=1f29c9197500160f3bff50775c85ac9db473259f&r2=478f3f18c0d22b3ebadf2e59c1d8c085e9faae3f
State ⇒ Resolved
http://cvs.horde.org/diff.php/kronolith/lib/Driver/holidays.php?rt=horde&r1=1.6.2.7&r2=1.6.2.8&ty=u
New Attachment: holidays.php.2.patch
and/or check what difference this makes inside the Date_Holidays code?
Feb 07 17:18:19 HORDE [info] [kronolith] Unable to retrieve list of
holidays from Mon Jan 26 00:00:00 2009 to Mon Mar 2 23:59:59 2009 [pid
20372 on line 74 of
"/usr/local/apache/htdocs/horde3/horde/kronolith/lib/Driver/holidays.php"]
I also logged $date->timestamp() and $holidays:
$date->timestamp() is: 1234393200
$holidays is: Date-string has wrong format (must be YYYY-MM-DD)
But the problem is that $date->timestamp() is of type string as
discovered by gettype($date->timestamp())).
Date_Holidays expects an integer as timestamp.
So a cleaner fix of the problem is the newly attached patch, which
does a type cast to integer instead of making a integer out of a
string by addin 1.
State ⇒ Feedback
and/or check what difference this makes inside the Date_Holidays code?
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Unable to retrieve list of holidays
Due ⇒ 02/07/2009
Queue ⇒ Kronolith
Milestone ⇒
Patch ⇒ Yes
New Attachment: holidays.php.patch
State ⇒ Unconfirmed
timestamp to Date_Holidays getHolidayForDate. Interestingly the
attached patch fixes the problem.