Tickets :: [#7934] smb driver's _command needs to be charset aware

6.0.0-alpha14

7/3/25

Summary	smb driver's _command needs to be charset aware
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	leena.heino (at) uta (dot) fi
Created	02/02/2009 (5995 days ago)
Due
Updated	05/31/2009 (5877 days ago)
Assigned
Resolved	05/31/2009 (5877 days ago)
Milestone
Patch	No

05/31/2009 05:18:46 PM	Jan Schneider	Assigned to Jan Schneider Taken from Michael Slusarz State ⇒ Resolved Patch ⇒ No

05/31/2009 05:13:52 PM	CVS Commit	Comment #15	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/NLS/NLS.php?rt=horde&r1=1.82.4.23&r2=1.82.4.24&ty=u

02/10/2009 07:28:33 PM	Chuck Hagenbuch	Comment #14 State ⇒ Duplicate	Reply to this comment
Agreed.

02/10/2009 06:08:07 PM	Michael Slusarz	Comment #13	Reply to this comment
Possible duplicate (or at least similar) to Ticket #5725?

02/06/2009 11:41:14 PM	leena (dot) heino (at) uta (dot) fi	Comment #12	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] That doesn't make any sense to me because - we already set LC_ALL in horde That may be, but that environment is not passed to smbclient command in _command(). This might be a problem with your system, if LC_ALL doesn't set LC_CTYPE. Or are you saying that LC_ALL isn't set either? From my point of view in the testing, it seems that the LC_ALL is not set when the smbclient command is evoked in the smb backend driver. [Show Quoted Text - 16 lines][Hide Quoted Text] - this only works with horde anyway, but this is a pear package. please revert. Done. Although the 1st point seems irrelevant to me: if this is truly a PEAR package, then we necessarily have to set LC_* inside the driver because there are no guarantees that it will have been set elsewhere since Horde is not a pre-requisite. My testing showed that smbdriver might work correctly without this patch, but only if host's default environment and the current locale in gollem use the same charset. But the assumption that the files in the Samba backend have the same locale like the current Horde frontend is completely wrong. If at all, then we need to specify a charset per backend, and convert to/from that. Actually smbclient command does the character conversion for you when you give the character set you want in the LC_CTYPE.

02/06/2009 11:16:08 PM	Jan Schneider	Comment #11	Reply to this comment
That doesn't make any sense to me because - we already set LC_ALL in horde That may be, but that environment is not passed to smbclient command in _command(). This might be a problem with your system, if LC_ALL doesn't set LC_CTYPE. Or are you saying that LC_ALL isn't set either? [Show Quoted Text - 11 lines][Hide Quoted Text] - this only works with horde anyway, but this is a pear package. please revert. Done. Although the 1st point seems irrelevant to me: if this is truly a PEAR package, then we necessarily have to set LC_* inside the driver because there are no guarantees that it will have been set elsewhere since Horde is not a pre-requisite. My testing showed that smbdriver might work correctly without this patch, but only if host's default environment and the current locale in gollem use the same charset. But the assumption that the files in the Samba backend have the same locale like the current Horde frontend is completely wrong. If at all, then we need to specify a charset per backend, and convert to/from that.

02/06/2009 11:11:43 PM	Jan Schneider	Comment #10	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] That doesn't make any sense to me because - we already set LC_ALL in horde - this only works with horde anyway, but this is a pear package. please revert. Done. Although the 1st point seems irrelevant to me: if this is truly a PEAR package, then we necessarily have to set LC_* inside the driver because there are no guarantees that it will have been set elsewhere since Horde is not a pre-requisite. But we don't know which locale to use, if not using Horde.

02/06/2009 07:58:30 PM	leena (dot) heino (at) uta (dot) fi	Comment #9	Reply to this comment
That doesn't make any sense to me because - we already set LC_ALL in horde That may be, but that environment is not passed to smbclient command in _command(). - this only works with horde anyway, but this is a pear package. please revert. Done. Although the 1st point seems irrelevant to me: if this is truly a PEAR package, then we necessarily have to set LC_* inside the driver because there are no guarantees that it will have been set elsewhere since Horde is not a pre-requisite. My testing showed that smbdriver might work correctly without this patch, but only if host's default environment and the current locale in gollem use the same charset.

02/06/2009 06:26:06 PM	Michael Slusarz	Comment #8	Reply to this comment
That doesn't make any sense to me because - we already set LC_ALL in horde - this only works with horde anyway, but this is a pear package. please revert. Done. Although the 1st point seems irrelevant to me: if this is truly a PEAR package, then we necessarily have to set LC_* inside the driver because there are no guarantees that it will have been set elsewhere since Horde is not a pre-requisite.

02/06/2009 06:24:28 PM	CVS Commit	Comment #7	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.1.2.4&r2=1.1.2.5&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.36.4.28&r2=1.36.4.29&ty=u

02/06/2009 06:23:02 PM	CVS Commit	Comment #6	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.4&r2=1.5&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.89&r2=1.90&ty=u

02/06/2009 06:00:17 PM	Jan Schneider	Comment #5 State ⇒ Feedback	Reply to this comment
That doesn't make any sense to me because - we already set LC_ALL in horde - this only works with horde anyway, but this is a pear package. please revert.

02/06/2009 05:58:08 PM	Michael Slusarz	Comment #4 Assigned to Michael Slusarz State ⇒ Resolved	Reply to this comment
Added.

02/06/2009 05:57:48 PM	CVS Commit	Comment #3	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.1.2.3&r2=1.1.2.4&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.36.4.27&r2=1.36.4.28&ty=u

02/06/2009 05:56:52 PM	CVS Commit	Comment #2	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.3&r2=1.4&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.88&r2=1.89&ty=u

02/03/2009 03:42:05 AM	Chuck Hagenbuch	State ⇒ Accepted

02/03/2009 03:41:56 AM	Chuck Hagenbuch	Version ⇒ HEAD Queue ⇒ Horde Framework Packages

02/02/2009 03:23:28 PM	leena (dot) heino (at) uta (dot) fi	Comment #1 Priority ⇒ 1. Low State ⇒ New New Attachment: horde-framework3-smbcommandcharset.patch Patch ⇒ Yes Milestone ⇒ Queue ⇒ Gollem Summary ⇒ smb driver's _command needs to be charset aware Type ⇒ Enhancement	Reply to this comment
smb driver's _command() function needs to sey LC_CTYPE enviroment variable. Otherwise gollem is not able show correctly or search for file names with accented characters.