Summary | \U does not behave as described in the custom sql driver |
Queue | Vacation |
Queue Version | 3.1-RC1 |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | jason.stumpf (at) gmail (dot) com |
Created | 01/29/2009 (6004 days ago) |
Due | |
Updated | 08/18/2009 (5803 days ago) |
Assigned | 01/29/2009 (6004 days ago) |
Resolved | 08/18/2009 (5803 days ago) |
Milestone | 3.1.1 |
Patch | No |
Assigned to Jan Schneider
State ⇒ Resolved
http://cvs.horde.org/diff.php/forwards/config/conf.xml?rt=horde&r1=1.7.2.3&r2=1.7.2.4&ty=u
http://cvs.horde.org/diff.php/forwards/docs/CHANGES?rt=horde&r1=1.34.2.14&r2=1.34.2.15&ty=u
http://cvs.horde.org/diff.php/forwards/lib/Driver/customsql.php?rt=horde&r1=1.13.2.6&r2=1.13.2.7&ty=u
http://cvs.horde.org/diff.php/vacation/config/conf.xml?rt=horde&r1=1.15.2.12&r2=1.15.2.13&ty=u
http://cvs.horde.org/diff.php/vacation/docs/CHANGES?rt=horde&r1=1.57.2.21&r2=1.57.2.22&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver/customsql.php?rt=horde&r1=1.2.2.5&r2=1.2.2.6&ty=u
http://cvs.horde.org/diff.php/forwards/config/conf.xml?rt=horde&r1=1.15&r2=1.16&ty=u
http://cvs.horde.org/diff.php/forwards/docs/CHANGES?rt=horde&r1=1.47&r2=1.48&ty=u
http://cvs.horde.org/diff.php/forwards/lib/Driver/customsql.php?rt=horde&r1=1.20&r2=1.21&ty=u
http://cvs.horde.org/diff.php/vacation/config/conf.xml?rt=horde&r1=1.34&r2=1.35&ty=u
http://cvs.horde.org/diff.php/vacation/docs/CHANGES?rt=horde&r1=1.79&r2=1.80&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver/customsql.php?rt=horde&r1=1.6&r2=1.7&ty=u
in Driver.php where it says:
function Vacation_Driver($user, $realm, $params = array())
{
$this->_params = $params;
// Check if hordeauth is set to 'full'
$hordeauth = $this->getParam('hordeauth');
if ($hordeauth !== 'full') {
@list($user,) = explode('@', $user, 2);
}
$this->_user = $user;
if (!isset($params[$realm])) {
$realm = 'default';
}
$this->_realm = $realm;
}
change it to: function Vacation_Driver($user, $realm, $params = array())
{
$this->_params = $params;
if (!isset($params[$realm])) {
$realm = 'default';
}
$this->_realm = $realm;
// Check if hordeauth is set to 'full'
$hordeauth = $this->getParam('hordeauth');
if ($hordeauth !== 'full') {
@list($user,) = explode('@', $user, 2);
}
$this->_user = $user;
}
I don't know your codebase well, but it seems to me that getParam
depends on $this->_ream being set, but it wasn't.
Milestone ⇒ 3.1
State ⇒ Accepted
Type ⇒ Enhancement
Priority ⇒ 1. Low
user name, i.e. username without domain or with realm suffix.
Assigned to Jan Schneider
State ⇒ Assigned
hordeauth parameter to.
hordeauth parameter to.
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Vacation
Summary ⇒ \U does not behave as described in the custom sql driver
Type ⇒ Bug
The config for custom sql says "The current FULL username will be
provided as \U", but actually only the username up to the @ is
provided. (I know this could be fixed by just changing the
description, but at least to me, changing the behavior to give the
full username would be much more helpful.)