[#7916] \U does not behave as described in the custom sql driver
Summary \U does not behave as described in the custom sql driver
Queue Vacation
Queue Version 3.1-RC1
Type Enhancement
State Resolved
Priority 1. Low
Owners Jan Schneider <jan (at) horde (dot) org>
Requester jason (dot) stumpf (at) gmail (dot) com
Created 01/29/2009 (1571 days ago)
Due
Updated 08/18/2009 (1370 days ago)
Assigned 01/29/2009 (1571 days ago)
Resolved 08/18/2009 (1370 days ago)
Attachments
Milestone 3.1.1
Patch No

History
08/18/2009 12:55:42 PM Jan Schneider Comment #9
Assigned to Jan Schneider
State ⇒ Resolved		 Reply to this comment
I did the same for forwards too.
03/19/2009 03:05:41 PM Jan Schneider Milestone ⇒ 3.1.1
 
01/29/2009 10:17:44 PM jason (dot) stumpf (at) gmail (dot) com Comment #6 Reply to this comment
Sorry, I didn't refresh before commenting... didn't see your comments.
01/29/2009 10:15:40 PM jason (dot) stumpf (at) gmail (dot) com Comment #5 Reply to this comment
This fixes it at least for me:



in Driver.php where it says:

     function Vacation_Driver($user, $realm, $params = array())

     {

         $this->_params = $params;



         // Check if hordeauth is set to 'full'

         $hordeauth = $this->getParam('hordeauth');

         if ($hordeauth !== 'full') {

             @list($user,) = explode('@', $user, 2);

         }

         $this->_user = $user;



         if (!isset($params[$realm])) {

             $realm = 'default';

         }

         $this->_realm = $realm;

     }



change it to:    function Vacation_Driver($user, $realm, $params = array())

     {

         $this->_params = $params;



         if (!isset($params[$realm])) {

             $realm = 'default';

         }

         $this->_realm = $realm;



         // Check if hordeauth is set to 'full'

         $hordeauth = $this->getParam('hordeauth');

         if ($hordeauth !== 'full') {

             @list($user,) = explode('@', $user, 2);

         }

         $this->_user = $user;



     }



I don't know your codebase well, but it seems to me that getParam 
depends on $this->_ream being set, but it wasn't.
01/29/2009 10:10:31 PM Jan Schneider Milestone ⇒ 3.1
Taken from Jan Schneider
 
01/29/2009 10:10:14 PM Jan Schneider Comment #4
Priority ⇒ 1. Low
State ⇒ Accepted
Type ⇒ Enhancement		 Reply to this comment
I think we need different placeholders for full user name and local 
user name, i.e. username without domain or with realm suffix.
01/29/2009 10:03:08 PM Jan Schneider Comment #3
State ⇒ Assigned
Assigned to Jan Schneider		 Reply to this comment
Same in the sql driver.  Also, it doesn't seem to care what I set the
hordeauth parameter to.
The latter has been fixed in CVS already.
01/29/2009 09:47:04 PM jason (dot) stumpf (at) gmail (dot) com Comment #2 Reply to this comment
Same in the sql driver.  Also, it doesn't seem to care what I set the 
hordeauth parameter to.
01/29/2009 09:36:05 PM jason (dot) stumpf (at) gmail (dot) com Comment #1
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Vacation
Summary ⇒ \U does not behave as described in the custom sql driver
Type ⇒ Bug
Priority ⇒ 1. Low		 Reply to this comment
I am using vacation-FRAMEWORK_3-2009-01-29.tar.gz



The config for custom sql says "The current FULL username will be 
provided as \U", but actually only the username up to the @ is 
provided.  (I know this could be fixed by just changing the 
description, but at least to me, changing the behavior to give the 
full username would be much more helpful.)