Summary | login.php IE7 minor bug if no loginparams set |
Queue | Gollem |
Queue Version | 1.1-RC1 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | horde (at) smartsector (dot) hu |
Created | 01/26/2009 (6005 days ago) |
Due | |
Updated | 01/28/2009 (6003 days ago) |
Assigned | 01/27/2009 (6004 days ago) |
Resolved | 01/28/2009 (6003 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Lawrence
loginparams is not needed since it is done in Gollem::canAutologin()).
Assigned to Michael Slusarz
State ⇒ Feedback
loginparams is not needed since it is done in Gollem::canAutologin()).
http://cvs.horde.org/diff.php/gollem/docs/CHANGES?rt=horde&r1=1.165&r2=1.166&ty=u
http://cvs.horde.org/diff.php/gollem/login.php?rt=horde&r1=1.126&r2=1.127&ty=u
http://cvs.horde.org/diff.php/gollem/docs/CHANGES?rt=horde&r1=1.114.2.44&r2=1.114.2.45&ty=u
http://cvs.horde.org/diff.php/gollem/login.php?rt=horde&r1=1.94.2.15&r2=1.94.2.16&ty=u
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ login.php IE7 minor bug if no loginparams set
Queue ⇒ Gollem
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
$Horde: gollem/login.php,v 1.126 2009-01-06 17:50:05 jan Exp $
And we recive the following malfunction:
If i do not set loginparams (jsut use an empty array) then only in IE7
the login screen is empty.
the IE stop working in the line 198 exit; - other borwsers skip this problem.
the problem originally in the line 190 where we set up:
$redirect_params['autologin'] = 1;
i modify the 188-189 lines like this:
} elseif (Util::getFormData('change_backend') &&
empty($GLOBALS['gollem_backends'][$backend_key]['loginparams']) &&
Gollem::canAutoLogin($backend_key, $autologin)
) {
it's works but i'm not sure this solution is good or not...