6.0.0-alpha14
7/2/25

[#7889] Enhance vinfo hook
Summary Enhance vinfo hook
Queue IMP
Queue Version 4.3.2
Type Enhancement
State Rejected
Priority 1. Low
Owners
Requester manuel (at) mausz (dot) at
Created 01/25/2009 (6002 days ago)
Due
Updated 02/10/2009 (5986 days ago)
Assigned
Resolved 02/10/2009 (5986 days ago)
Milestone
Patch Yes

History
02/10/2009 04:54:39 PM Chuck Hagenbuch Comment #6
State ⇒ Rejected
Reply to this comment
Please post this in the wiki if you want to share it; going forwards 
we'll enhance the pre/post hooks.
01/29/2009 05:06:05 PM manuel (at) mausz (dot) at Comment #5 Reply to this comment
We've one installation for our webspace- and our dedicated customers. 
Webspace customers are uniquely identifiable while dedicated customers 
are not. Thus they have to select their own server in the server list. 
Webspace customers just use a dummy entry "autodetection" which 
triggers the hook.



I'm fully with you in expanding the pre-/post-hooks. I just wanted to 
point out why I used the vhook for now.
01/28/2009 03:02:53 PM Chuck Hagenbuch Comment #4 Reply to this comment
If you're parsing the server from the username anyway, why do you need 
the selected server? And, like I said, I'd really prefer to make it 
easier to do things with the pre- and post-auth hooks instead of 
extending the vinfo hook, even if it would be harder *now*.
01/28/2009 09:52:19 AM manuel (at) mausz (dot) at Comment #3 Reply to this comment
As far as I remember I tried to use pre/post_auth in the first place 
but it would've required more work (e.g. a lot of session variables 
will be set before authenticate()-call). Also there's currently no way 
to get the value of the selected server in any session variable before 
login.
01/28/2009 02:59:37 AM Chuck Hagenbuch Comment #2
State ⇒ Feedback
Reply to this comment
Why not use a pre- or post-authenticate hook for this? If that's not 
currently possible - it might not be, though it might just require 
mucking with $_SESSION data directly - then let's work towards making 
it possible. I think the pre/post authenticate hooks are a much 
cleaner way to do this sort of thing than the vinfo hook, which I'd 
like to phase out.
01/25/2009 06:48:01 PM manuel (at) mausz (dot) at Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Enhance vinfo hook
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ Yes
New Attachment: horde_vinfo.patch Download
State ⇒ New
Reply to this comment
The attached patch (against FRAMEWORK_3 tag) adds two (hopefully) 
useful changes to the vinfo hook:

#1 adds the possibility to modify the selected mailserver during 
login. This allows us to select the correct mailserver by parsing the 
login username. I have also created a simple example in hooks.php.dist.

#2 passes the value of $_SESSION['imp']['user'] as an array item. So 
you don't have to get the value from the session. This is just a api 
correction for the $value-param needed for #1.



If necessary I can create a patch for HEAD aswell.

Saved Queries