| Summary | Driver.php,v 1.46 - realm and conf.php |
| Queue | Vacation |
| Queue Version | 3.1-RC1 |
| Type | Bug |
| State | Resolved |
| Priority | 2. Medium |
| Owners | jan (at) horde (dot) org |
| Requester | horde (at) smartsector (dot) hu |
| Created | 01/23/2009 (6004 days ago) |
| Due | |
| Updated | 01/29/2009 (5998 days ago) |
| Assigned | 01/24/2009 (6003 days ago) |
| Resolved | 01/29/2009 (5998 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
http://cvs.horde.org/diff.php/vacation/lib/Driver/customsql.php?rt=horde&r1=1.4&r2=1.5&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver.php?rt=horde&r1=1.47&r2=1.48&ty=u
Notice: Undefined variable: realm in
/usr/share/horde/vacation/lib/Driver.php on line 441
Notice: Undefined variable: realm in
/usr/share/horde/vacation/lib/Driver/customsql.php on line 41
versions:
$Horde: vacation/lib/Driver.php,v 1.47 2009-01-29 11:16:15 jan Exp $
$Horde: vacation/lib/Driver/customsql.php,v 1.4 2009-01-29 11:16:16 jan Exp $
http://cvs.horde.org/diff.php/vacation/docs/CHANGES?rt=horde&r1=1.57.2.16&r2=1.57.2.17&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Block/summary.php?rt=horde&r1=1.7.2.1&r2=1.7.2.2&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver.php?rt=horde&r1=1.35.2.4&r2=1.35.2.5&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver/customsql.php?rt=horde&r1=1.2.2.2&r2=1.2.2.3&ty=u
http://cvs.horde.org/diff.php/vacation/main.php?rt=horde&r1=1.55.2.7&r2=1.55.2.8&ty=u
Taken from Chuck Hagenbuch
the 'hordeauth' parameter, can you test if that fixes things for you.
@Chuck: realms can be set manually in conf.php. It's a cruft from
pre-conf.xml times.
http://cvs.horde.org/diff.php/vacation/docs/CHANGES?rt=horde&r1=1.74&r2=1.75&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Block/summary.php?rt=horde&r1=1.8&r2=1.9&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver.php?rt=horde&r1=1.46&r2=1.47&ty=u
http://cvs.horde.org/diff.php/vacation/lib/Driver/customsql.php?rt=horde&r1=1.3&r2=1.4&ty=u
http://cvs.horde.org/diff.php/vacation/main.php?rt=horde&r1=1.67&r2=1.68&ty=u
Assigned to Chuck Hagenbuch
Assigned to Jan Schneider
State ⇒ Feedback
handling of $realm looks really wonky to me - Jan, any thoughts here?
I think we should move it entirely into the driver. And I also don't
see where $params['realm'] would ever be set.
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Vacation
Summary ⇒ Driver.php,v 1.46 - realm and conf.php
Type ⇒ Bug
Priority ⇒ 2. Medium
user names like:
info@example.com
you must set up the $params correctly before you check the hordeauth.
here is a patch, just need change the lines:
The original one:
function Vacation_Driver($user, $realm, $params = array())
{
$this->_params = $params;
// Check if hordeauth is set to 'full'
$hordeauth = $this->getParam('hordeauth');
if ($hordeauth !== 'full') {
@list($user,) = explode('@', $user, 2);
}
$this->_user = $user;
if (!isset($params[$realm])) {
$realm = 'default';
}
$this->_realm = $realm;
}
The fixed one:
function Vacation_Driver($user, $realm, $params = array())
{
$this->_params = $params;
if (!isset($params[$realm])) {
$realm = 'default';
}
$this->_realm = $realm;
// Check if hordeauth is set to 'full'
$hordeauth = $this->getParam('hordeauth');
if ($hordeauth !== 'full') {
@list($user,) = explode('@', $user, 2);
}
$this->_user = $user;
}