Changes have been made in Git for this ticket:

Bug #7866: fix open folder accesskey

http://git.horde.org/diff.php/imp/lib/IMP.php?rt=horde-git&r1=8a0737a925868190cab1b15a3df527bedc43bb3a&r2=586e75d5e090091cfc040269d5c97436dd2f54ff
http://git.horde.org/diff.php/imp/templates/menu.html?rt=horde-git&r1=2b2b2f976d1dd61ef1d16e77889b7eef6c8d574a&r2=586e75d5e090091cfc040269d5c97436dd2f54ff

Changes have been made in Git for this ticket:

Bug #7866: Fix folder list accesskey

http://git.horde.org/diff.php/imp/lib/IMP.php?rt=horde-git&r1=e0d5c61901c45e599505d09bb5a7b3f9d3db9783&r2=2b2b2f976d1dd61ef1d16e77889b7eef6c8d574a
http://git.horde.org/diff.php/imp/templates/menu.html?rt=horde-git&r1=95f05242b7d5711472e6690da533cac2a0d62acb&r2=2b2b2f976d1dd61ef1d16e77889b7eef6c8d574a

The DIMP-specific issues are solved, I opened a new bug for issues 
with the general access key code: bug #8057.

I guess the submenu access keys don't work because they are not visible.

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.6.2.2&r2=1.6.2.3&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.7.2.2&r2=1.7.2.3&ty=u

In IMP:



Access keys on mailbox submenus don't work anymore, i.e. for replying to mail.



When hitting the access key to delete messages in the mailbox view, I get:



Fehler: elt.click is not a function

Quelldatei: http://neo.wg.de/horde/js/src/accesskeys.js

Zeile: 33

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.6.2.1&r2=1.6.2.2&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.7.2.1&r2=1.7.2.2&ty=u

Not sure what I was thinking - this has been fixed.

The accesskey is supposed to just activate the select, so that you can 
start typing a folder name. Now it just submits the form, with no 
chance to pick the folder to switch to.

That's because the accesskey was pointing to the wrong element.  Fixed.
I don't think this is an issue anymore - it looks like the javascript 
in the accesskeys.js correctly handles this problem.

No.  I was not going to backport until all issues are resolved.

The access key for the folder selection menu in IMP (upper right, for 
switching the view to a different folder) no longer works.



I have no problem with getting rid of duplicate access keys in 
generated HTML instead of trying to deal with this in js, btw. The 
only places we even have them are where we re-output a pre-assigned 
template.

Have those changes been merged to FW_3 already? I still see issues there.

Ping.  Is this still broken for anyone?

Simply put, accesskeys are a PITA.  I think I have fixed the compose 
issue, but I wouldn't be surprised if I rebroke something else.   
Outside of manually eliminating duplicate accesskeys, I'm not sure 
there is much more we can do.

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.11&r2=1.12&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.12&r2=1.13&ty=u

I still have the compose screen problem.

Fixed those 2 issues.

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.10&r2=1.11&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.11&r2=1.12&ty=u

The basics work in DIMP the last time I checked. The issues I know about are:



- accesskey for back to mailbox ("k" in english) in the message view 
doesn't work (just highlights one of the links)

- accesskey for sending a message ("s" in english) on the compose 
screen submits the form twice. the message is sent, but the window 
stays open with a "you have already submitted this form" error



This is FF3/Mac.

Guess I forgot to ask if these changes made things work.

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.9&r2=1.10&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.10&r2=1.11&ty=u

Getting better - delete works from the message view now. However Back 
to Inbox (k) doesn't work (just selects one of the links, have to hit 
return to activate it), and the View Message accesskey (m) opens two 
windows instead of one.

OK - managed to get the FF3 behavior on the message page.  This was 
the topic of Ticket #6803.  IMHO, the proper solution is to remove 
duplicate accesskeys rather than trying to work around the various tag 
types - especially since the standard does seem to highy discourage 
duplicate accesskeys (which makes sense).

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.8&r2=1.9&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.9&r2=1.10&ty=u

How so - meaning, why wouldn't the current code work?  This works fine 
for me in FF3/Win - I just tried it on the mailbox page w/30 messages 
in IMP and Delete works fine even though the access key is deleted.

I haven't had a chance to try this in DIMP yet, but it sounds great. 
However, it means that accesskeys.js no longer works for its original 
purpose - fixing accesskeys in FF3. With any duplicated links (delete 
message, which appears at the top and bottom of the message view, 
etc.), the access key is just highlighted now, not activated.



It does fix a problem that went along with that, where using the new 
message access key caused that link to activate twice.

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.7&r2=1.8&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.8&r2=1.9&ty=u

Actually yes - the correct way to do this is via triggering a DOM 
event -- this is a DOM level 2 action, so that means that most 
browsers should support it.  (Of course) It seems that IE handles 
things a bit differently, see:

http://www.howtocreate.co.uk/tutorials/javascript/domevents

so I think we need to use createEventObject() instead for IE (this is 
what prototypejs does, for instance).

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/horde/js/accesskeys.js?rt=horde&r1=1.6&r2=1.7&ty=u
http://cvs.horde.org/diff.php/horde/js/src/accesskeys.js?rt=horde&r1=1.7&r2=1.8&ty=u

Michael, if you've already got something in mind for this, or another 
approach makes more sense to you, please let me know.

With the new event code in DIMP, accesskeys don't work. I think having 
a hash with the various events in it (currently defined in the 
clickhandler), and giving DIMP an accesskey implementation that would 
call into the same hash would work.