Summary | ContactAutoCompleter calls non-existent private MIME::_rfc822Encode |
Queue | Kronolith |
Queue Version | 2.3 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | Horde Developers (at) , chuck (at) horde (dot) org |
Requester | mrubinsk (at) horde (dot) org |
Created | 01/16/2009 (6014 days ago) |
Due | |
Updated | 01/18/2009 (6012 days ago) |
Assigned | |
Resolved | 01/18/2009 (6012 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Assigned to Chuck Hagenbuch
State ⇒ Resolved
http://cvs.horde.org/diff.php/framework/MIME/Attic/MIME.php?rt=horde&r1=1.139.4.46&r2=1.139.4.47&ty=u
http://cvs.horde.org/diff.php/horde/docs/CHANGES?rt=horde&r1=1.515.2.498&r2=1.515.2.499&ty=u
been removed from MIME.php as well. This needs to be added back for
BC reasons, as it is also used (at least) in ContactAutoCompleter.php
problems with older Horde versions.
about client code calling a private method. I guess since FW_3 is
really only being maintained for bugs at this point though, I guess
there's not much worth in adding a public method for any possible
future FW_3 releases as well.
and called _rfc2822Encode. I *think* what we should do is:
- change the calls in the HEAD apps to use the public rfc2822Encode
function and new 2nd parameter
- re-add the original _rfc822Encode function to MIME.php in FW3 for
backwards compatibility with old code.
Any objections or better ideas?
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ ContactAutoCompleter calls non-existent private MIME::_rfc822Encode
Queue ⇒ Kronolith
Assigned to
Milestone ⇒
Patch ⇒ No
State ⇒ Assigned
kronolith's ContacatAutoCompleter.php file. That method was renamed
to _rfc2822Encode() and then made public (renamed to rfc2822Encode())
in MIME.php
The function signature has also changed, and now no longer takes a
'filter' argument, but a 'type' argument in it's place.
This is a sort-of BC break in that the function was changed in MIME,
but kronolith should not have been calling a private method on MIME
directly...