Tickets :: [#7820] BC break in Horde_Share::listShares() method signature

6.0.0-alpha14

6/25/25

Summary	BC break in Horde_Share::listShares() method signature
Queue	Nag
Queue Version	2.3.1
Type	Bug
State	Resolved
Priority	2. Medium
Owners	chuck (at) horde (dot) org
Requester	jukka (at) netland (dot) fi
Created	12/31/2008 (6020 days ago)
Due
Updated	01/13/2009 (6007 days ago)
Assigned	01/13/2009 (6007 days ago)
Resolved	01/13/2009 (6007 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

01/13/2009 03:50:47 PM	Chuck Hagenbuch	Comment #11 Assigned to Chuck Hagenbuch Taken from Horde Developers State ⇒ Resolved	Reply to this comment
Committed.

01/13/2009 03:47:36 PM	CVS Commit	Comment #10	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/mnemo/docs/CHANGES?rt=horde&r1=1.63.2.76&r2=1.63.2.77&ty=u http://cvs.horde.org/diff.php/mnemo/lib/Mnemo.php?rt=horde&r1=1.52.2.14&r2=1.52.2.15&ty=u http://cvs.horde.org/diff.php/mnemo/lib/api.php?rt=horde&r1=1.53.2.31&r2=1.53.2.32&ty=u http://cvs.horde.org/diff.php/mnemo/lib/prefs.php?rt=horde&r1=1.2.10.9&r2=1.2.10.10&ty=u http://cvs.horde.org/diff.php/mnemo/memo.php?rt=horde&r1=1.42.2.12&r2=1.42.2.13&ty=u http://cvs.horde.org/diff.php/mnemo/templates/data/import.inc?rt=horde&r1=1.11.10.4&r2=1.11.10.5&ty=u http://cvs.horde.org/diff.php/mnemo/templates/panel.inc?rt=horde&r1=1.6.2.4&r2=1.6.2.5&ty=u http://cvs.horde.org/diff.php/mnemo/templates/prefs/notepadselect.inc?rt=horde&r1=1.4.12.2&r2=1.4.12.3&ty=u

01/13/2009 03:46:36 PM	CVS Commit	Comment #9	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/kronolith/docs/CHANGES?rt=horde&r1=1.165.2.246&r2=1.165.2.247&ty=u http://cvs.horde.org/diff.php/kronolith/lib/Kronolith.php?rt=horde&r1=1.263.2.79&r2=1.263.2.80&ty=u http://cvs.horde.org/diff.php/nag/docs/CHANGES?rt=horde&r1=1.115.2.109&r2=1.115.2.110&ty=u http://cvs.horde.org/diff.php/nag/lib/Nag.php?rt=horde&r1=1.124.2.32&r2=1.124.2.33&ty=u

01/13/2009 12:07:22 PM	Jan Schneider	Comment #8	Reply to this comment
Looks good.

01/13/2009 04:36:55 AM	Chuck Hagenbuch	Comment #7 State ⇒ Feedback New Attachment: 7820.patch.txt	Reply to this comment
Proposed patch for Nag, I'll add Mnemo and Kronolith (FW_3 only) if this looks good. No need for spread to be compatible with Horde 3.1.

01/13/2009 04:28:45 AM	Chuck Hagenbuch	Comment #6 Summary ⇒ BC break in Horde_Share::listShares() method signature	Reply to this comment
For posterity, this happened because I removed the listShares() method completely in this commit: http://cvs.horde.org/diff.php/framework/Share/Share.php?r1=1.142&r2=1.143 And then when the extended parameters were added back in, $parent and $allLevels weren't there since this was no longer DataTree-specific code: http://cvs.horde.org/diff.php/framework/Share/Share.php?r1=1.162&r2=1.163

01/12/2009 10:56:41 AM	Jan Schneider	Comment #5	Reply to this comment
The three places would be: nag/lib/Nag.php mnemo/lib/Mnemo.php kronolith/lib/Kronolith.php and additionally: incubator/spread/lib/Spread.php

01/12/2009 10:53:17 AM	Jan Schneider	Comment #4	Reply to this comment
Reverting to the original signature in Horde_Share would break forward compatibility, so I guess the cheapest solution is to test for the Horde version in the three places where we actually use the additional parameters and add a switch there.

01/12/2009 04:19:40 AM	Chuck Hagenbuch	Comment #3 Assigned to Horde Developers State ⇒ Assigned	Reply to this comment
I don't think there's anything we can do about this at this point - anyone else?

01/04/2009 06:24:32 AM	Chuck Hagenbuch	Comment #2 State ⇒ Feedback	Reply to this comment
You're going to need a different Horde version or a different Nag version. At this point I'm not sure if any Nag version should have worked with that version of listShares; it's more likely to be an unintentional BC break when going from x.1.x to x.2.x.

12/31/2008 12:07:25 PM	jukka (at) netland (dot) fi	Comment #1 Priority ⇒ 2. Medium State ⇒ Unconfirmed Patch ⇒ No Milestone ⇒ Summary ⇒ Fresh Nag installation does not show any tasklists nor tasks Type ⇒ Bug Queue ⇒ Nag	Reply to this comment
We have Horde version 3.1.5. ----8<---- Dec 31 13:20:40 HORDE [error] [nag] 0 does not exist [on line 281 of "/home/httpd/html/horde/nag-h3-2.3.1/lib/Nag.php"] ----8<---- There is listShares function call in Nag.php at line 281. There seems to be wrong parameters for listShares function. Original version of line 282: ----8<---- $tasklists = $GLOBALS['nag_shares']->listShares(Auth::getAuth(), $permission, $owneronly ? Auth::getAuth() : null, 0, 0, 'name'); ----8<---- I added 'parent' and 'allLevels' parameters in the middle on parameters: ----8<---- $tasklists = $GLOBALS['nag_shares']->listShares(Auth::getAuth(), $permission, $owneronly ? Auth::getAuth() : null, DATATREE_ROOT, true, 0, 0, 'name'); ----8<---- The behaves now quite well. But I don't have any idea what 'parent' and 'allLevels' parameters should be.