6.0.0-beta1
7/17/25

[#7784] Kronolith problem with Holidays
Summary Kronolith problem with Holidays
Queue Horde Groupware Webmail Edition
Queue Version 1.2.1
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester warter (at) intranet (dot) hu
Created 12/16/2008 (6057 days ago)
Due 12/16/2008 (6057 days ago)
Updated 01/27/2009 (6015 days ago)
Assigned
Resolved 01/27/2009 (6015 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
01/27/2009 03:09:12 PM Jan Schneider Comment #8
Assigned to Jan Schneider
State ⇒ Resolved
Reply to this comment
This is fixed in Date_Holidays 0.21.0 which will be included with the 
next release.
12/19/2008 07:26:19 AM hmmsjan (at) kpnplanet (dot) nl Comment #7 Reply to this comment
How a fix introduces a problem:



function_exists needs a string argument, this is corrected in 1.2.1 and

immediately breaks the 1.2.1 version:



the easter_days function returns the number of days after Mar 21 
instead of a Date object,

and calling a member function of an integer is not possible.





With my poor PHP knowledge it should be moreorless:



  396     function calcEaster($year)

  397     {

  398         if (function_exists('easter_days')) {

  399             $mar21offset= easter_days($year);

  400             $eastern=new Date(sprintf("%04d-03-21",$year));

  401             $eastern->addSeconds($mar21offset*86400);

  402             return($eastern);

  403         }





Kind Regards,






12/18/2008 03:36:22 PM Jan Schneider Comment #6 Reply to this comment
This has nothing to do with the error message of this bug report. 
Beside that, this patch is already applied in 1.2.1:

http://cvs.horde.org/co.php/groupware/patches/Attic/pear-Date-Holidays-Driver-Christian.php.patch?sa=1&r=1.2
12/18/2008 03:02:47 PM warter (at) intranet (dot) hu Comment #5 Reply to this comment
That cause the problem:



diff Date/Holidays/Driver/Christian.php Date-new/Holidays/Driver/Christian.php

398c398

<         if (function_exists(easter_days())) {

---
         if (function_exists('easter_days')) {
12/18/2008 06:17:31 AM hmmsjan (at) kpnplanet (dot) nl Comment #4 Reply to this comment
See message below.

Replacing the pear/Date folder by the pear/Date folder from

the 1.2 webmail edition brings back life in the program,

so I can go on with further testing, hoping that this does not break

other things....



Good luck with your nice program!


12/17/2008 07:04:04 AM hmmsjan (at) kpnplanet (dot) nl Comment #3 Reply to this comment
Dear Developers,



I understand that it's frustrating if your result of hours of coding 
breaks due to third-party software,

but what I see is that 1.2 works very nice and 1.2.1 simply does not 
start properly because of

the Dutch variant of this error message: Menu at the left and blank 
screen, no portal, so I've to

stick to 1.2. Is there, apart from switching off holiday display, a 
workaround, e.g. copying

the 1.2 version of the pear/holiday package into 1.2.1???



Thanks a lot and kind Regards,


12/16/2008 02:46:55 PM Chuck Hagenbuch Comment #2
State ⇒ Not A Bug
Reply to this comment
Please stop reporting duplicate bugs in software that isn't ours.



Can we just get rid of Date_Holidays support?
12/16/2008 01:12:28 PM warter (at) intranet (dot) hu Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Kronolith problem with Holidays
Due ⇒ 12/16/2008
Queue ⇒ Horde Groupware Webmail Edition
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
Kronolith drops http 500 error and the error log contains the 
following error message:

[Tue Dec 16 13:21:37 2008] [error] [client 1.1.1.1] PHP Fatal error:   
Call to a member function getNextDay() on a non-object in 
/var/www/htdocs/horde/pear/Date/Holidays/Driver/Christian.php on line 
152, referer: https://www.vampear.hu/horde/services/portal/sidebar.php

Slackware Linux 12.2 / Kernel 2.6.27.7

Saved Queries