Summary | DIMP not always showing translated labels |
Queue | IMP |
Queue Version | 4.3.2 |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | thomas (at) gelf (dot) net |
Created | 12/05/2008 (6033 days ago) |
Due | |
Updated | 01/12/2010 (5630 days ago) |
Assigned | 12/22/2008 (6016 days ago) |
Resolved | 12/29/2008 (6009 days ago) |
Milestone | |
Patch | Yes |
Request #7759- Show translated INBOX prefix.http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=6a839412944d9486aceb6da1022209b4576e3a0b&r2=0f708c1abd837f017ec35b82c039ef4118df42d9
http://git.horde.org/diff.php/imp/lib/IMP.php?rt=horde-git&r1=6150f1e289d7c532f380e11292da93d90e1255d1&r2=0f708c1abd837f017ec35b82c039ef4118df42d9
Taken from Jan Schneider
State ⇒ Resolved
http://cvs.horde.org/diff.php/imp/docs/CHANGES?rt=horde&r1=1.699.2.372&r2=1.699.2.373&ty=u
http://cvs.horde.org/diff.php/imp/lib/IMP.php?rt=horde&r1=1.449.4.122&r2=1.449.4.123&ty=u
Queue ⇒ IMP
Version ⇒ 4.3.2
...
So does this not display correctly in IMP either?
"wrong" labels. Easiest way to reproduce this:
* create a new subfolder below your Inbox
* switch to this subfolder
It will show you INBOX/Folder instead of Inbox/Folder - and in other
languages it is even worse, as INBOX remains INBOX and is not
translated to "Posteingang", "Posta in arrivo" etc.
State ⇒ Feedback
translation issues. The translation works, but gets lost once it's
used inside the tree hierarchy. At least that's how I understood
Thomas' report.
label in DIMP is set not via the cached mailbox information on the
browser but via the 'label' metadata sent in the ListMessages
response. This label is created using IMP::getLabel() - which is the
way we generate labels everywhere in IMP. So does this not display
correctly in IMP either?
State ⇒ Assigned
translation issues. The translation works, but gets lost once it's
used inside the tree hierarchy. At least that's how I understood
Thomas' report.
as two related properties:
- mbox name (not translated, attribute "l", example: "INBOX_MeinOrdner"
- label (missing hierarchy information, just "MeinOrdner" in the above
example)
DIMP is currently using mbox as a header, there has been a _-to__ and
/-to-_ on serverside, transformation back is afair happening in JS.
What I'm doing in my patch is
- check wheter given folder is a special folder, if so: use label
instead of mbox
- otherwise find out if folder is a subfolder, if so check whether the
root folder is a special folder and if so: use label instead of mbox
for root folder name, concatenate parts once again
I agree that providing correct label as an attribute on serverside
would be the correct and more elegant method, but that would require
one additional attribute (label is required for tree display, mbox for
communication with the server, ListMessages etc) as there is no such
attribute right now.
The patch I've attached is "mixing" given information in label and
mbox and I agree that it is a really opportunistic attempt of solving
this problem - however IMO it has been the least intrusive one.
Cheers,
Thomas
State ⇒ Feedback
should take place on the server (via PHP code) *not* on the browser
(via JS).
However, this looks related to some of the other folder naming tickets
floating around so I will wait for Jan's input.
State ⇒ Assigned
Assigned to Jan Schneider
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ DIMP not always showing translated labels
Queue ⇒ DIMP
Milestone ⇒
Patch ⇒ Yes
New Attachment: dimp_special_foldername.patch
State ⇒ New
Arrivo" etc. However if I choose a subfolder of my INBOX heading will
be "INBOX/subfolder" instead of "Posteingang/subfolder".
The attached patch fixes this behaviour, I hope it is done the right
way ;-) I tried different approaches (pass label when clicking and
setting correct label on server side etc), this one seemed to be the
cleanest one.
Please note that this also fixes the same issue with special folder
names having a translated label. Afaik there is no such support in
DIMP right now - displayed special folder names will always equal
server-side folder name.
My DIMP is patched to have server-side Drafts / Sent / Trash folders
being usable as such in Thunderbird & Co and nonetheless displayed
using the user's language in DIMP. I'll immediately open a related bug
report, as IMO this seems to be a really important feature.
Best regards,
Thomas Gelf