6.0.0-beta1
7/8/25

[#7675] Missing argument 7 for Whups_Driver::mail()
Summary Missing argument 7 for Whups_Driver::mail()
Queue Whups
Queue Version 1.0
Type Bug
State Resolved
Priority 1. Low
Owners chuck (at) horde (dot) org
Requester stevens (at) stevens (dot) it
Created 11/12/2008 (6082 days ago)
Due
Updated 11/12/2008 (6082 days ago)
Assigned
Resolved 11/12/2008 (6082 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
11/12/2008 08:41:31 PM Chuck Hagenbuch Comment #3
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Reply to this comment
Fixed, thanks.
11/12/2008 08:31:19 PM CVS Commit Comment #2 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/whups/lib/Driver.php?r1=1.201&r2=1.202&ty=u
11/12/2008 07:36:21 PM stevens (at) stevens (dot) it Comment #1
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ Whups
Summary ⇒ Missing argument 7 for Whups_Driver::mail()
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
maybe just a tweak, however PHP log reports



"PHP Warning:  Missing argument 7 for Whups_Driver::mail(), called in 
/var/www/horde-3.3/whups-h3-1.0/lib/Whups.php on line 751 and defined 
in /var/www/horde-3.3/whups-h3-1.0/lib/Driver.php on line 335"



lib/Whups.php:751

  $whups_driver->mail(null, $user, $subject, $email, $user, true);



it could be ok to put a default for "$queue_id" in Whups_Driver::mail(); e.g.



function mail($ticket_id, $recipients, $subject, $message, $from,

                   $reminder, $queue_id = null, $is_new = false)



later in the function, we can check the "$queue_id" value instead of 
using it directly; e.g.:



         if (!is_null($queue_id)) {

             $queue = $this->getQueue($queue_id);

         } else {

             ...


Saved Queries