Tickets :: [#7641] Changes of subject field of whups notification emails

6.0.0-beta1

7/7/25

Summary	Changes of subject field of whups notification emails
Queue	IMP
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	a-dinc (at) hotmail (dot) de
Created	11/05/2008 (6088 days ago)
Due
Updated	11/05/2008 (6088 days ago)
Assigned
Resolved	11/05/2008 (6088 days ago)
Milestone
Patch	No

11/05/2008 10:12:13 PM	Michael Slusarz	Comment #9 State ⇒ Resolved	Reply to this comment
No longer strip blob information from subject. But RFC 5256 is still, for lack of any other standard, the best practice for reply/forward subject naming so continue to follow its rules other than blobs (most important, this means no i18n 're' or 'fwd' prefixes).

11/05/2008 10:09:50 PM	CVS Commit	Comment #8	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/lib/Compose.php?r1=1.400&r2=1.401&ty=u

11/05/2008 10:09:13 PM	CVS Commit	Comment #7	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Imap_Client/lib/Horde/Imap/Client.php?r1=1.44&r2=1.45&ty=u

11/05/2008 05:39:26 PM	Jan Schneider	Comment #6	Reply to this comment
This subject cleaning uses the "base subject" algorithm defined in RFC 5256 [2.1]: http://tools.ietf.org/html/rfc5256 This is overshooting the goal IMO. I think we agree that subject threading is not really one of the best ideas in history, so taking one algorithm out of it to claim it being a standard for something completely different (replying/forwarding) doesn't make much sense to me. The algorithm has it's merits though, so I suggest leaving out the subj-blob stripping.

11/05/2008 05:26:38 PM	a-dinc (at) hotmail (dot) de	Comment #5	Reply to this comment
You didn't say this in your original e-mail. Your original e-mail said IMP does not display anything between brackets. That is not true. i'm sorry if there was a missunderstanding. here is an example: Subject: [Tickets ~~#20~~] Re: Re: iptables ^^^^^^^^^^^^^^^^^^^^^^^^^^ original mail-subject when mail is viewed changes to: Subject: Re: iptables ^^^^^^^^^^^the subject-field when replied to the mail It is true that we do strip information in brackets from the subject header when replying/forwarding, when appropriate. http://cvs.horde.org/diff.php/imp/lib/Compose.php?r1=1.392&r2=1.393 This subject cleaning uses the "base subject" algorithm defined in RFC 5256 [2.1]: http://tools.ietf.org/html/rfc5256 [Show Quoted Text - 11 lines][Hide Quoted Text] I believe it is appropriate to strip this information out. obviously, any algorithm that attempts to "clean" a subject line has the chance of potentially removing desired information. But this particular algorithm has been discussed for many years and the logic behind it is sound. Most important, stripping this information does not affect in any way subsequent threading/subject sorting done on this message. If whups is sending out e-mails with ticket information in brackets, we should probably change that. So this is probably a whups issue rather than an IMP issue. maybe an other indication of that particular ticket would help sorting tickets. particularly when whups is used with emails updates.

11/05/2008 04:54:56 PM	Michael Slusarz	Comment #4	Reply to this comment
when i look into the source of the mail i can see [Tickets #xx] and when i reply to this in IMP then this disappears. maybe this has something todo with the localizations since in other languages where [Tickets #xx] appears in the locale language is also removed when replied. You didn't say this in your original e-mail. Your original e-mail said IMP does not display anything between brackets. That is not true. It is true that we do strip information in brackets from the subject header when replying/forwarding, when appropriate. http://cvs.horde.org/diff.php/imp/lib/Compose.php?r1=1.392&r2=1.393 This subject cleaning uses the "base subject" algorithm defined in RFC 5256 [2.1]: http://tools.ietf.org/html/rfc5256 I believe it is appropriate to strip this information out. obviously, any algorithm that attempts to "clean" a subject line has the chance of potentially removing desired information. But this particular algorithm has been discussed for many years and the logic behind it is sound. Most important, stripping this information does not affect in any way subsequent threading/subject sorting done on this message. If whups is sending out e-mails with ticket information in brackets, we should probably change that. So this is probably a whups issue rather than an IMP issue.

11/05/2008 04:43:47 PM	a-dinc (at) hotmail (dot) de	Comment #3	Reply to this comment
when i look into the source of the mail i can see [Tickets #xx] and when i reply to this in IMP then this disappears. maybe this has something todo with the localizations since in other languages where [Tickets #xx] appears in the locale language is also removed when replied.

11/05/2008 04:39:49 PM	Chuck Hagenbuch	Comment #2 State ⇒ Feedback	Reply to this comment
Why do you think IMP does this?

11/05/2008 04:15:36 PM	a-dinc (at) hotmail (dot) de	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Changes of subject field of whups notification emails Queue ⇒ IMP Milestone ⇒ Patch ⇒ No State ⇒ New	Reply to this comment
IMP removes the "[Tickets #xx]" string from the subject of whups send notifications emails. Wouldn't it be better to leave this, since if you reply to this mail in order to make updates to this whups ticket via email whups could queue this into the correct ticket and make it a comment to this ticket.