Tickets :: [#7548] Share is null check

6.0.0-alpha12

6/15/25

Summary	Share is null check
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Enhancement
State	No Feedback
Priority	1. Low
Owners	duck (at) obala (dot) net
Requester	duck (at) obala (dot) net
Created	10/23/2008 (6079 days ago)
Due
Updated	04/22/2014 (4072 days ago)
Assigned	11/06/2008 (6065 days ago)
Resolved	10/01/2009 (5736 days ago)
Milestone
Patch	Yes

10/01/2009 10:07:34 PM	Jan Schneider	State ⇒ No Feedback

08/18/2009 10:36:32 PM	Jan Schneider	State ⇒ Feedback

11/06/2008 02:33:31 AM	Chuck Hagenbuch	Comment #4 State ⇒ Assigned Taken from Michael Rubinsky Assigned to Duck	Reply to this comment
Duck, unless the DB driver sets that flag automatically, we need to check something else to see which query to run. Also, even if that flag is set, won't that just modify the result of the select, and not the actual comparison on the server itself?

10/31/2008 09:39:29 AM	Duck	Comment #3	Reply to this comment
The main problem, here is that we force the db to do two operations. Additional, even checking only for null values, we do an full table scan, as NULL are actually not a value and the db will not use index.

10/24/2008 04:50:07 PM	Michael Rubinsky	Comment #2 State ⇒ Feedback	Reply to this comment
We actually don't set the MDB2_PORTABILITY_EMPTY_TO_NULL portability flag. This is intentional, I don't remember the details at the moment, but setting it caused all types of problems with existing queries elsewhere...hence the check for both '' and NULL.

10/23/2008 09:20:38 PM	Jan Schneider	Assigned to Michael Rubinsky State ⇒ Assigned

10/23/2008 07:24:32 PM	Duck	Comment #1 Priority ⇒ 1. Low State ⇒ New New Attachment: null.diff Patch ⇒ Yes Milestone ⇒ Queue ⇒ Horde Framework Packages Summary ⇒ Share is null check Type ⇒ Enhancement	Reply to this comment
In revision 1.7 of sql_hierarchical.php the share selection query was modified to check both empty strings and null values for portability reasons. But we can check DB connection options to see, if we convert empty strings to null values or not. The patch looks the MDB2_PORTABILITY_EMPTY_TO_NULL options and adds the correct comparation.