| Summary | Wrong logic for showing action bar |
| Queue | IMP |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | slusarz (at) horde (dot) org |
| Requester | jan (at) horde (dot) org |
| Created | 10/06/2008 (6117 days ago) |
| Due | |
| Updated | 01/14/2011 (5287 days ago) |
| Assigned | 01/12/2011 (5289 days ago) |
| Resolved | 01/14/2011 (5287 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
State ⇒ Resolved
describes. Re-closing.
State ⇒ Feedback
/* If there are 20 messages or less, don't show the actions/navbar again. */
So if max_msgs is 20, the action bar *shouldn't* be shown. It should
only be shown with 21+ messages.
And this is exactly what is desired - the default, out of the box
preference setting should not display the action bar at the bottom of
the screen (it is unnecessary clutter on the screen and is only useful
once the mailbox list begins to scroll).
State ⇒ Assigned
Version ⇒ Git master
Patch ⇒ Yes
to the default of 20, then $pageOb->end - $pageOb->begin will be 19
most of the time (for mailboxes with >= 20 messages. So ($pageOb->end
- $pageOb->begin) >= 20 will be false most of the time and then bottom
navbar won't be shown.
I think we instead want to compare the total message count in the
mailbox to the max_msgs, and show the 2nd navbar if msgcount > max_msgs.
See attached patch.
Taken from
Assigned to Michael Slusarz
State ⇒ Resolved
http://cvs.horde.org/diff.php/imp/mailbox.php?r1=2.617.4.86&r2=2.617.4.87&ty=u
http://cvs.horde.org/diff.php/imp/mailbox.php?r1=2.873&r2=2.874&ty=u
Priority ⇒ 1. Low
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to
Queue ⇒ IMP
Summary ⇒ Wrong logic for showing action bar
Type ⇒ Bug
on the total number of messages in the mailbox, not on the number of
messages on the screen.