6.0.0-alpha12
6/8/25

[#7415] Better display of HTML and Atom content in feed block
Summary Better display of HTML and Atom content in feed block
Queue Horde Base
Queue Version Git master
Type Enhancement
State Resolved
Priority 1. Low
Owners chuck (at) horde (dot) org
Requester rsalmon (at) mbpgroup (dot) com
Created 09/30/2008 (6095 days ago)
Due
Updated 04/14/2011 (5169 days ago)
Assigned 09/30/2008 (6095 days ago)
Resolved 03/27/2011 (5187 days ago)
Milestone
Patch No

History
04/14/2011 07:59:18 AM rsalmon (at) mbpgroup (dot) com Comment #15
New Attachment: Block_Feed.patch Download
Reply to this comment
attached is a patch for a better rendering.

see feed http://rss.news.yahoo.com/rss/europe

Chuck, this patch is an alternative until you start refactoring 
completely the feed block feature (comment #6 and #7).


03/28/2011 07:33:41 AM rsalmon (at) mbpgroup (dot) com Comment #14 Reply to this comment
Sounds like this is all set now since you said it looks okay.
Sorry, I spoke too fast.

Rendering now looks better, but still looks completely different than 
expected.

Here is an other feed example: http://rss.lemonde.fr/c/205/f/3050/index.rss

03/27/2011 12:15:51 AM Chuck Hagenbuch Comment #13
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Reply to this comment
Sounds like this is all set now since you said it looks okay.
03/27/2011 12:14:37 AM Git Commit Comment #12 Reply to this comment
Changes have been made in Git for this ticket:

Bug #7415: setRawPostData is deprecated, use setBody instead

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/194d8faa1642fbebac715a0532b6caa0e3dccdc1
03/27/2011 12:13:48 AM Chuck Hagenbuch Comment #11 Reply to this comment
setBody is there on HttpRequest; it's just not documented on php.net. 
I checked back to pecl_http 1.6.0 (from 2007) and setRawPostData was 
aliased to setBody as of then.
03/23/2011 09:51:14 AM Jan Schneider Comment #10
Version ⇒ Git master
Reply to this comment
setBody() is a method of HttpMessage, not HttpRequest and AFAICS you 
can only get a HttpMessage from sent requests, i.e. you cannot *send* 
a HttpMessage object.
03/23/2011 09:09:32 AM rsalmon (at) mbpgroup (dot) com Comment #9 Reply to this comment
reĀ·viving this issue :-)

Using horde-git, feed http://travaux.ovh.net/rss.php now looks Ok.

however, I get the following errors in horde.log :

2011-03-23T09:53:13+01:00 DEBUG: HORDE [horde] PHP ERROR: Function 
HttpRequest::setRawPostData() is deprecated [pid 28498 on line 63 of 
"/var/www/html/hordetest/libs/Horde/Http/Request/Peclhttp.php"]
2011-03-23T09:53:13+01:00 DEBUG:  1. 
Horde_Core_Block_Layout_View->toHtml() 
/var/www/html/hordetest/services/portal/index.php:43
  2. Horde_Core_Block->getContent() 
/var/www/html/hordetest/libs/Horde/Core/Block/Layout/View.php:96
  3. Horde_Core_Block->_call() 
/var/www/html/hordetest/libs/Horde/Core/Block.php:164
  4. Horde_Block_Feed->_content() 
/var/www/html/hordetest/libs/Horde/Core/Block.php:234
  5. Horde_Block_Feed->_read() /var/www/html/hordetest/lib/Block/Feed.php:63
  6. Horde_Feed::readUri() /var/www/html/hordetest/lib/Block/Feed.php:109
  7. Horde_Http_Client->get() /var/www/html/hordetest/libs/Horde/Feed.php:108
  8. Horde_Http_Client->request() 
/var/www/html/hordetest/libs/Horde/Http/Client.php:96
  9. Horde_Http_Request_Peclhttp->send() 
/var/www/html/hordetest/libs/Horde/Http/Client.php:184
10. HttpRequest->setRawPostData() 
/var/www/html/hordetest/libs/Horde/Http/Request/Peclhttp.php:63
11. Horde::errorHandler()

2011-03-23T09:53:13+01:00 DEBUG: HORDE [horde] PHP ERROR: Function 
HttpRequest::setRawPostData() is deprecated [pid 28498 on line 63 of 
"/var/www/html/hordetest/libs/Horde/Http/Request/Peclhttp.php"]
2011-03-23T09:53:13+01:00 DEBUG:  1. 
Horde_Core_Block_Layout_View->toHtml() 
/var/www/html/hordetest/services/portal/index.php:43
  2. Horde_Core_Block->getTitle() 
/var/www/html/hordetest/libs/Horde/Core/Block/Layout/View.php:97
  3. Horde_Core_Block->_call() 
/var/www/html/hordetest/libs/Horde/Core/Block.php:140
  4. Horde_Block_Feed->_title() 
/var/www/html/hordetest/libs/Horde/Core/Block.php:234
  5. Horde_Block_Feed->_read() /var/www/html/hordetest/lib/Block/Feed.php:52
  6. Horde_Feed::readUri() /var/www/html/hordetest/lib/Block/Feed.php:109
  7. Horde_Http_Client->get() /var/www/html/hordetest/libs/Horde/Feed.php:108
  8. Horde_Http_Client->request() 
/var/www/html/hordetest/libs/Horde/Http/Client.php:96
  9. Horde_Http_Request_Peclhttp->send() 
/var/www/html/hordetest/libs/Horde/Http/Client.php:184
10. HttpRequest->setRawPostData() 
/var/www/html/hordetest/libs/Horde/Http/Request/Peclhttp.php:63
11. Horde::errorHandler()

$data is NULL. I replaced call to setRawPostData by setBody (as 
suggested by user comment 
http://php.net/manual/en/function.httprequest-setrawpostdata.php) and 
I don't get the error anymore.


10/06/2008 11:57:37 AM rsalmon (at) mbpgroup (dot) com Comment #8 Reply to this comment
Is it possible to open links (feed's titles) into new windows ?

eg : target="_blank"


10/03/2008 11:15:19 PM Chuck Hagenbuch Comment #7
Summary ⇒ Better display of HTML and Atom content in feed block
Reply to this comment
Right now we strip all tags, and only look for the entry description. 
We should look for atom summary (or full content) as well, and have 
support for displaying (filtered) HTML.
10/03/2008 11:14:11 PM Chuck Hagenbuch Comment #6
Priority ⇒ 1. Low
Type ⇒ Enhancement
Queue ⇒ Horde Base
Version ⇒ HEAD
State ⇒ Accepted
Reply to this comment
This is really a feature request for the feed block. Recategorizing as such.
10/02/2008 07:04:33 AM rsalmon (at) mbpgroup (dot) com Comment #5 Reply to this comment
Okay. And again: did it used to work? Or has it always been this way?
Sorry, I'm using the feed block only recently (since ticket 7291) as I 
couldn't get the feed block working. But since then, it always has 
been working this way.
10/01/2008 08:03:02 PM Chuck Hagenbuch Comment #4 Reply to this comment
Okay. And again: did it used to work? Or has it always been this way?
10/01/2008 07:31:50 AM rsalmon (at) mbpgroup (dot) com Comment #3 Reply to this comment
Is this something that used to work, and just changed? And what
calling code are you using? Or is this with the feed block in the
Horde portal?
this is with the feed block in the Horde portal. I haven't changed 
anything in the source code. I've just added a feed through "Add 
Content" in  the horde portal.



Instead of leaving the original tags, the feed block probably should 
convert line breaks into BR tags?


09/30/2008 09:33:01 PM Chuck Hagenbuch Comment #2
State ⇒ Feedback
Reply to this comment
Is this something that used to work, and just changed? And what 
calling code are you using? Or is this with the feed block in the 
Horde portal?
09/30/2008 11:16:03 AM rsalmon (at) mbpgroup (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Feed : line breaks
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
using latest cvs, feed convert tags "<br/>" into something like "\r\n" 
which isn't render in firefox (or some other brother).



eg : http://travaux.ovh.net/rss.php

Can Feed leave the BR tags ?


Saved Queries