Changes have been made in Git for this ticket:

Request #7353 - Add imp_hook_display_folder() hook.

http://git.horde.org/diff.php/imp/config/conf.xml?rt=horde-git&r1=a4ed4fed7077dd59461aae053923453278f3347c&r2=96801eeee12ba3e22bf970be32f1733faa17f635
http://git.horde.org/diff.php/imp/config/hooks.php.dist?rt=horde-git&r1=08137096bf5e05ab323d44662b2b322b3f739aca&r2=96801eeee12ba3e22bf970be32f1733faa17f635
http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=29d05715d9b9f696cfe0e56cec8f9877a4d1235e&r2=96801eeee12ba3e22bf970be32f1733faa17f635
http://git.horde.org/diff.php/imp/js/src/DimpBase.js?rt=horde-git&r1=af0f675507180ff5b4809a70721e0b08ec7ec54e&r2=96801eeee12ba3e22bf970be32f1733faa17f635
http://git.horde.org/diff.php/imp/lib/IMAP/Tree.php?rt=horde-git&r1=80cf8cf4ae81d2462a02cbdc8558ea569b33c5db&r2=96801eeee12ba3e22bf970be32f1733faa17f635

It does.  The drop-down folder lists are generated through a call to 
IMP_IMAP_Tree->folderList(), which uses the IMP_IMAP_Tree iteration 
functions to walk through the tree.

with some former version of the hook i realized that still all 
groupware folders are shown in the move-mail-to-folder dropdown-menu. 
i might be mistaken but i think your latest check-in does not cover 
this, does it?

Slighty tweaked and added to IMP 4.3.4 and IMP 5 (there was some 
references to 'h-prefs' in the Kolab hooks code that did not appear to 
be related to the display_folders stuff).

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/imp/config/conf.xml?rt=horde&r1=1.53.2.39&r2=1.53.2.40&ty=u
http://cvs.horde.org/diff.php/imp/config/hooks.php.dist?rt=horde&r1=1.3.2.5&r2=1.3.2.6&ty=u
http://cvs.horde.org/diff.php/imp/docs/CHANGES?rt=horde&r1=1.699.2.378&r2=1.699.2.379&ty=u
http://cvs.horde.org/diff.php/imp/lib/IMAP/Tree.php?rt=horde&r1=1.25.2.67&r2=1.25.2.68&ty=u

Michael, please ack or commit.

Here you go.



Both patches do contain a minor fix for the display of preferences 
folders. The folder type changed from 'prefs' to 'h-prefs' there. Hope 
its okay to include it there.

Looks good from a glance, but we would also need a patch version for 
IMP 5 to not lose that functionality in the future.

the hook patch also left a problem behind. the select menu that lets 
you move a message to a different folder still showed all folders 
(contacts, calendars, etc.). with my former approach mail messages 
could only be moved to real mail folders (as opposed to groupware 
folders).



best and happy new year,

mike

When I looked at the same functionality within DIMP I realised that 
the patch only fixes the situation for IMP. After digging somewhat 
deeper it became obvious that the approach in the last patch would not 
be efficient.



I try the same thing using a new attribute for an element now. I'm not 
100% certain that it is okay to do it that way but I'm certain it 
makes more sense to determine the visibility of the elements when 
actually building the tree.

Thanks for the patch and sorry for the delay. Looks fine to me. 
Assigning to Jan or Chuck for a final check and commiting (contains 
modifications within "/horde")

i have tested the display_folder.patch, works fine with current 
CVS/GIT on my site.

PING from me, as well.

Ping?

See the attached patch.



I hope it conforms to horde guidelines.

A hook sounds right to me.

The same wish has been submitted downstream.



https://www.intevation.de/roundup/kolab/issue2738



Concerning the submitted patch:



I don't think we will have Kolab specific code in Tree.php. I'd assume 
something like folder visibility should be solved using a hook 
function. Comparable to the functions that handle the folder icons. 
But this is something for Chuck or Jan to decide.



In addition the feature should not be a configuration but a users preference.

Thanks for fixing. Also you check for "shared.", it might be better to 
check for "shared" only. The hierarchy separator might as well be "/" 
or something else.

This is something I guess the IMP devs will be able to answer best.

you are right, i did not have sharing of user mail folders on my site. 
mail folders of other users with permissions granted for me to see 
were not shown. now they are.



TODO:

i have user A, B and C. i am user A, user B shows me his abook, user C 
shows me his INBOX.

the imp tree will show me (in german now):



Ordner andere Benutzer

   + user B

   + user C

        INBOX



user B must not necessarily be listed here, but i do not know where 
have to filter him out. trying "user/" instead of "user" in the 
attached patched results in no other user folders at all...

Thanks for the patch! Just by looking at it, I see you handle the 
"INBOX" and "shared." prefix. What about "user."?

here is a patch that allows to hide kolab groupware folders in IMP, 
configurable through horde's conf.php...



hope gunnar et al. like it...