[#7353] a hide groupware folder patch
Summary a hide groupware folder patch
Queue IMP
Queue Version HEAD
Type Enhancement
State Resolved
Priority 1. Low
Owners Michael Slusarz <slusarz (at) horde (dot) org>
Requester m (dot) gabriel (at) das-netzwerkteam (dot) de
Created 09/18/2008 (289 days ago)
Due
Updated 02/06/2009 (148 days ago)
Assigned 01/24/2009 (161 days ago)
Resolved 02/06/2009 (148 days ago)
Attachments HK-MP-Hide_groupware_folders.patch Download
HK-MP-Hide_groupware_folders_imp5.patch Download
Milestone
Patch No

History
02/06/2009 Michael Slusarz Comment #20
State ⇒ Resolved
Reply to this comment
with some former version of the hook i realized that still all 
groupware folders are shown in the move-mail-to-folder 
dropdown-menu. i might be mistaken but i think your latest check-in 
does not cover this, does it?
It does.  The drop-down folder lists are generated through a call to 
IMP_IMAP_Tree->folderList(), which uses the IMP_IMAP_Tree iteration 
functions to walk through the tree.

02/06/2009 Jan Schneider State ⇒ Feedback
 
02/06/2009 m (dot) gabriel (at) das-netzwerkteam (dot) de Comment #19 Reply to this comment
with some former version of the hook i realized that still all 
groupware folders are shown in the move-mail-to-folder dropdown-menu. 
i might be mistaken but i think your latest check-in does not cover 
this, does it?


02/05/2009 Michael Slusarz Comment #18
State ⇒ Resolved
Reply to this comment
Slighty tweaked and added to IMP 4.3.4 and IMP 5 (there was some 
references to 'h-prefs' in the Kolab hooks code that did not appear to 
be related to the display_folders stuff).
02/05/2009 CVS Commit Comment #17 Reply to this comment
01/24/2009 Chuck Hagenbuch State ⇒ Assigned
 
01/09/2009 Jan Schneider Comment #16
Taken from Chuck Hagenbuch
Taken from Jan Schneider
Taken from Gunnar Wrobel
Assigned to Michael Slusarz
Reply to this comment
Michael, please ack or commit.
01/09/2009 Jan Schneider Version ⇒ HEAD
Queue ⇒ IMP
 
01/09/2009 Jan Schneider Deleted Attachment: display_folder.patch
 
01/09/2009 Gunnar Wrobel Comment #15
New Attachment: HK-MP-Hide_groupware_folders_imp5.patch Download
Reply to this comment
Here you go.

Both patches do contain a minor fix for the display of preferences 
folders. The folder type changed from 'prefs' to 'h-prefs' there. Hope 
its okay to include it there.
01/09/2009 Jan Schneider Comment #14
State ⇒ Feedback
Reply to this comment
Looks good from a glance, but we would also need a patch version for 
IMP 5 to not lose that functionality in the future.
01/08/2009 m (dot) gabriel (at) das-netzwerkteam (dot) de Comment #13 Reply to this comment
the hook patch also left a problem behind. the select menu that lets 
you move a message to a different folder still showed all folders 
(contacts, calendars, etc.). with my former approach mail messages 
could only be moved to real mail folders (as opposed to groupware 
folders).

best and happy new year,
mike
01/08/2009 Gunnar Wrobel Assigned to Gunnar Wrobel
 
01/08/2009 Gunnar Wrobel Comment #12
New Attachment: HK-MP-Hide_groupware_folders.patch Download
Reply to this comment
When I looked at the same functionality within DIMP I realised that 
the patch only fixes the situation for IMP. After digging somewhat 
deeper it became obvious that the approach in the last patch would not 
be efficient.

I try the same thing using a new attribute for an element now. I'm not 
100% certain that it is okay to do it that way but I'm certain it 
makes more sense to determine the visibility of the elements when 
actually building the tree.
12/29/2008 Chuck Hagenbuch Deleted Attachment: imp_hidegroupwarefolders.patch
 
12/29/2008 Gunnar Wrobel Comment #11
Taken from Gunnar Wrobel
Taken from Thomas Jarosch
Assigned to Jan Schneider
Assigned to Chuck Hagenbuch
Reply to this comment
Thanks for the patch and sorry for the delay. Looks fine to me. 
Assigning to Jan or Chuck for a final check and commiting (contains 
modifications within "/horde")
12/23/2008 m (dot) gabriel (at) das-netzwerkteam (dot) de Comment #10 Reply to this comment
i have tested the display_folder.patch, works fine with current 
CVS/GIT on my site.
12/23/2008 m (dot) gabriel (at) das-netzwerkteam (dot) de Comment #9 Reply to this comment
PING from me, as well.
12/20/2008 math (dot) parent (at) gmail (dot) com Comment #8 Reply to this comment
Ping?
11/21/2008 math (dot) parent (at) gmail (dot) com Comment #7
New Attachment: display_folder.patch
Reply to this comment
See the attached patch.

I hope it conforms to horde guidelines.
11/14/2008 Chuck Hagenbuch Comment #6
Patch ⇒
Taken from Chuck Hagenbuch
Taken from Jan Schneider
Reply to this comment
A hook sounds right to me.
11/14/2008 Gunnar Wrobel Comment #5
Assigned to Jan Schneider
Assigned to Chuck Hagenbuch
Reply to this comment
The same wish has been submitted downstream.

https://www.intevation.de/roundup/kolab/issue2738

Concerning the submitted patch:

I don't think we will have Kolab specific code in Tree.php. I'd assume 
something like folder visibility should be solved using a hook 
function. Comparable to the functions that handle the folder icons. 
But this is something for Chuck or Jan to decide.

In addition the feature should not be a configuration but a users preference.
11/11/2008 Thomas Jarosch Deleted Attachment: imp_hidegroupwarefolder.patch
 
11/11/2008 Thomas Jarosch Comment #4 Reply to this comment
"INBOX" and "shared." prefix. What about "user."?
you are right, i did not have sharing of user mail folders on my 
site. mail folders of other users with permissions granted for me to 
see were not shown. now they are.
Thanks for fixing. Also you check for "shared.", it might be better to 
check for "shared" only. The hierarchy separator might as well be "/" 
or something else.

[Hide Quoted Text]
TODO:
i have user A, B and C. i am user A, user B shows me his abook, user 
C shows me his INBOX.
the imp tree will show me (in german now):

Ordner andere Benutzer
   + user B
   + user C
        INBOX

user B must not necessarily be listed here, but i do not know where 
have to filter him out. trying "user/" instead of "user" in the 
attached patched results in no other user folders at all...
This is something I guess the IMP devs will be able to answer best.

11/06/2008 m (dot) gabriel (at) das-netzwerkteam (dot) de Comment #3
New Attachment: imp_hidegroupwarefolders.patch
Reply to this comment
Thanks for the patch! Just by looking at it, I see you handle the 
"INBOX" and "shared." prefix. What about "user."?
you are right, i did not have sharing of user mail folders on my site. 
mail folders of other users with permissions granted for me to see 
were not shown. now they are.

TODO:
i have user A, B and C. i am user A, user B shows me his abook, user C 
shows me his INBOX.
the imp tree will show me (in german now):

Ordner andere Benutzer
   + user B
   + user C
        INBOX

user B must not necessarily be listed here, but i do not know where 
have to filter him out. trying "user/" instead of "user" in the 
attached patched results in no other user folders at all...

11/06/2008 thomas (dot) jarosch (at) intra2net (dot) com Comment #2 Reply to this comment
Thanks for the patch! Just by looking at it, I see you handle the 
"INBOX" and "shared." prefix. What about "user."?

11/05/2008 Chuck Hagenbuch Assigned to Thomas Jarosch
 
11/05/2008 Chuck Hagenbuch Assigned to Gunnar Wrobel
State ⇒ Assigned
 
09/18/2008 m (dot) gabriel (at) das-netzwerkteam (dot) de Comment #1
New Attachment: imp_hidegroupwarefolder.patch
Milestone ⇒
Summary ⇒ a hide groupware folder patch
Patch ⇒ 1
Type ⇒ Enhancement
Priority ⇒ 1. Low
State ⇒ New
Queue ⇒ Kolab
Reply to this comment
here is a patch that allows to hide kolab groupware folders in IMP, 
configurable through horde's conf.php...

hope gunnar et al. like it...