Changes have been made in Git for this ticket:

Bug #7296: Convert old IMP 4 sortby pref values

http://git.horde.org/diff.php/imp/lib/IMP.php?rt=horde-git&r1=8118249de11e52b66910f50629bcf9d13c0131e2&r2=e68135ff0f697b0a22e93fa23b3239d0dbc5eb54

Changes have been made in Git for this ticket:

Ticket #7296: Don't show thread graphics when in subject sort

http://git.horde.org/diff.php/imp/js/src/DimpBase.js?rt=horde-git&r1=e99c124032b9cba7354d843a67e5567bf94833cc&r2=7b83a6940f023cd40760c1b9e9945b34a1ec2a6c

The old IMP conversion scripts used to loop through a list of 
usernames to switch the pref backend as necessary.  And if you (as an 
admin) can not access the pref backends of any user, your system 
probably isn't setup very well.  I can't even begin to imagine how you 
can be expected to manage a pref backend without full admin access...



Regardless, this conversion is done at run-time in the instant case, 
so further discussion within the context of this ticket is irrelevant.

IMO, when data needs to be massaged in a preference backend, it should 
be done as a mainenance task since not all preference backends can be 
accessed without an explicit user login. Unless I'm missing something...

I disagree.  Maintenance tasks are OK for minor point releases.  But 
for transitioning between major releases, this needs to be part of 
admin-performed upgrade instructions.
This turns out to be a better place to check for this.  Although it 
adds a bit of overhead everytime the sortby pref is accessed, it is 
probably good to always make sure this value is valid anyway.

That would usually done by a maintenance task like the one-time task in Turba.



At least it should fall back to some default sorting order if the 
stored value isn't correct.

If your default sortorder is stored as integer value 161 in the 
preferences, that needs to be fixed in your pref backend.  Probably 
would be useful to have a conversion script for this kind of thing.

That's my default sorting order from the preferences. I got that 
result from hitting one of the columns in the empty virtual folder.

I don't see this either.  Sorting via Date or sequence number, no 
matter the direction pref, works fine for me.

How did you get sortby:161 (that's the old value for thread sort in 
IMP 4.  That constant is not used in IMP 5 and, regardless, threading 
is not available for search results).



I can confirm that thread sort is not available in DIMP when viewing 
Virtual Folders.

This the response that I get from the ViewPort action, that doesn't 
let the sort column header stay highlighted in empty virtual folders:

{"response":{"ViewPort":{"view":"**search_136392034149d47fa4c3c3b","totalrows":0,"label":"IMP5"

,"cacheid":"124038911327975780","metadata":{"nothread":1,"sortby":161,"sortdir":1,"search":1},"rowlist"

:[],"data":[],"update":1,"request_id":3}}}

I see some other sorting weirdness now, in the IMP interface. If 
sorting in reverse order, the mailbox pages are correctly sorted, but 
inside a single mailbox page, the sorting is in the wrong order.

For example I have:

page 1: March to April

page 2: January to February

while it should be:

page 1: April to March

page 2: February to March

No.  Somewhere during the ViewPort rewrite the sortby check was lost.   
This has been fixed.

I don't see this at all.  Clicking on any sorting column is sticky for me.

Scratch that. I was confused because sorting by subject is threaded 
too now. The difference to regular thread sorting is, that the base 
messages are sorted alphabetically instead of chronologically. Is that 
intended?

No. When I click on the column header, it is shortly highlighted, the 
mailbox reloaded, but when the reload finishes (quickly, because the 
mailbox is empty), it's back to no headers being highlighted.

On a related issue: the highlighting of subject vs. thread is swapped.

With my latest changes to ViewPort code, I don't see this anymore.  Confirmed?

Ah right, I missed this was originally about DIMP.



It's even worse now. Changing the sort order in an empty folder still 
only reloads the mailbox without actually changing the order. If 
changing the sort order in a folder with messages, DIMP is constantly 
sending ListMessage requests now. This is a typical exchange:



cached        {22}INBOX.sent.sent-Privat1

cacheid        1238600802|3|2|8|0

request_id        1

rownum        1

slice        2:71

view        INBOX.sent.sent-Privat



/*-secure-{"response":{"viewport":{"id":"INBOX.sent.sent-Privat","reset":0,"totalrows":2,"label":"sent

.sent-Privat","cacheid":"1238600802|3|2|8|0","metadata":{"sortby":8,"sortdir":0,"special":1,"unseen"

:0},"rowlist":{"1":2},"data":[],"request_id":"1"}}}*/

I don't see this - the mailbox header is always shown in dimp.  Are 
you talking about IMP or DIMP (this is a dimp ticket).

There is actually no way to change the sort order on empty folders 
anymore, since the mailbox header is only displayed if there are 
messages in the folder. Thus this problem is moot now.

You are going to have to recreate Virtual Folders for IMP 5.  I 
haven't written an upgrade script because 1.) there is no guarantee I 
won't change the internal search format 5 times before IMP 5 is 
released, and 2.) with the whole protected/private object model in PHP 
5, it may no longer be possible to upgrade object structures  without 
mucking around with __get and __set commands, which IMHO is hackish 
and completely destroys the concept of private variables.

I can't load empty virtual folders at all atm. This is what I get when 
accessing a virtual folder from the sidebar:



( ! ) Fatal error: Horde_Imap_Client_Base::search() 
[horde-imap-client-base.search]: The script tried to execute a method 
or access a property of an incomplete object. Please ensure that the 
class definition "imp_imap_search_query" of the object you are trying 
to operate on was loaded _before_ unserialize() gets called or provide 
a __autoload() function to load the class definition in 
/home/jan/horde-git/framework/Imap_Client/lib/Horde/Imap/Client/Base.php on 
line 1315

Call Stack

#        Time        Memory        Function        Location

1        0,0059        460376        {main}( )        ../mailbox.php:0

2        1,8616        13232148        IMP_Mailbox->buildMailboxPage( NULL, NULL, ??? 
)        ../mailbox.php:258

3        1,8616        13232148        IMP_Mailbox->_buildMailbox( )        ../Mailbox.php:434

4        1,8660        13308340        IMP_Search->runSearch( NULL, 
'**search_nwnm9pgtv9c0w0g8c0' )        ../Mailbox.php:256

5        1,8704        13311560        Horde_Imap_Client_Base->search( 
'INBOX.Mailinglisten.Bugtraq', class __PHP_Incomplete_Class { public 
$__PHP_Incomplete_Class_Name = 'imp_imap_search_query'; public $_and = 
array (); public $_extendedSearch = array (); public $_flags = array 
(); public $_not = FALSE; public $_or = array (0 => array (0 => class 
__PHP_Incomplete_Class { ... }, 1 => class __PHP_Incomplete_Class { 
... })); public $_query = NULL; public $_size = NULL; public $_sizeop 
= NULL }, array ('reverse' => '1', 'sort' => array (0 => '0')) 
)        ../Search.php:145

This seems to work fine for me in the Git code.  Jan, can you try the 
code there?

If changing the sort order on empty (virtual) folders, the order 
doesn't stick, i.e. the mailbox is resorted (even though it's empty), 
and comes back with the old sort column header highlighted.