Tickets :: [#7251] Add an option to hide the script icon in ingo

6.0.0-alpha14

7/3/25

Summary	Add an option to hide the script icon in ingo
Queue	Ingo
Queue Version	1.2
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	yann (at) pleiades (dot) fr (dot) eu (dot) org
Created	08/28/2008 (6153 days ago)
Due
Updated	09/01/2008 (6149 days ago)
Assigned
Resolved	08/31/2008 (6150 days ago)
Milestone
Patch	No

09/01/2008 11:13:37 AM	Jan Schneider	Comment #9	Reply to this comment
Yes, of course. Fixed in CVS.

09/01/2008 11:13:19 AM	CVS Commit	Comment #8	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/ingo/lib/Ingo.php?r1=1.106&r2=1.107&ty=u

09/01/2008 10:37:51 AM	yann (at) pleiades (dot) fr (dot) eu (dot) org	Comment #7	Reply to this comment
I think there is an error in the applied patch. I thought script icon would not be displayed if the auto_update is locked and set. Right now is not displayed is only auto_update is locked and unset Shouldn't the patch rather be: @@ -395,7 +395,9 @@ class Ingo { if (in_array(INGO_STORAGE_ACTION_SPAM, $_SESSION['ingo']['script_categories'])) { $menu->add(Horde::applicationUrl('spam.php'), _("S_pam"), 'spam.png'); } - if ($_SESSION['ingo']['script_generate']) { + if ($_SESSION['ingo']['script_generate'] && + !($GLOBALS['prefs']->isLocked('auto_update') && + $GLOBALS['prefs']->getValue('auto_update'))) { $menu->add(Horde::applicationUrl('script.php'), _("_Script"), 'script.png'); } if (!empty($GLOBALS['ingo_shares']) && empty($GLOBALS['conf']['share']['no_sharing'])) {

08/31/2008 05:03:09 PM	CVS Commit	Comment #6	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/ingo/docs/CHANGES?r1=1.55.2.106&r2=1.55.2.107&ty=u http://cvs.horde.org/diff.php/ingo/lib/Ingo.php?r1=1.69.6.19&r2=1.69.6.20&ty=u

08/31/2008 05:00:52 PM	Jan Schneider	Comment #5 Assigned to Jan Schneider State ⇒ Resolved	Reply to this comment
Easy enough. Committed for Ingo 1.2.1.

08/31/2008 04:59:04 PM	CVS Commit	Comment #4	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/ingo/docs/CHANGES?r1=1.201&r2=1.202&ty=u http://cvs.horde.org/diff.php/ingo/lib/Ingo.php?r1=1.105&r2=1.106&ty=u

08/30/2008 09:44:59 AM	yann (at) pleiades (dot) fr (dot) eu (dot) org	Comment #3	Reply to this comment
We already locked and set this option, so that would indeed make sense for our setup.

08/30/2008 08:59:41 AM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
If you want to remove that icon, you have to make sure that the user preference to enable scripts automatically is set and locked. We could hide the button under that condition. Does that make sense?

08/28/2008 04:55:43 PM	yann (at) pleiades (dot) fr (dot) eu (dot) org	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Add an option to hide the script icon in ingo Queue ⇒ Ingo Milestone ⇒ Patch ⇒ No State ⇒ New	Reply to this comment
In order to not confuse our users, we would like to hide the script icon displayed in the top menu bar in ingo. Would it be possible to add an option for this ?