[#7249] "My email adresses" and "Addresses to not send responses to" fields are not checked for valid email address
Summary "My email adresses" and "Addresses to not send responses to" fields are not checked for valid email address
Queue Ingo
Queue Version 1.2
Type Enhancement
State Assigned
Priority 2. Medium
Owners Horde Developers
Requester yann (at) pleiades (dot) fr (dot) eu (dot) org
Created 08/28/2008 (1756 days ago)
Due
Updated 12/13/2010 (919 days ago)
Assigned 09/23/2008 (1730 days ago)
Resolved
Attachments horde_form_type_longemail_for_ingo_v3.patch Download
Milestone
Patch Yes

History
08/02/2009 01:33:29 PM Michael Rubinsky Comment #11 Reply to this comment
Is this ticket still slated for a FRAMEWORK_3 version or should it be 
moved to Git queue?
09/23/2008 10:27:39 AM Jan Schneider Priority ⇒ 2. Medium
 
09/23/2008 10:27:09 AM Jan Schneider Patch ⇒ Yes
State ⇒ Assigned
 
09/23/2008 10:26:55 AM Jan Schneider Deleted Attachment: horde_form_type_longemail_for_ingo_v2.patch
 
09/23/2008 10:21:01 AM yann (at) pleiades (dot) fr (dot) eu (dot) org Comment #10
New Attachment: horde_form_type_longemail_for_ingo_v3.patch Download		 Reply to this comment
My mistake, here is the good updated patch.
09/22/2008 04:59:59 PM Jan Schneider Priority ⇒ 1. Low
State ⇒ Feedback
Type ⇒ Enhancement
 
09/22/2008 04:59:37 PM Jan Schneider Comment #9
State ⇒ Feedback		 Reply to this comment
I hope I didn't delete the wrong patch accidentally, but the latest 
version does not contain the actual code for the 
Horde_Form_Type_longemail class.
09/22/2008 04:56:58 PM Jan Schneider Deleted Attachment: horde_form_type_longemail_for_ingo.patch
 
09/22/2008 04:56:46 PM Jan Schneider Deleted Attachment: horde_form_type_longemail.patch
 
09/11/2008 09:46:45 AM yann (at) pleiades (dot) fr (dot) eu (dot) org Comment #8
New Attachment: horde_form_type_longemail_for_ingo_v2.patch		 Reply to this comment
I updated the patch to fix a little mistake and also to use the new 
longemail form type also for the "Address(es) to forward to" field for 
transfert.
09/01/2008 12:28:43 PM Jan Schneider Comment #7
Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
Priority ⇒ 2. Medium
Patch ⇒ Yes		 Reply to this comment
I think that's fine.
09/01/2008 12:21:49 PM yann (at) pleiades (dot) fr (dot) eu (dot) org Comment #6
New Attachment: horde_form_type_longemail_for_ingo.patch		 Reply to this comment
Ok, I understand.



I modified my patch so the longemail type is defined only in ingo.



Note that this patch still considers an address without the domain 
part to be invalid.

Is this behavior ok ?
08/31/2008 05:00:23 PM Jan Schneider Comment #5 Reply to this comment
Any Ingo 1.x version has to be compatible to any Horde 3.x version. So 
you can't simply add a feature to Horde and use it an application like 
Ingo without breaking that backward compatibility.
08/30/2008 09:55:53 AM yann (at) pleiades (dot) fr (dot) eu (dot) org Comment #4 Reply to this comment
I didn't understand how the new type breaks comptability or how adding 
the new type in Ingo only solves the problem. Could you explain me so 
I can improve the patch ?
08/30/2008 09:01:40 AM Jan Schneider Comment #3
State ⇒ Feedback
Patch ⇒ No		 Reply to this comment
This breaks backward compatibility. Either you have to check the 
validity outside of the form validation, or you have add the new form 
field type to Ingo only.
08/28/2008 02:23:09 PM yann (at) pleiades (dot) fr (dot) eu (dot) org Comment #2
New Attachment: horde_form_type_longemail.patch		 Reply to this comment
I propose a possible solution for that bug with the attached patch.



I created a Horde_Form_Type_longemail class extended from 
Horde_Form_Type_longtext, which in addition checks the validity of the 
given emails.



What do you think about this solution ?





You will notice that the longemail type also checks if the email 
address have a @domain part, I am not sure if this should be done here.

sieve doesn't like address without domain, it complains with the 
following error:

    script errors: line 8: address 'test': parse error, unexpected $, 
expecting '@'



but that might be solved differently by adding the default domain to 
unqualified address before sending them to the sieve driver.


08/28/2008 01:59:01 PM yann (at) pleiades (dot) fr (dot) eu (dot) org Comment #1
State ⇒ Unconfirmed
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Ingo
Summary ⇒ "My email adresses" and "Addresses to not send responses to" fields are not checked for valid email address
Type ⇒ Bug
Priority ⇒ 1. Low		 Reply to this comment
When using ingo to setup a vacation message, the email adresses enter 
in the "My email adresses" and "Addresses to not send responses to" 
are not checked for validity.



This can cause a problem with the rules driver, for example sieve will 
return an error message is the email address is not rfc 822 compliant.