Summary | "My email adresses" and "Addresses to not send responses to" fields are not checked for valid email address |
Queue | Ingo |
Queue Version | Git master |
Type | Enhancement |
State | Resolved |
Priority | 2. Medium |
Owners | slusarz (at) horde (dot) org |
Requester | yann (at) pleiades (dot) fr (dot) eu (dot) org |
Created | 08/28/2008 (6167 days ago) |
Due | |
Updated | 12/17/2013 (4230 days ago) |
Assigned | 09/23/2008 (6141 days ago) |
Resolved | 11/01/2013 (4276 days ago) |
Milestone | |
Patch | Yes |
commit c3eedc5d53c1dc6d30b39d568fb9a40c388420f4
Author: Michael M Slusarz <slusarz@horde.org>
Date: Thu Oct 31 21:25:22 2013 -0600
[mms] Validate e-mail addresses ion the forward and vacation
pages (
Request #7249).ingo/docs/CHANGES | 2 +
ingo/lib/Basic/Forward.php | 8 ++++-
ingo/lib/Basic/Vacation.php | 5 ++-
ingo/lib/Form/Forward.php | 2 +-
ingo/lib/Form/Type/Longemail.php | 68
++++++++++++++++++++++++++++++++++++++
ingo/lib/Form/Vacation.php | 6 ++--
ingo/lib/Ui/VarRenderer/Ingo.php | 13 +++++++
ingo/package.xml | 11 ++++--
8 files changed, 106 insertions(+), 9 deletions(-)
http://git.horde.org/horde-git/-/commit/c3eedc5d53c1dc6d30b39d568fb9a40c388420f4
Assigned to Michael Slusarz
Taken from
State ⇒ Resolved
Version ⇒ Git master
commit c3eedc5d53c1dc6d30b39d568fb9a40c388420f4
Author: Michael M Slusarz <slusarz at horde.org>
Date: Thu Oct 31 21:25:22 2013 -0600
[mms] Validate e-mail addresses ion the forward and vacation
pages (
Request #7249).ingo/docs/CHANGES | 2 +
ingo/lib/Basic/Forward.php | 8 ++++-
ingo/lib/Basic/Vacation.php | 5 ++-
ingo/lib/Form/Forward.php | 2 +-
ingo/lib/Form/Type/Longemail.php | 68
++++++++++++++++++++++++++++++++++++++
ingo/lib/Form/Vacation.php | 6 ++--
ingo/lib/Ui/VarRenderer/Ingo.php | 13 +++++++
ingo/package.xml | 11 ++++--
8 files changed, 106 insertions(+), 9 deletions(-)
create mode 100644 ingo/lib/Form/Type/Longemail.php
http://github.com/horde/horde/commit/c3eedc5d53c1dc6d30b39d568fb9a40c388420f4
http://git.horde.org/horde-git/-/commit/c3eedc5d53c1dc6d30b39d568fb9a40c388420f4
moved to Git queue?
Patch ⇒ Yes
New Attachment: horde_form_type_longemail_for_ingo_v3.patch
Priority ⇒ 1. Low
State ⇒ Feedback
State ⇒ Feedback
version does not contain the actual code for the
Horde_Form_Type_longemail class.
New Attachment: horde_form_type_longemail_for_ingo_v2.patch
longemail form type also for the "Address(es) to forward to" field for
transfert.
Assigned to
State ⇒ Assigned
Priority ⇒ 2. Medium
Patch ⇒ Yes
New Attachment: horde_form_type_longemail_for_ingo.patch
I modified my patch so the longemail type is defined only in ingo.
Note that this patch still considers an address without the domain
part to be invalid.
Is this behavior ok ?
you can't simply add a feature to Horde and use it an application like
Ingo without breaking that backward compatibility.
the new type in Ingo only solves the problem. Could you explain me so
I can improve the patch ?
State ⇒ Feedback
Patch ⇒ No
validity outside of the form validation, or you have add the new form
field type to Ingo only.
New Attachment: horde_form_type_longemail.patch
I created a Horde_Form_Type_longemail class extended from
Horde_Form_Type_longtext, which in addition checks the validity of the
given emails.
What do you think about this solution ?
You will notice that the longemail type also checks if the email
address have a @domain part, I am not sure if this should be done here.
sieve doesn't like address without domain, it complains with the
following error:
script errors: line 8: address 'test': parse error, unexpected $,
expecting '@'
but that might be solved differently by adding the default domain to
unqualified address before sending them to the sieve driver.
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ Yes
Milestone ⇒
Summary ⇒ "My email adresses" and "Addresses to not send responses to" fields are not checked for valid email address
Type ⇒ Bug
Queue ⇒ Ingo
in the "My email adresses" and "Addresses to not send responses to"
are not checked for validity.
This can cause a problem with the rules driver, for example sieve will
return an error message is the email address is not rfc 822 compliant.