6.0.0-alpha12
6/13/25

[#7245] Strings in "multiple message view" aren't being translated
Summary Strings in "multiple message view" aren't being translated
Queue IMP
Queue Version 4.2
Type Bug
State Resolved
Priority 2. Medium
Owners jan (at) horde (dot) org
Requester agerhard (at) usp (dot) br
Created 08/27/2008 (6134 days ago)
Due
Updated 08/28/2008 (6133 days ago)
Assigned
Resolved 08/28/2008 (6133 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
08/28/2008 09:13:32 AM Jan Schneider Comment #4
Assigned to Jan Schneider
State ⇒ Resolved
Reply to this comment
It didn't pickup your changes because the templates have been cached. 
I added the gettext option as a flag to the cache id of templates in 
IMP, so that a new template is created if you set the option in 
thread.php.
08/28/2008 09:10:59 AM CVS Commit Comment #3 Reply to this comment
08/28/2008 09:09:52 AM CVS Commit Comment #2 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/imp/thread.php?r1=2.56&r2=2.57&ty=u
08/27/2008 08:03:53 PM agerhard (at) usp (dot) br Comment #1
Priority ⇒ 2. Medium
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Strings in "multiple message view" aren't being translated
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
When I select more than one message to be viewed simultaneously, the 
page displayed are not being translated as it should be. Single 
messages are translated ok.



I tried to pinpoint the bug, but no way. For example, I thought 
thread.php should have a line setting gettext:

$template->setOption('gettext', true);

I tried to put this line in various places of thread.php (as I have 
seen in other files) but the translation didn“t work.



I also think there is a typo in thread.html (From instead of From:) 
and missing <gettext>/</gettext> tags. The diff is below:



--- thread.html.orig    2008-08-27 14:46:48.000000000 -0300

+++ thread.html 2008-08-27 16:27:14.000000000 -0300

@@ -1,5 +1,5 @@

  <h1 class="header">

- <if:thread><gettext>Thread Display:</gettext><else:thread>Multiple 
Message View:</else:thread></if:thread> <tag:subject /> <tag:delete />

+ <if:thread><gettext>Thread 
Display:</gettext><else:thread><gettext>Multiple Message 
View:</gettext></else:thread></if:thread> <tag:subject /> <tag:delete />

  </h1>

  <br class="spacer" />



@@ -28,7 +28,7 @@

          <td class="item0 rightAlign"><tag:messages.link /></td>

         </tr>

         <tr>

-        <td class="item1 rightAlign" valign="top" 
nowrap="nowrap"><strong><if:messages.addr_to><gettext>To:</gettext><else:messages.addr_to><gettext>From</gettext></else:messages.addr_to></if:messages.addr_to></strong>&nbsp;</td>

+        <td class="item1 rightAlign" valign="top" 
nowrap="nowrap"><strong><if:messages.addr_to><gettext>To:</gettext><else:messages.addr_to><gettext>From:</gettext></else:messages.addr_to></if:messages.addr_to></strong>&nbsp;</td>

          <td class="item1 leftAlign" width="100%" 
colspan="2"><tag:messages.addr /></td>

         </tr>

  <if:messages.subject>



Andre Gerhard

Saved Queries