6.0.0-beta1
7/15/25

[#7196] Hitting escape in the search field doesn't clear it
Summary Hitting escape in the search field doesn't clear it
Queue IMP
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester chuck (at) horde (dot) org
Created 08/13/2008 (6180 days ago)
Due
Updated 01/12/2010 (5663 days ago)
Assigned 01/16/2009 (6024 days ago)
Resolved 01/18/2009 (6022 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
01/18/2009 03:12:18 AM Chuck Hagenbuch Comment #16
Taken from Chuck Hagenbuch
State ⇒ Resolved
Reply to this comment
Looks good - thanks!
01/16/2009 06:23:27 PM Chuck Hagenbuch Comment #14 Reply to this comment
Esc now works great. Tabbing into and then out of the field without 
typing anything doesn't close it - I think that would be better, but 
if you have a reason against that that's alright. However, continuing 
to tab through the page, I eventually get a blank search run. My steps 
for this are (FF 3.0.5/Mac): click to the left of the search box; hit 
tab - search box focused; hit tab - search box blurred; continue 
hitting tab. Eventually a blank search is run.
01/16/2009 05:36:54 AM Michael Slusarz Comment #13
State ⇒ Feedback
Reply to this comment
OK - I think I replicated what you are describing.  The problem seems 
to be in some Event handling issues.  I think I figured it out so give 
a shot:



http://cvs.horde.org/diff.php/imp/js/src/DimpBase.js?r1=8e47a01a7a1c4b49bb381f722800a7480a3bb35c&r2=e0782650ce91e46659fcb85fadbb41ab16a4986c&rt=horde-hatchery
01/16/2009 01:56:52 AM Chuck Hagenbuch Comment #12 Reply to this comment
Is Apple Mail doing search as you type?  If so, and it is hitting the
IMAP server for every search (as opposed to its local cache)
I'm 99% certain it's using the local Spotlight cache.
totally inefficient.  The whole point of allowing a user to set
search parameters before typing in DIMP is to eliminate this
inefficiency.  There is absolutely no reason to send an IMAP search
request for 'c', 'ch', 'chu', 'chuc', and/or 'chuck' in the From
header if you are searching for that information in the Subject
header.
Agreed.
- hitting escape while in the search field clears the search and
hides the search bar
That is non-intuitive for me.  I never use ESC in this manner.
Although this is less intrusive than any of the other suggestions in
this ticket, and wouldn't break anything that is already implemented
so this is a reasonable request.
I've seen this in a lot of places more recently; ESC as a kind of 
cancel-out. I'd like to see this.

[Show Quoted Text - 14 lines]
Right. The bug here is that if I tab into the search box and out, the 
mailbox listing *does* go blank. If I just click, it doesn't. I think 
that tabbing into the search box should behave the same as clicking it.
01/15/2009 07:14:03 PM Michael Slusarz Comment #11 Reply to this comment
I'm not entirely convinced of that I guess In Apple Mail, for example:
Considering I'm not a great fan of Apple Mail... take these comments 
with that grain of salt.
- the search bar doesn't appear until you've typed something in as a
search string, so you can tab in and out of the search box without
mucking with your mailbox listing or doing an empty search.
Is Apple Mail doing search as you type?  If so, and it is hitting the 
IMAP server for every search (as opposed to its local cache) that is 
totally inefficient.  The whole point of allowing a user to set search 
parameters before typing in DIMP is to eliminate this inefficiency.   
There is absolutely no reason to send an IMAP search request for 'c', 
'ch', 'chu', 'chuc', and/or 'chuck' in the From header if you are 
searching for that information in the Subject header.
- hitting escape while in the search field clears the search and
hides the search bar
That is non-intuitive for me.  I never use ESC in this manner.   
Although this is less intrusive than any of the other suggestions in 
this ticket, and wouldn't break anything that is already implemented 
so this is a reasonable request.

[Show Quoted Text - 9 lines]
This is a feature: after all, why run an empty search?  When I click 
on the search box, I don't want the mailbox listing to go blank.  I 
haven't searched for anything yet.  An empty search string is NO 
search, not an empty search.
01/08/2009 05:32:56 AM Michael Slusarz Version ⇒ HEAD
Queue ⇒ IMP
 
10/21/2008 03:48:08 PM Chuck Hagenbuch State ⇒ Assigned
 
08/18/2008 05:47:21 PM Chuck Hagenbuch Comment #10 Reply to this comment
I'm not entirely convinced of that I guess In Apple Mail, for example:



- the search bar doesn't appear until you've typed something in as a 
search string, so you can tab in and out of the search box without 
mucking with your mailbox listing or doing an empty search.



- hitting escape while in the search field clears the search and hides 
the search bar



- since it's impossible to do an empty search, empty searches don't 
result in empty mailboxes. I think if we end up with nothing in the 
search filter box, we should either not run a search, or we should 
match everything - matching nothing, especially when what I've done is 
tab in and out of the search box, is really disruptive.



Clicking the search box and then outside of it does leave the search 
bar open, but it doesn't seem to run an empty search - not sure why 
the difference from tabbing in and out.
08/18/2008 05:24:44 PM Michael Slusarz Comment #9 Reply to this comment
Does it work correctly if you hit tab (which for me focuses the
search field) and then tab again to blur the search field? That
displays similar behavior for me - seems like tabbing out of the
field with an empty search should be the same as closing/canceling
the search.
This would be incorrect behavior.  You need to be able to activate the 
search options *before* you do the search.
08/17/2008 03:38:23 PM Chuck Hagenbuch Comment #8 Reply to this comment
My point is, since both of them (at least tab; escape seems a bit 
dodgy) blur the field, _shouldn't_ they dismiss the search? Escape is 
pretty standard keyboard nav for "cancel", also, so even if it doesn't 
blur the field, I think ti should.
08/17/2008 02:35:33 PM Jan Schneider Comment #7 Reply to this comment
No, nothing happens if I tab out of the search field, or hit the escape key.
08/17/2008 02:07:25 PM Chuck Hagenbuch Comment #6 Reply to this comment
So when you tab out of it the search bar closes and you see the 
non-search mailbox list.
08/17/2008 01:05:12 PM Jan Schneider Comment #5 Reply to this comment
Still works fine.
08/17/2008 04:54:40 AM Chuck Hagenbuch Comment #4 Reply to this comment
Does it work correctly if you hit tab (which for me focuses the search 
field) and then tab again to blur the search field? That displays 
similar behavior for me - seems like tabbing out of the field with an 
empty search should be the same as closing/canceling the search.
08/15/2008 10:09:06 PM Jan Schneider Comment #3 Reply to this comment
I don't see this either with that combination.
08/15/2008 10:01:14 PM Michael Slusarz Comment #2
Assigned to Chuck Hagenbuch
State ⇒ Feedback
Reply to this comment
Chuck reports he saw this when using FF3/Mac, but I can't reproduce 
using that browser/OS combination, or any other browser for that 
matter.  An escape in the filter field does nothing for me.
08/13/2008 01:29:26 AM Chuck Hagenbuch Comment #1
Priority ⇒ 1. Low
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to Michael Slusarz
Summary ⇒ Hitting escape in the search field doesn't clear it
Type ⇒ Bug
Queue ⇒ DIMP
Reply to this comment
I took a quick look here but didn't see an obvious place. When you hit 
escape while the viewport filter is focused, the field isn't focused 
anymore, but it's not disabled either, and the value reverts to 
"Search". The viewport shows the results of searching for Search, 
instead of resetting.

Saved Queries