Tickets :: [#7160] Pager, Filter and Directory Caching patches

6.0.0-beta1

7/12/25

Summary	Pager, Filter and Directory Caching patches
Queue	Gollem
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	joel (at) scopserv (dot) com
Created	08/05/2008 (6185 days ago)
Due
Updated	08/10/2008 (6180 days ago)
Assigned	08/06/2008 (6184 days ago)
Resolved	08/10/2008 (6180 days ago)
Milestone
Patch	Yes

08/10/2008 01:52:25 AM	Michael Slusarz	State ⇒ Resolved

08/06/2008 05:11:43 PM	Michael Slusarz	State ⇒ Feedback

08/06/2008 05:07:22 PM	Michael Slusarz	Comment #5	Reply to this comment
[Show Quoted Text - 10 lines][Hide Quoted Text] I'm checking new patches applied to CVS and on manager.php you must change $refresh_params = array('page' => $page); to $refresh_params = array(); Else we are unable to switch to others page, this GET variable is updated on the UI/Pager.php file. This is incorrect. Where can you not switch to another page? Pager does the necessary changing of the page parameter in the URL for us (obviously). And we need the page parameter elsewhere in the page or else we lose our position - i.e. refresh, performing an action on the file, etc. In fact, right now, we aren't using refresh_url enough - not too much. I have fixed the page/filter when doing the aforementioned file actions.

08/06/2008 02:32:06 PM	Chuck Hagenbuch	State ⇒ Assigned

08/06/2008 12:12:42 PM	joel (at) scopserv (dot) com	Comment #4	Reply to this comment
I'm checking new patches applied to CVS and on manager.php you must change $refresh_params = array('page' => $page); to $refresh_params = array(); Else we are unable to switch to others page, this GET variable is updated on the UI/Pager.php file.

08/06/2008 05:08:01 AM	Michael Slusarz	Comment #3 State ⇒ Resolved	Reply to this comment
I have committed the Pager and filter portions of this patch - thanks. As for the caching part, your solution is harcoded to using files, doesn't expire the cache on certain events (i.e. deleting a file, changing the sort), etc. I have gone ahead and implemented caching independently using Horde_Cache instead, with proper cache expirations, and the like.

08/06/2008 04:13:33 AM	CVS Commit	Comment #2	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/gollem/config/prefs.php.dist?r1=1.33&r2=1.34&ty=u http://cvs.horde.org/diff.php/gollem/docs/CHANGES?r1=1.162&r2=1.163&ty=u http://cvs.horde.org/diff.php/gollem/js/manager.js?r1=1.9&r2=1.10&ty=u http://cvs.horde.org/diff.php/gollem/js/src/manager.js?r1=1.7&r2=1.8&ty=u http://cvs.horde.org/diff.php/gollem/manager.php?r1=1.191&r2=1.192&ty=u http://cvs.horde.org/diff.php/gollem/selectlist.php?r1=1.28&r2=1.29&ty=u http://cvs.horde.org/diff.php/gollem/templates/manager/manager.html?r1=1.24&r2=1.25&ty=u

08/06/2008 04:01:11 AM	Michael Slusarz	Assigned to Michael Slusarz State ⇒ Accepted

08/05/2008 10:50:33 PM	joel (at) scopserv (dot) com	Comment #1 State ⇒ New New Attachment: gollem-pager-filter.patch Patch ⇒ Yes Milestone ⇒ Queue ⇒ Gollem Summary ⇒ Pager, Filter and Directory Caching patches Type ⇒ Enhancement Priority ⇒ 1. Low	Reply to this comment
This patch add support for Filter (Search), Pager (item per Page) and Directory Caching on File Manager Administrator can enable/disable Directory Caching on configuration. Options to set the cache lifetime and minimum of items on the directory in order to cache data are available. End users have a new option to set the number of item to be displayed per page.