Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/imp/config/prefs.php.dist?r1=1.216.4.31&r2=1.216.4.32&ty=u
http://cvs.horde.org/diff.php/imp/lib/prefs.php?r1=1.3.10.28&r2=1.3.10.29&ty=u
http://cvs.horde.org/diff.php/imp/templates/prefs/trashselect.inc?r1=2.11.12.7&r2=2.11.12.8&ty=u

Looks good until we have that prefs rewrite. :) Thanks!

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/dimp/templates/index/index.inc?r1=1.212&r2=1.213&ty=u
http://cvs.horde.org/diff.php/imp/lib/IMP.php?r1=1.703&r2=1.704&ty=u
http://cvs.horde.org/diff.php/imp/mailbox.php?r1=2.866&r2=2.867&ty=u
http://cvs.horde.org/diff.php/mimp/mailbox.php?r1=1.82&r2=1.83&ty=u

How about this?

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/imp/config/prefs.php.dist?r1=1.293&r2=1.294&ty=u
http://cvs.horde.org/diff.php/imp/lib/prefs.php?r1=1.52&r2=1.53&ty=u
http://cvs.horde.org/diff.php/imp/templates/prefs/trashselect.inc?r1=2.24&r2=2.25&ty=u

Also, now I can't switch to a regular trash folder without editing 
prefs directly, because use_vtrash is checked, I can't uncheck it, and 
when I try to turn use_trash on, I'm told that I can't use both trash 
and vtrash and that vtrash will be used.

This sort of works, but is pretty bad user experience in my opinion. 
For one thing it forces two steps to enable move to trash; for 
another, the process for enabling virtual trash now looks like this:



- enable move to trash

- be told you can't delete messages until you select a trash folder

- go back to delmove pref group

- select use virtual trash

- be told that you can't use both virtual trash and a regular trash 
folder at the same time

- go back to make sure virtual trash was set, and you can't see the 
option anymore because use_trash was automatically set to false.



vtrash is in fact enabled now, but I wouldn't expect a user to trust 
that. Why are we hiding these preferences in the first place? It seems 
clear enough to me that if use trash isn't selected a trash folder 
won't be shown. Barring rewriting the prefs UI to allow dynamic 
enabling/disabling of prefs, I think we should just show them.

How about this solution.  Instead of disabling trash if no Trash pref 
is set, we warn instead.  The delete code will prevent deletion until 
a Trash folder is selected so we are good there.

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/imp/lib/prefs.php?r1=1.51&r2=1.52&ty=u

Because of this line at the bottom of imp/lib/prefs.php:



// Don't show Trash options if Trash is disabled.

if (!$GLOBALS['prefs']->getValue('use_trash')) {

     $GLOBALS['_prefs']['trashselect']['type'] = 
$GLOBALS['_prefs']['use_vtrash']['type'] = 
$GLOBALS['_prefs']['empty_trash_menu']['type'] = 'implicit';

}



And the check on use_trash that won't let you turn it on if there is 
no trash folder, it is impossible to turn on use_trash if you haven't 
previously selected a trash folder, and you can't select a trahs 
folder because that selection is hidden when use_trash is off.



I *think* the thing to do here would be to just always show the 
trashselect pref and go from there. Any other ideas?