6.0.0-alpha14
7/3/25

[#7083] SyncML\Backend.php: $_packetNum not used
Summary SyncML\Backend.php: $_packetNum not used
Queue Synchronization
Type Bug
State Resolved
Priority 1. Low
Owners
Requester patrick.abiven (at) apitech (dot) fr
Created 07/18/2008 (6194 days ago)
Due
Updated 07/26/2008 (6186 days ago)
Assigned 07/18/2008 (6194 days ago)
Resolved 07/26/2008 (6186 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
07/26/2008 01:18:42 PM Jan Schneider State ⇒ Resolved
 
07/18/2008 09:21:07 AM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
It seems that the variable name $_packetNum is not used. The log
function is using a local variable $packetNum (and not $_packetNum).
Correct, I removed the property, thanks.
In some cases (when multiples synchronization occur at the same
time), the packetNum is not incremented, and some log files may be
used twice (see an extract from syncml_log.txt).
This could be solved by locking the packetnum.txt file while the 
logfile is written, but I don't see the point in it, since this is 
really only for debugging purposes, and you should only debug in a 
controlled environment, i.e. where you can make sure that only a 
single device/user/sync session is tested.
07/18/2008 08:55:12 AM patrick (dot) abiven (at) apitech (dot) fr Comment #1
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ Synchronization
Summary ⇒ SyncML\Backend.php: $_packetNum not used
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
Hello

It seems that the variable name $_packetNum is not used. The log 
function is using a local variable $packetNum (and not $_packetNum).



In some cases (when multiples synchronization occur at the same time), 
the packetNum is not incremented, and some log files may be used twice 
(see an extract from syncml_log.txt).



DEBUG:  Backend of class SyncML_Backend_Horde created

DEBUG:  Started at 2008-07-18 08:44:50. Packet logged in 
/var/tmp/HordeSync2/sync/syncml_client_63920.xml

...



DEBUG:  Backend of class SyncML_Backend_Horde created

DEBUG:  Started at 2008-07-18 08:44:54. Packet logged in 
/var/tmp/HordeSync2/syn

c/syncml_client_63920.xml



Regards

Patrick

Saved Queries