[#7057] wrong empty DB file
Summary wrong empty DB file
Queue Vacation
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners Jan Schneider <jan (at) horde (dot) org>
Requester rsalmon (at) mbpgroup (dot) com
Created 07/11/2008 (132 days ago)
Due
Updated 07/15/2008 (128 days ago)
Assigned 07/15/2008 (128 days ago)
Resolved 07/15/2008 (128 days ago)
Attachments forward.patch Download
Milestone
Patch No

History
07/15/2008 Jan Schneider Comment #5
State ⇒ Resolved		 Reply to this comment
Committed, thanks.
07/15/2008 CVS Commit Comment #4 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/vacation/lib/Driver/forwards.php?r1=1.53&r2=1.54&ty=u
07/15/2008 Jan Schneider State ⇒ Assigned
Assigned to Jan Schneider
 
07/15/2008 rsalmon (at) mbpgroup (dot) com Comment #3
New Attachment: forward.patch Download		 Reply to this comment
The patch doesn't apply. Please use latest CVS HEAD and upload
patches as ticket attachments.
file vacation/lib/Driver/forwards.php
CVS/Entries : /forwards.php/1.53/Tue Jul 15 07:37:48 2008//


07/12/2008 Jan Schneider Comment #2
State ⇒ Feedback		 Reply to this comment
The patch doesn't apply. Please use latest CVS HEAD and upload patches 
as ticket attachments.
07/11/2008 rsalmon (at) mbpgroup (dot) com Comment #1
Patch ⇒
Milestone ⇒
Queue ⇒ Vacation
Summary ⇒ wrong empty DB file
Type ⇒ Bug
Priority ⇒ 1. Low
State ⇒ Unconfirmed		 Reply to this comment
here is a patch
--- forwards.php.org    2008-07-11 09:26:24.000000000 +0200
+++ forwards.php        2008-07-10 19:13:00.000000000 +0200
@@ -63,13 +63,19 @@

          // Build the message.
          $full_message = $this->_buildMessage($message, $subject, $from);
+        // Set up the vacation specific files first.
+
+        $status = $this->_vfs->writeData('', '.vacation.msg', $full_message);
+        if (is_a($status, 'PEAR_Error')) {
+            $this->err_str = $status->getMessage();
+            return false;
+        }

          // Set up the vacation specific files first.
-        foreach (array('.vacation.msg' => $full_message,
-                       '.vacation.pag' => $dbfile,
+        foreach (array('.vacation.pag' => $dbfile,
                         '.vacation.dir' => $dbfile,
                         '.vacation.db'  => $dbfile) as $file => $content) {
-            $status = $this->_vfs->writeData('', $file, $content);
+            $status = $this->_vfs->write('', $file, $content);
              if (is_a($status, 'PEAR_Error')) {
                  return $status;
              }