Summary | listing alarms of recurring events which cross a day boundary |
Queue | Kronolith |
Queue Version | 2.2 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org |
Requester | develop (at) kristov (dot) de |
Created | 07/06/2008 (6218 days ago) |
Due | |
Updated | 08/20/2008 (6173 days ago) |
Assigned | 07/13/2008 (6211 days ago) |
Resolved | 08/20/2008 (6173 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 2.2.1 |
Patch | Yes |
Taken from
State ⇒ Resolved
http://cvs.horde.org/diff.php/kronolith/lib/Driver/sql.php?r1=1.208&r2=1.209&ty=u
the event.
Assigned to
State ⇒ Assigned
Milestone ⇒ 2.2.1
Tuesday, 12:00 with an alarm of 15 minutes before start. Let's assume
it is Monday, 2008-07-07, 15:45, stored in $date. Then the old code
$start = new Horde_Date($next);
$start->min -= $event->getAlarm();
$start->correct();
$end = new Horde_Date(array(
'year' => $next->year,
'month' => $next->month,
'mday' => $next->mday,
'hour' => $event->end->hour,
'min' => $event->end->min,
'sec' => $event->end->sec));
assigns "2008-07-07 15:45" to $start and "2008-07-07 12:00" to $end.
Now the second part of the following comparison
if ($start->compareDateTime($date) <= 0
&& $date->compareDateTime($end) <= -1)
fails, as $date ("2008-07-07 15:45") does not come before $end
("2008-07-07 12:00"). The patch fixes this by assigning the correct
event end "2008-07-08 12:00" to $end.
State ⇒ Feedback
State ⇒ Unconfirmed
New Attachment: horde-kronolith-2.2-endofevent.patch
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Kronolith
Summary ⇒ listing alarms of recurring events which cross a day boundary
Type ⇒ Bug
Priority ⇒ 2. Medium
correctly which cross a day boundary. The patch attached fixes this.