6.0.0-RC7
7/1/26

[#7035] listing alarms of recurring events which cross a day boundary
Summary listing alarms of recurring events which cross a day boundary
Queue Kronolith
Queue Version 2.2
Type Bug
State Resolved
Priority 2. Medium
Owners jan (at) horde (dot) org
Requester develop (at) kristov (dot) de
Created 7/6/08 (6569 days ago)
Due
Updated 8/20/08 (6524 days ago)
Assigned 7/13/08 (6562 days ago)
Resolved 8/20/08 (6524 days ago)
Github Issue Link
Github Pull Request
Milestone 2.2.1
Patch Yes

History
594 Jan Schneider Deleted Original Message
 
524 Jan Schneider Comment #6
Taken from Horde DevelopersHorde Developers
State ⇒ Resolved
Reply to this comment
Fixed in CVS.
4010 Jan Schneider Comment #4 Reply to this comment
The fix is almost correct, but it doesn't consider DST switched during 
the event.
59 Jan Schneider Assigned to Jan Schneider
Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
Milestone ⇒ 2.2.1
 
306 develop (at) kristov (dot) de Comment #3 Reply to this comment
Please provide a test case to reproduce this.
Suppose you have a recurring event each Monday, 16:00 to the following 
Tuesday, 12:00 with an alarm of 15 minutes before start. Let's assume 
it is Monday, 2008-07-07, 15:45, stored in $date. Then the old code



$start = new Horde_Date($next);

$start->min -= $event->getAlarm();

$start->correct();

$end = new Horde_Date(array(

   'year' => $next->year,

   'month' => $next->month,

   'mday' => $next->mday,

   'hour' => $event->end->hour,

   'min' => $event->end->min,

   'sec' => $event->end->sec));



assigns "2008-07-07 15:45" to $start and "2008-07-07 12:00" to $end. 
Now the second part of the following comparison



if ($start->compareDateTime($date) <= 0

   &&  $date->compareDateTime($end) <= -1)



fails, as $date ("2008-07-07 15:45") does not come before $end 
("2008-07-07 12:00"). The patch fixes this by assigning the correct 
event end "2008-07-08 12:00" to $end.


2310 Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
Please provide a test case to reproduce this.
298 develop (at) kristov (dot) de Comment #1
State ⇒ Unconfirmed
New Attachment: horde-kronolith-2.2-endofevent.patch
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Kronolith
Summary ⇒ listing alarms of recurring events which cross a day boundary
Type ⇒ Bug
Priority ⇒ 2. Medium
Reply to this comment
The function mentioned above does not handle recurring events 
correctly which cross a day boundary. The patch attached fixes this.

Saved Queries