Tickets :: [#6968] can not remove user data when deleting user

6.0.0-alpha12

6/4/25

Summary	can not remove user data when deleting user
Queue	Nag
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	vilius (at) lnk (dot) lt
Created	06/23/2008 (6190 days ago)
Due
Updated	06/30/2008 (6183 days ago)
Assigned	06/28/2008 (6185 days ago)
Resolved	06/28/2008 (6185 days ago)
Milestone
Patch	No

06/30/2008 05:35:05 PM	vilius (at) lnk (dot) lt	Comment #13	Reply to this comment
Should be fixed now in both HEAD and FW_3. There were a few things going on. First we were never even attempting to delete the actual share, just the data in Mnemo and Nag. Second, we were not removing Confirmed as fixed. any permissions the removed user may have had in other user's shares... Confirmed as fixed. and finally, there was a bug in the SQL Horde_Share driver that was causing only the share data itself, and not the user or group perm data to be deleted when removing a share...all have (hopefully) been fixed. Confirmed as fixed except for Kronolith. Per Chuck's request tracking this under ~~bug 6998~~. Also filled another related issue under ~~bug 6999~~. All tests were performed on FW_3 code.

06/28/2008 10:27:15 PM	Michael Rubinsky	Comment #12 Assigned to Michael Rubinsky State ⇒ Resolved	Reply to this comment
Should be fixed now in both HEAD and FW_3. There were a few things going on. First we were never even attempting to delete the actual share, just the data in Mnemo and Nag. Second, we were not removing any permissions the removed user may have had in other user's shares...and finally, there was a bug in the SQL Horde_Share driver that was causing only the share data itself, and not the user or group perm data to be deleted when removing a share...all have (hopefully) been fixed.

06/28/2008 04:29:33 PM	CVS Commit	Comment #11	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Share/Share/sql.php?r1=1.35&r2=1.36&ty=u

06/28/2008 02:54:38 PM	CVS Commit	Comment #10	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/mnemo/lib/api.php?r1=1.87&r2=1.88&ty=u http://cvs.horde.org/diff.php/nag/lib/Nag.php?r1=1.173&r2=1.174&ty=u http://cvs.horde.org/diff.php/nag/lib/api.php?r1=1.184&r2=1.185&ty=u

06/28/2008 02:29:02 PM	Chuck Hagenbuch	Comment #9 State ⇒ Assigned	Reply to this comment
Please track Turba issues in a separate ticket.

06/28/2008 06:40:02 AM	vilius (at) lnk (dot) lt	Comment #8	Reply to this comment
With latest api.php patches I don't get error message anymore, but actual data from backend is not cleared for nag and mnemo. [nag\|mnemo]_shares and [nag\|mnemo]_shares_users are still populated. In Turba on the other hand, data is removed from turba_shares but NOT from turba_shares_users.

06/24/2008 02:26:28 AM	Michael Rubinsky	Comment #7 State ⇒ Resolved	Reply to this comment
fixed for 2.2.1

06/24/2008 02:22:30 AM	CVS Commit	Comment #6	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/nag/lib/api.php?r1=1.182&r2=1.183&ty=u

06/23/2008 09:17:20 PM	Michael Rubinsky	Summary ⇒ can not remove user data when deleting user Taken from Michael Rubinsky

06/23/2008 09:16:44 PM	Michael Rubinsky	Comment #5 Version ⇒ HEAD Queue ⇒ Nag	Reply to this comment
Setting this to Nag (and will create a duplicate in Mnemo as well), since this is not an issue with any of the share drivers.

06/23/2008 09:15:29 PM	Michael Rubinsky	Comment #4	Reply to this comment
I'm using pretty default sources, e.g. localsql, so this should not be the problem. right, but if you have any shares other than a sql share source...such as the favourites driver, or even any virtual address books you will get the error I'm referring to. Check the logs after applying the error logging changes, the Turba error should be gone. That being said, that's not the root of the problem. The problem is not specific to the sql share driver. The issue is that when you are deleting a user in Nag, for instance, the Nag::listTaskList() method always checks perms for the currently logged in user, not the user who you are deleting...so the task list is not returned. These methods need to be changed to allow filtering perms for other users as well.

06/23/2008 08:42:59 PM	vilius (at) lnk (dot) lt	Comment #3	Reply to this comment
I'm using pretty default sources, e.g. localsql, so this should not be the problem.

06/23/2008 08:34:06 PM	Michael Rubinsky	Comment #2 State ⇒ Assigned Assigned to Michael Rubinsky	Reply to this comment
I don't think this is an issue with the share driver. At least in the case of Turba, it is most likely being caused by a source that does not support removing user data. I added some error logging, and (temporarily?) removed the error flag in this case... not sure about the other apps yet, still digging.

06/23/2008 07:26:05 PM	vilius (at) lnk (dot) lt	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed Patch ⇒ No Milestone ⇒ Summary ⇒ could not remove user data if using SQL share backend Type ⇒ Bug Queue ⇒ Horde Framework Packages	Reply to this comment
User data removal for turba, nag, mnemo and kronolith fails if SQL share backend is used. Turba fails with: There was an error removing an address book for username Nag and others fail with: Permission Denied