6.0.0-alpha12
6/12/25

[#6941] Unclear error message in compose window when profile's from address is invalid
Summary Unclear error message in compose window when profile's from address is invalid
Queue IMP
Queue Version 4.2
Type Enhancement
State Resolved
Priority 1. Low
Owners chuck (at) horde (dot) org
Requester steinhof (at) umich (dot) edu
Created 06/17/2008 (6204 days ago)
Due
Updated 06/25/2008 (6196 days ago)
Assigned
Resolved 06/25/2008 (6196 days ago)
Milestone
Patch Yes

History
06/25/2008 04:01:20 AM Chuck Hagenbuch Comment #7
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Patch ⇒ Yes
Reply to this comment
Switched to using a gettext message (for translation) and committed - thanks!
06/25/2008 03:55:31 AM Chuck Hagenbuch Deleted Original Message
 
06/24/2008 08:29:10 PM steinhof (at) umich (dot) edu Comment #5 Reply to this comment
Why isn't this validation being done when the user enters the e-mail
address in the identities page?  That would make the most sense.
It is done there. Some of our user's identities contain invalid from 
addresses because we migrated our data before the upgrade script 
validated those addresses.
06/24/2008 08:27:05 PM steinhof (at) umich (dot) edu Comment #4
New Attachment: compose_from_validation2.patch Download
Reply to this comment
I think it would be better to only tell the user what to do. And the
message should be extended earlier in the code, in getFromLine().
Also, please use getMessage() instead of accessing the message
property directly.
I've attached a new patch, which just extends the error message, and 
does so in getFromLine().
06/21/2008 05:46:56 PM Michael Slusarz Comment #3 Reply to this comment
Why isn't this validation being done when the user enters the e-mail 
address in the identities page?  That would make the most sense.
06/18/2008 09:23:56 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
I like the idea of a better error message, but linking to the 
preference page is not so good in this very case. Opening the 
preference page in a new window is bad usability (see the category 
color popup, it's horrible). And since the compose window can be both, 
in the horde frame, or in a popup window, we can't target the current 
window either.

I think it would be better to only tell the user what to do. And the 
message should be extended earlier in the code, in getFromLine(). 
Also, please use getMessage() instead of accessing the message 
property directly.
06/17/2008 01:37:42 PM steinhof (at) umich (dot) edu Comment #1
State ⇒ New
New Attachment: compose_from_validation.patch
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Unclear error message in compose window when profile's from address is invalid
Type ⇒ Enhancement
Priority ⇒ 1. Low
Reply to this comment
If a user's profile has a From address that does not pass validation, 
the user is prevented from sending mail and is given this error 
message: "Validation failed for: Joe User <joe@example.com>" This can 
be confusing for the user and it would be nice to have a more helpful 
error message.



I've attached a patch with extends the error message to read: 
"Validation failed for: Joe User <joe@example.com> Your From address 
is not a valid email address. This can be fixed in your <a 
href="/horde/services/prefs.php?app=imp&group=identities">Personal 
Information</a> options page." This allows users to immediately jump 
to the place where they can fix the problem.



(Is there a better way to link to the "Personal Information" pref page?)

Saved Queries