Tickets :: [#6921] Change Search UI screen to search by KB instead of bytes

6.0.0-beta1

7/20/25

Summary	Change Search UI screen to search by KB instead of bytes
Queue	IMP
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	slusarz (at) horde (dot) org
Created	06/13/2008 (6246 days ago)
Due
Updated	07/19/2008 (6210 days ago)
Assigned
Resolved	07/19/2008 (6210 days ago)
Milestone
Patch	No

07/19/2008 09:35:26 PM	Michael Slusarz	Comment #6 State ⇒ Resolved	Reply to this comment
Resolving for now.

07/16/2008 08:38:38 AM	Jan Schneider	Comment #5 Taken from Horde Developers Taken from Jan Schneider	Reply to this comment
Looks and works fine.

07/16/2008 06:32:52 AM	CVS Commit	Comment #4	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/docs/CHANGES?r1=1.699.2.328&r2=1.699.2.329&ty=u http://cvs.horde.org/diff.php/imp/lib/Search.php?r1=1.37.10.43&r2=1.37.10.44&ty=u http://cvs.horde.org/diff.php/imp/search.php?r1=2.128.2.30&r2=2.128.2.31&ty=u http://cvs.horde.org/diff.php/imp/templates/search/search.html?r1=1.28.2.3&r2=1.28.2.4&ty=u

07/16/2008 06:27:01 AM	Michael Slusarz	Comment #3 State ⇒ Feedback	Reply to this comment
Changed display to KB instead of bytes. Further testing would be great.

07/16/2008 06:26:59 AM	CVS Commit	Comment #2	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/docs/CHANGES?r1=1.1161&r2=1.1162&ty=u http://cvs.horde.org/diff.php/imp/lib/Search.php?r1=1.115&r2=1.116&ty=u http://cvs.horde.org/diff.php/imp/search.php?r1=2.198&r2=2.199&ty=u http://cvs.horde.org/diff.php/imp/templates/search/search.html?r1=1.30&r2=1.31&ty=u

06/13/2008 06:46:16 PM	Michael Slusarz	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Change Search UI screen to search by KB instead of bytes Queue ⇒ IMP Assigned to Jan Schneider Assigned to Michael Slusarz Assigned to Horde Developers Milestone ⇒ Patch ⇒ No State ⇒ Assigned	Reply to this comment
A better idea would be to add a dropdown list MB, KB, Byte and the value in the field would automatically multipled by the selected setting - this way you are not limiting yourself to a specific range if you search by byte count internally already Agreed - changing this to search for KB (or MB) will break all current virtual folders unless some kind of in-place updating of preference data is done. Why? All you have to do is to calculate to bytes before storing it in the virtual folder preference, and the opposite when reading it. How do you tell whether the the previous search was in bytes, KB, or MB? (I would not agree on any change that would simply make KB the default - I think bytes makes more sense as a default than KB). Scenario: 1. User searches for something in KB. 2. Search returns no result. 3. When search is reloaded, his search will be displayed in bytes, not KB. Although not incorrect behavior, it probably isn't the expected behavior. Additionally, the textified representations of the search will be incorrect also. Thus the need to alter the stored virtual folder value in someway to indicate the search type. I think it's safe to assume that the user entered the lowest number possible with the units available. Thus we can calculate back from the bytes to largest unit possible without loss. We do something similar in Kronolith when calculating alarms (saved in minutes) to hours and days. E.g. the user enter 2 KB, we save 2048. When displaying the value again, we see that we can divide by 1024 without loss. If he entered 2000 bytes instead, we would display 2000 bytes.