Fixed for Horde 3.2.2.

Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/framework/Form/Form/Renderer.php?r1=1.221&r2=1.222&ty=u

I don't know if this would happen in a normal Hordeinstallation.

We want to disallow our users to edit the "My email Addresses" field 
in Ingo Vacaions,

Therefor we patched ingo/vacation.php. See the Attached Image



horde/ingo# diff -u vacation.php.orig  vacation.php

--- vacation.php.orig   2008-05-01 00:11:50.000000000 +0200

+++ vacation.php        2008-06-10 15:13:30.000000000 +0200

@@ -50,7 +50,7 @@

  $form->setSection('advanced', _("Advanced Settings"));

  if (empty($conf['hooks']['vacation_addresses']) ||

      empty($conf['hooks']['vacation_only'])) {

-    $v = &$form->addVariable(_("My email addresses:"), 'addresses', 
'longtext', true, false, null, array(5, 40));

+    $v = &$form->addVariable(_("My email addresses:"), 'addresses', 
'longtext', true, true, null, array(5, 40));

      $v->setHelp('vacation-myemail');

  }

  $v = &$form->addVariable(_("Addresses to not send responses to:"), 
'excludes', 'longtext', false, false, null, array(10, 40));

---------------------------------------------------



I think this may happen in any Form where Readonly and Readwrite 
Variables are used, but i don't

konw if this is happening anywhere else. If it happens anyware else in 
Horde there is a 50% chance that we don't see it.



In case of readonly the functions  _renderVarDisplayBegin and 
_renderVarDisplayEnd are used instad of _renderVarInputBegin and 
_renderVarInputEnd which have one column less.

The other idea would be not to call _renderVarDisplay* but 
_renderVarInput* and parse the readonlyflag to  _renderVarInput* so 
that readonly option is inserted in the input htmltag

Can you please point out a place in a Horde app where this happens, or 
supply a small script to reproduce the problem?

... and this patch will just add in an extra column every time, even 
when it's not needed.

Switching a Form Variable to Readonly the help link and the column is 
turned of.

The first is correct, but the second results in the alternating row 
colors for even

and odd rows can breake on the last column