[#6888] missing column in function _renderVarDisplayEnd Form/Renderer.php
Summary missing column in function _renderVarDisplayEnd Form/Renderer.php
Queue Horde Framework Packages
Queue Version FRAMEWORK_3
Type Bug
State Resolved
Priority 1. Low
Owners
Requester michael (dot) menge (at) zdv (dot) uni-tuebingen (dot) de
Created 06/10/2008 (79 days ago)
Due
Updated 06/15/2008 (74 days ago)
Assigned 06/10/2008 (79 days ago)
Resolved 06/15/2008 (74 days ago)
Attachments Vacation.png Download
Milestone
Patch No

History
06/15/2008 Chuck Hagenbuch Comment #6
State ⇒ Resolved
Reply to this comment
Fixed for Horde 3.2.2.
06/15/2008 CVS Commit Comment #5 Reply to this comment
06/11/2008 michael (dot) menge (at) zdv (dot) uni-tuebingen (dot) de Comment #4
New Attachment: Vacation.png Download
Reply to this comment
Can you please point out a place in a Horde app where this happens,
or supply a small script to reproduce the problem?

I don't know if this would happen in a normal Hordeinstallation.
We want to disallow our users to edit the "My email Addresses" field 
in Ingo Vacaions,
Therefor we patched ingo/vacation.php. See the Attached Image

horde/ingo# diff -u vacation.php.orig  vacation.php
--- vacation.php.orig   2008-05-01 00:11:50.000000000 +0200
+++ vacation.php        2008-06-10 15:13:30.000000000 +0200
@@ -50,7 +50,7 @@
  $form->setSection('advanced', _("Advanced Settings"));
  if (empty($conf['hooks']['vacation_addresses']) ||
      empty($conf['hooks']['vacation_only'])) {
-    $v = &$form->addVariable(_("My email addresses:"), 'addresses', 
'longtext', true, false, null, array(5, 40));
+    $v = &$form->addVariable(_("My email addresses:"), 'addresses', 
'longtext', true, true, null, array(5, 40));
      $v->setHelp('vacation-myemail');
  }
  $v = &$form->addVariable(_("Addresses to not send responses to:"), 
'excludes', 'longtext', false, false, null, array(10, 40));
---------------------------------------------------

I think this may happen in any Form where Readonly and Readwrite 
Variables are used, but i don't
konw if this is happening anywhere else. If it happens anyware else in 
Horde there is a 50% chance that we don't see it.

In case of readonly the functions  _renderVarDisplayBegin and 
_renderVarDisplayEnd are used instad of _renderVarInputBegin and 
_renderVarInputEnd which have one column less.
The other idea would be not to call _renderVarDisplay* but 
_renderVarInput* and parse the readonlyflag to  _renderVarInput* so 
that readonly option is inserted in the input htmltag



06/10/2008 Chuck Hagenbuch Comment #3
State ⇒ Feedback
Taken from Chuck Hagenbuch
Reply to this comment
Can you please point out a place in a Horde app where this happens, or 
supply a small script to reproduce the problem?
06/10/2008 Chuck Hagenbuch Deleted Attachment: Renderer.patch
 
06/10/2008 Chuck Hagenbuch Comment #2 Reply to this comment
... and this patch will just add in an extra column every time, even 
when it's not needed.
06/10/2008 Chuck Hagenbuch State ⇒ Assigned
Assigned to Chuck Hagenbuch
 
06/10/2008 michael (dot) menge (at) zdv (dot) uni-tuebingen (dot) de Comment #1
New Attachment: Renderer.patch
Patch ⇒
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ missing column in function _renderVarDisplayEnd Form/Renderer.php
Type ⇒ Bug
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Reply to this comment
Switching a Form Variable to Readonly the help link and the column is 
turned of.
The first is correct, but the second results in the alternating row 
colors for even
and odd rows can breake on the last column