Tickets :: [#6869] View messages link does not work

Summary	View messages link does not work
Queue	IMP
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	1. Low
Owners	Michael Slusarz <slusarz (at) horde (dot) org>
Requester	Thomas Jarosch <thomas (dot) jarosch (at) intra2net (dot) com>
Created	06/09/2008 (166 days ago)
Due
Updated	06/13/2008 (162 days ago)
Assigned
Resolved	06/13/2008 (162 days ago)
Attachments	horde-imp-fix-view_messages.patch
Milestone
Patch	No

06/13/2008	Michael Slusarz	Comment #7 State ⇒ Resolved Assigned to Michael Slusarz	Reply to this comment
That is definitely the problem - can reproduce when I turn cookies off (notwithstanding ~~Ticket 6910~~...) The patch looks proper so it has been applied to IMP 4.2.1.

06/13/2008	CVS Commit	Comment #6	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/lib/IMP.php?r1=1.690&r2=1.691&ty=u http://cvs.horde.org/diff.php/imp/mailbox.php?r1=2.862&r2=2.863&ty=u

06/10/2008	Thomas Jarosch	Comment #5	Reply to this comment
Works fine w/Safari 3, FF3 & 2, IE 7 on Visa, IE 6 on XP. It is quite possible that you have preexisting params in your URL (such as passing the SID via URL instead of using cookies) that is causing the issue. But I don't want to apply the patch until I know what the issue is. Thanks for testing. You're right, I have the sid in my URL and it's the first parameter. I've taken another look at Horde/Util.php::addParameter() and normally $encode is true by default. I'm wondering why it's working at all :-)

06/10/2008	Michael Slusarz	Comment #4	Reply to this comment
Mighty strange, without that patch the location for the redirect gets computed wrong at my site. Which browser do you use? Does it still work if you apply the patch? Works fine w/Safari 3, FF3 & 2, IE 7 on Visa, IE 6 on XP. It is quite possible that you have preexisting params in your URL (such as passing the SID via URL instead of using cookies) that is causing the issue. But I don't want to apply the patch until I know what the issue is.

06/10/2008	Thomas Jarosch	Comment #3	Reply to this comment
Works for me. Mighty strange, without that patch the location for the redirect gets computed wrong at my site. Which browser do you use? Does it still work if you apply the patch? Maybe it helps to comment out the header("Location:") line in imp/mailbox.php ~189 and print out just the URL to have a look at it. For me every parameter separator was a "&" instead of "&".

06/09/2008	Michael Slusarz	Comment #2	Reply to this comment
Works for me.

06/09/2008	Thomas Jarosch	Comment #1 New Attachment: horde-imp-fix-view_messages.patch Patch ⇒ Milestone ⇒ Queue ⇒ IMP Summary ⇒ View messages link does not work Type ⇒ Bug Priority ⇒ 1. Low State ⇒ Unconfirmed	Reply to this comment
Hello together, the "view messages" link of a mailbox does not work because the "&" character to separate the parameters becomes "&". Attached patch fixes it. Thomas