[#6860] No more support for "pam_auth" extension?
Summary No more support for "pam_auth" extension?
Queue Horde Framework Packages
Queue Version FRAMEWORK_3
Type Enhancement
State Resolved
Priority 2. Medium
Owners Jan Schneider <jan (at) horde (dot) org>
Requester reg (at) evolix (dot) fr
Created 06/08/2008 (81 days ago)
Due
Updated 07/13/2008 (46 days ago)
Assigned
Resolved 07/13/2008 (46 days ago)
Attachments
Milestone
Patch No

History
07/13/2008 Jan Schneider Assigned to Jan Schneider
 
07/13/2008 Jan Schneider State ⇒ Resolved
 
07/13/2008 CVS Commit Comment #18 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/framework/Auth/Auth/pam.php?r1=1.21&r2=1.22&ty=u
07/02/2008 Jan Schneider Comment #17 Reply to this comment
Let's remove it for Horde 4.
07/02/2008 Chuck Hagenbuch Comment #16 Reply to this comment
Since pam_auth is pretty much _only_ now available in debian, is there 
a real reason to have this in the main Horde dist as opposed to in the 
debian packages?
06/16/2008 Jan Schneider Comment #15 Reply to this comment
I guess.
06/16/2008 Jan Schneider Comment #14 Reply to this comment
Actually yes. This old extension code probably *requires* to pass the 
argument by reference.
06/16/2008 Chuck Hagenbuch Comment #13 Reply to this comment
If I change "s/$error/&$error/", all is right.
No, see Jan's comment.
06/16/2008 reg (at) evolix (dot) fr Comment #12 Reply to this comment
Anyway, I turned it off and PAM auth stays buggy with the same error message.
Which one?
I can't login and I see this error message:

Warning: Error variable must be passed by reference in 
/usr/share/horde3/lib/Horde/Auth/pam.php on line 84

If I change "s/$error/&$error/", all is right.

06/16/2008 Jan Schneider Comment #11 Reply to this comment

Yes, I have "allow_call_time_pass_reference = On". It's the default
in Debian PHP packages. For Horde, this option must be turned off? If
yes, could you add to docs?
No, but Horde has to work with it off, since its the default and has
been the default in PHP for years, and will stop working at some
point in the future.
The problem is the extension code, which seems to expect the variable 
to be passed by reference. This is really old, buggy code.
06/15/2008 Chuck Hagenbuch Comment #10 Reply to this comment
Yes, I have "allow_call_time_pass_reference = On". It's the default
in Debian PHP packages. For Horde, this option must be turned off? If
yes, could you add to docs?
No, but Horde has to work with it off, since its the default and has 
been the default in PHP for years, and will stop working at some point 
in the future.
Anyway, I turned it off and PAM auth stays buggy with the same error message.
Which one?
06/15/2008 reg (at) evolix (dot) fr Comment #9 Reply to this comment
Do you have call_time_pass_by_referenced turned on in php.ini? This
feature/syntax has been deprecated and throwing warnings for years
and years now.
Yes, I have "allow_call_time_pass_reference = On". It's the default in 
Debian PHP packages. For Horde, this option must be turned off? If 
yes, could you add to docs?

Anyway, I turned it off and PAM auth stays buggy with the same error message.
06/15/2008 Chuck Hagenbuch Comment #8 Reply to this comment
Do you have call_time_pass_by_referenced turned on in php.ini? This 
feature/syntax has been deprecated and throwing warnings for years and 
years now.
06/15/2008 reg (at) evolix (dot) fr Comment #7 Reply to this comment
For the change "s/$error/&$error/", the reason is I can't login with "$error" and I have this error message when logging:

Warning: Error variable must be passed by reference in
/usr/share/horde3/lib/Horde/Auth/pam.php on line 84
With what PHP version?
I use PHP 5.2.6 (CGI binary from Debian unstable packages).
06/14/2008 Chuck Hagenbuch Comment #6 Reply to this comment
For the change "s/$error/&$error/", the reason is I can't login with "$error" and I have this error message when logging:

Warning: Error variable must be passed by reference in
/usr/share/horde3/lib/Horde/Auth/pam.php on line 84
With what PHP version?
06/14/2008 reg (at) evolix (dot) fr Comment #5 Reply to this comment
&$error in that call will cause a php notice. Otherwise looks ugly
but okay. I'd propose checking for the pam_auth function instead of
the extension, and trying to load either extension if it's not
already defined.
Here is the second proposition of my hack with function_exists():
http://gcolpart.evolix.net/debian/horde3/pam.php.2.diff

For the change "s/$error/&$error/", the reason is I can't login with "$error" and I have this error message when logging:

Warning: Error variable must be passed by reference in 
/usr/share/horde3/lib/Horde/Auth/pam.php on line 84


06/09/2008 Chuck Hagenbuch Comment #4 Reply to this comment
&$error in that call will cause a php notice. Otherwise looks ugly but 
okay. I'd propose checking for the pam_auth function instead of the 
extension, and trying to load either extension if it's not already 
defined.
06/08/2008 reg (at) evolix (dot) fr Comment #3 Reply to this comment
See this email thread:
http://lists.horde.org/archives/dev/Week-of-Mon-20080519/023017.html

Note that no one responded to me.
pam_auth and pam extensions are different softwares. pam_auth seems to 
be unmaintained (URL for pam_auth is now 404) but is always in Debian. 
I propose
you this patch (I will perhaps use it in Debian package):
http://gcolpart.evolix.net/debian/horde3/pam.php.diff

Regards,
--
Gregory Colpart
06/08/2008 Chuck Hagenbuch Comment #2
State ⇒ Feedback		 Reply to this comment
See this email thread:
http://lists.horde.org/archives/dev/Week-of-Mon-20080519/023017.html

Note that no one responded to me.
06/08/2008 reg (at) evolix (dot) fr Comment #1
Patch ⇒
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ No more support for "pam_auth" extension?
Type ⇒ Enhancement
Priority ⇒ 2. Medium
State ⇒ New		 Reply to this comment
Hello,

PAM authentification was rewriting to use "pam" instead of "pam_auth" 
extension.
It breaks upgrade path (I had only "pam_auth" extension and after 
upgrading I can't login to Horde...). Is it possible to support "pam" 
*and* "pam_auth" extensions?

Note: In Debian, we have only "pam_auth" extension for now and anyway, 
I will break Etch->Lenny upgrades.

Regards,
--
Gregory Colpart