[#6853] Protect against notifying email recipients twice or more
Summary Protect against notifying email recipients twice or more
Queue Whups
Type Enhancement
State Resolved
Priority 1. Low
Owners Chuck Hagenbuch <chuck (at) horde (dot) org>
Requester Thomas Jarosch <thomas (dot) jarosch (at) intra2net (dot) com>
Created 06/06/2008 (169 days ago)
Due
Updated 06/07/2008 (168 days ago)
Assigned
Resolved 06/07/2008 (168 days ago)
Attachments whups-notify-only-once.patch Download
Milestone
Patch No

History
06/07/2008 Chuck Hagenbuch Comment #3
State ⇒ Resolved
Assigned to Chuck Hagenbuch		 Reply to this comment
Committed, thanks!
06/07/2008 CVS Commit Comment #2 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/whups/lib/Driver.php?r1=1.189&r2=1.190&ty=u
06/06/2008 Chuck Hagenbuch State ⇒ Accepted
 
06/06/2008 Thomas Jarosch Comment #1
New Attachment: whups-notify-only-once.patch Download
Patch ⇒
Milestone ⇒
Queue ⇒ Whups
Summary ⇒ Protect against notifying email recipients twice or more
Type ⇒ Enhancement
Priority ⇒ 1. Low
State ⇒ New		 Reply to this comment
Hello together,

I've been receiving email notifies for #6837 twice for every comment. 
After some investigation it turned out I sometimes used my bugtracker 
account and sometimes my plain email address to reply to comments.

Attached patch protects against notifying the same email recipient twice.

I also fixed $full_name handling, which looked broken to me: 
$full_name gets updated -after- it has been used and used the 
"mailbox" instead of "personal" field of MIME::parseAddressList(). If 
we are unable to determine a full name, we fallback to the email 
address.

The code is untested as I don't have a whups/SQL database running over here,
so please be kind to syntax errors, if any :-)