Tickets :: [#6797] Turba: Adding a new addressbook

6.0.0-beta1

11/4/25

Summary	Turba: Adding a new addressbook
Queue	Kolab
Type	Bug
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	thomas.jarosch (at) intra2net (dot) com
Created	05/30/2008 (6367 days ago)
Due
Updated	06/13/2008 (6353 days ago)
Assigned	05/31/2008 (6366 days ago)
Resolved	06/13/2008 (6353 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

06/13/2008 08:46:15 AM	Jan Schneider	Comment #8 Taken from Chuck Hagenbuch State ⇒ Resolved	Reply to this comment
Committed.

06/13/2008 08:46:07 AM	CVS Commit	Comment #7	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/turba/lib/Turba.php?r1=1.163&r2=1.164&ty=u

06/06/2008 09:29:59 AM	Thomas Jarosch	Comment #6	Reply to this comment
Isn't it a bit odd that the client code requesting a new share also submits the id? No, because we want the default shares to have the user name as the id. Ok. lease apply the patch anyway, it's broken using Kolab.

06/03/2008 01:04:51 PM	Jan Schneider	Comment #5	Reply to this comment
Isn't it a bit odd that the client code requesting a new share also submits the id? No, because we want the default shares to have the user name as the id.

06/03/2008 12:34:52 PM	Thomas Jarosch	Comment #4	Reply to this comment
There are probably many places where we use the share id after creating a share, no? I took a quick look now at kronolith, nag and mnemo, they all do it right. Isn't it a bit odd that the client code requesting a new share also submits the id?

06/03/2008 10:14:19 AM	Jan Schneider	Comment #3	Reply to this comment
There are probably many places where we use the share id after creating a share, no?

06/03/2008 09:03:59 AM	Thomas Jarosch	Assigned to Chuck Hagenbuch Taken from Gunnar Wrobel Assigned to Jan Schneider Taken from Thomas Jarosch

06/03/2008 09:02:55 AM	Thomas Jarosch	Comment #2 New Attachment: turba-fix-add-Share.patch	Reply to this comment
I've found the source of the bug: $driver->createShare() get called with "md5(mt_rand())" for $share_id. The Kolab driver later updates the share id with the encoded folder name. Attached patch updates the share_id with the real id. Please see the attached patch.

05/31/2008 02:17:23 PM	Jan Schneider	Assigned to Gunnar Wrobel State ⇒ Assigned Assigned to Thomas Jarosch

05/30/2008 02:19:28 PM	Thomas Jarosch	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Turba: Adding a new addressbook Queue ⇒ Kolab Milestone ⇒ Patch ⇒ No State ⇒ Unconfirmed	Reply to this comment
Hello together, after upgrading to Turba HEAD, newly added addressbooks using the Kolab backend don't get automatically added to the addressbook list. Does this work for you, Gunnar? I took a quick look at the prefs saved on disc, the addressbook list array looks like it contains md5-hashes of the actual folder/share names??? Thomas