[#6793] DIMP should honor Horde's sidebar_width preference
Summary DIMP should honor Horde's sidebar_width preference
Queue DIMP
Queue Version 1.0
Type Enhancement
State Resolved
Priority 2. Medium
Owners Jan Schneider <jan (at) horde (dot) org>, Michael Slusarz <slusarz (at) horde (dot) org>
Requester rsalmon (at) mbpgroup (dot) com
Created 05/30/2008 (130 days ago)
Due
Updated 07/15/2008 (84 days ago)
Assigned
Resolved 07/15/2008 (84 days ago)
Attachments
Milestone 1.0.1
Patch No

History
07/15/2008 Michael Slusarz Comment #29
State ⇒ Resolved
Reply to this comment
IE6 handling has been fixed.
07/15/2008 CVS Commit Comment #28 Reply to this comment
07/15/2008 CVS Commit Comment #27 Reply to this comment
07/11/2008 Michael Slusarz Comment #26 Reply to this comment
How is that a problem? The user have the freedom to choose a width,
so if they want it huge, they have to deal with the consequences.
It's a problem because the width is dynamically adjusted in all other 
browsers.  IIRC the problem is that IE 6 doesn't support min-width so 
our workaround needs to be adjusted to take into account the 
sidebar_width value.
07/11/2008 Jan Schneider Comment #25 Reply to this comment
How is that a problem? The user have the freedom to choose a width, so 
if they want it huge, they have to deal with the consequences.
07/11/2008 Michael Slusarz Comment #24
State ⇒ Accepted
Reply to this comment
Still doesn't work properly on IE6.  Increasing the sidebar size above 
a certain point causes a horizontal scroll in the browser window.
07/11/2008 Jan Schneider Comment #23
State ⇒ Resolved
Reply to this comment
Looks fine in IE now too, resolving.
07/11/2008 CVS Commit Comment #22 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/dimp/themes/print.css?r1=1.23&r2=1.24&ty=u
06/18/2008 rsalmon (at) mbpgroup (dot) com Comment #21 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/dimp/themes/print.css?r1=1.21&r2=1.22&ty=u
works great here with firefox 2.0.0.14.
looks ok with firefox 3.0 as well.
06/17/2008 Jan Schneider Comment #20 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/dimp/themes/print.css?r1=1.21&r2=1.22&ty=u
works great here with firefox 2.0.0.14.
But not so good in IE, it seems. But the sidebar positioning is broken 
for me in IE anyway at the moment, so I'm not sure if this is related.
06/17/2008 rsalmon (at) mbpgroup (dot) com Comment #19 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/dimp/themes/print.css?r1=1.21&r2=1.22&ty=u
works great here with firefox 2.0.0.14.

06/17/2008 CVS Commit Comment #18 Reply to this comment
Changes have been made in CVS for this ticket:

http://cvs.horde.org/diff.php/dimp/themes/print.css?r1=1.21&r2=1.22&ty=u
06/16/2008 Michael Slusarz Comment #17 Reply to this comment
We can't dynamically set the size of dimpmain because this overwrites 
the value of 'left' set in print.css when we are printing the message 
- thus we get printed messages with a 'sidebar_width' amount of 
whitespace at the left of the printed message.

This is becoming more trouble than it is worth.  I think that we need 
to back this out.  Doing this via CSS just doesn't seem to be viable 
at the present time.

06/09/2008 rsalmon (at) mbpgroup (dot) com Comment #16 Reply to this comment
This still doesn't work properly.  IE7 contains a '#sidebarPanel li'
declaration that prevents overflow from causing horizontal scrolling
- this needs to be changed depending on the sidebar width.  And IE6
will automatically expand the sidebar for large folders, which causes
the sidebar to overlap the message list.
it works here with
- firefox 2.0.0.14 (win/linux)
- IE 6.0.2900.2180 on win XP
- IE 6.0.2800.1106 on win 2k

but it doesn't work with IE 6.0.3790.3959 on win2k3 SP2. In fact 
nothing works. Connecting to DIMP gives me a blank screen 
('Loading...'), and connecting to horde, I don't even get the side 
panel.

06/09/2008 Michael Slusarz Comment #15
Milestone ⇒ 1.0.1
Priority ⇒ 2. Medium
State ⇒ Accepted
Assigned to Jan Schneider
Reply to this comment
This still doesn't work properly.  IE7 contains a '#sidebarPanel li' 
declaration that prevents overflow from causing horizontal scrolling - 
this needs to be changed depending on the sidebar width.  And IE6 will 
automatically expand the sidebar for large folders, which causes the 
sidebar to overlap the message list.
06/06/2008 Jan Schneider Comment #14 Reply to this comment

We should also consider setting the width smaller then the user
preference. With Horde's sidebar, there are usually two icon columns
left of the folder names, due to the tree structure. This is 32
pixels of screen estate.
We can play with this but FYI, as it stands now the default width in
Horde (150) is *less* than the width in DIMP (160).
Well, I didn't measure the widths, but I noticed that there is much 
more space right of the folders in DIMP because of the two icon columns.
06/06/2008 CVS Commit Comment #13 Reply to this comment
06/06/2008 Michael Slusarz Comment #12
State ⇒ Resolved
Reply to this comment
tooltip not showing special chars properly, eg from the generated HTML code :
"Computer Associates" -> "Computer%20Associates"
"test้" -> "test%26AOk-"
Fixed.
06/06/2008 Michael Slusarz Comment #11 Reply to this comment
Why is the width set through JS and not through hardcoding the width:
style in index.inc per PHP? With the current implementation, the
sidebar "jumps" from the default width to the user-selected width.
Because I didn't think about this last night :)  Makes sense and have 
changed to do this.
We should also consider setting the width smaller then the user
preference. With Horde's sidebar, there are usually two icon columns
left of the folder names, due to the tree structure. This is 32
pixels of screen estate.
We can play with this but FYI, as it stands now the default width in 
Horde (150) is *less* than the width in DIMP (160).
06/06/2008 rsalmon (at) mbpgroup (dot) com Comment #10 Reply to this comment
I've fixed the tooltip/title for the folders (we were setting the
wrong attribute name) so now the full folder name will appear on a
mouseover.  I've gone ahead and added some code to honor Horde's
sidebar_width pref in DIMP by dynamically setting widths/positions of
various elements.  Please test with various browsers to make sure
this works properly.
tooltip not showing special chars properly, eg from the generated HTML code :
"Computer Associates" -> "Computer%20Associates"
"test้" -> "test%26AOk-"


06/06/2008 Jan Schneider Comment #9 Reply to this comment
Why is the width set through JS and not through hardcoding the width: 
style in index.inc per PHP? With the current implementation, the 
sidebar "jumps" from the default width to the user-selected width.
We should also consider setting the width smaller then the user 
preference. With Horde's sidebar, there are usually two icon columns 
left of the folder names, due to the tree structure. This is 32 pixels 
of screen estate.
06/06/2008 Michael Slusarz Comment #8
State ⇒ Accepted
Summary ⇒ DIMP should honor Horde's sidebar_width preference
Assigned to Michael Slusarz
Reply to this comment
I've fixed the tooltip/title for the folders (we were setting the 
wrong attribute name) so now the full folder name will appear on a 
mouseover.  I've gone ahead and added some code to honor Horde's 
sidebar_width pref in DIMP by dynamically setting widths/positions of 
various elements.  Please test with various browsers to make sure this 
works properly.
06/06/2008 CVS Commit Comment #7 Reply to this comment
06/05/2008 rsalmon (at) mbpgroup (dot) com Comment #6 Reply to this comment
Is it possible to allow the frame to be resize dynamically: removing
noresize="noresize" ?
This is not a frame, so no.
Is it possible to resize the div sidebarPanel (or is it an other 
element?) the same way as it is working for the div element 
previewPane (or may be it is splitBar) ?

#2 - I don't think we should be expanding the sidebar.  I think a
tooltip/mouseover title for long mailbox names should suffice.
And we would have to cut it off at some point anyway, otherwise users
are going to kill their screen layout if they have very long folder
names. A tooltip would great.
I don't think you should cut it off. If the user can't see the folder's full name in the sidebar and the tooltip doesn't show the
full name ether, then is there a point in having a tooltip?

The mouseover thing sounds good, but will it work when doing
drag&drop emails?
The tooltip *is* a mouseover effect, and no, it won't work while
dragging, if I'm not wrong.
Then I gess this easier way to solve this is to allow user to 
customize the size of their sidebar?

06/05/2008 Jan Schneider Comment #5 Reply to this comment
Is it possible to allow the frame to be resize dynamically: removing
noresize="noresize" ?
This is not a frame, so no.

#2 - I don't think we should be expanding the sidebar.  I think a
tooltip/mouseover title for long mailbox names should suffice.
And we would have to cut it off at some point anyway, otherwise users
are going to kill their screen layout if they have very long folder
names. A tooltip would great.
I don't think you should cut it off. If the user can't see the folder's full name in the sidebar and the tooltip doesn't show the
full name ether, then is there a point in having a tooltip?

The mouseover thing sounds good, but will it work when doing
drag&drop emails?
The tooltip *is* a mouseover effect, and no, it won't work while 
dragging, if I'm not wrong.
06/05/2008 rsalmon (at) mbpgroup (dot) com Comment #4 Reply to this comment

- DIMP sidebar uses the global pref sidebar_width?
DIMP's sidebar width is defined in CSS as opposed to Horde's sidebar
width which is the width of the frame.  It would require javascript
to dynamically change the size of the sidebar in DIMP.  Other devs:
do we want to use sidebar_width pref to do this?
I like the simplicity of this being a CSS rule, but it probably makes
sense to use the preference, for more consistency with the "normal"
Horde layout, and more flexibility to users' demands.
I agree that some users will want to customize the width of their  sidebar which makes sense when they use long folder names and if the 
depth of their folder tree is big, eg
folder a
+-- folder b
       +-- folder c
            +-- folder d
...

Is it possible to allow the frame to be resize dynamically: removing   
noresize="noresize" ?

- DIMP's sidebar auto increses its width (folders with long names or
big tree) instead of having a horizontal scroll bar at the bottom of
the sidebar ?
#1 - there should be no horizontal scrollbar in the sidebar - if the
folder is too large, the excess should run off the end of the sideabr
(overflow: hidden in CSS terms)
There isn't an horizontal scrollbar in the sidebar. I probably was  tired when I check that. Sorry.
#2 - I don't think we should be expanding the sidebar.  I think a
tooltip/mouseover title for long mailbox names should suffice.
And we would have to cut it off at some point anyway, otherwise users
are going to kill their screen layout if they have very long folder
names. A tooltip would great.
I don't think you should cut it off. If the user can't see the  folder's full name in the sidebar and the tooltip doesn't show the 
full name ether, then is there a point in having a tooltip?

The mouseover thing sounds good, but will it work when doing drag&drop emails?

06/04/2008 Jan Schneider Comment #3 Reply to this comment
- DIMP sidebar uses the global pref sidebar_width?
DIMP's sidebar width is defined in CSS as opposed to Horde's sidebar
width which is the width of the frame.  It would require javascript
to dynamically change the size of the sidebar in DIMP.  Other devs:
do we want to use sidebar_width pref to do this?
I like the simplicity of this being a CSS rule, but it probably makes 
sense to use the preference, for more consistency with the "normal" 
Horde layout, and more flexibility to users' demands.

- DIMP's sidebar auto increses its width (folders with long names or
big tree) instead of having a horizontal scroll bar at the bottom of
the sidebar ?
#1 - there should be no horizontal scrollbar in the sidebar - if the
folder is too large, the excess should run off the end of the sideabr
(overflow: hidden in CSS terms)
#2 - I don't think we should be expanding the sidebar.  I think a
tooltip/mouseover title for long mailbox names should suffice.
And we would have to cut it off at some point anyway, otherwise users 
are going to kill their screen layout if they have very long folder 
names. A tooltip would great.
06/04/2008 Michael Slusarz Comment #2
State ⇒ Feedback
Reply to this comment
- DIMP sidebar uses the global pref sidebar_width?
DIMP's sidebar width is defined in CSS as opposed to Horde's sidebar 
width which is the width of the frame.  It would require javascript to 
dynamically change the size of the sidebar in DIMP.  Other devs: do we 
want to use sidebar_width pref to do this?
- DIMP's sidebar auto increses its width (folders with long names or
big tree) instead of having a horizontal scroll bar at the bottom of
the sidebar ?
#1 - there should be no horizontal scrollbar in the sidebar - if the 
folder is too large, the excess should run off the end of the sideabr 
(overflow: hidden in CSS terms)
#2 - I don't think we should be expanding the sidebar.  I think a 
tooltip/mouseover title for long mailbox names should suffice.
05/30/2008 rsalmon (at) mbpgroup (dot) com Comment #1
Patch ⇒
Milestone ⇒
Queue ⇒ DIMP
Summary ⇒ sidebar_width
Type ⇒ Enhancement
Priority ⇒ 1. Low
State ⇒ New
Reply to this comment
Is it possible that either
- DIMP sidebar uses the global pref sidebar_width?
- DIMP's sidebar auto increses its width (folders with long names or 
big tree) instead of having a horizontal scroll bar at the bottom of 
the sidebar ?

thanks.