Tickets :: [#6760] Strange right-click behavior with FF on Mac

Summary	Strange right-click behavior with FF on Mac
Queue	DIMP
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	2. Medium
Owners	Michael Slusarz <slusarz (at) horde (dot) org>
Requester	Jan Schneider <jan (at) horde (dot) org>
Created	05/26/2008 (134 days ago)
Due
Updated	06/03/2008 (126 days ago)
Assigned	06/03/2008 (126 days ago)
Resolved	06/03/2008 (126 days ago)
Attachments
Milestone
Patch	No

06/03/2008	Michael Slusarz	Comment #8 Priority ⇒ 2. Medium State ⇒ Resolved Taken from Jan Schneider	Reply to this comment
Yes, I don't want to miss it, but it already works with right-click without Ctrl. Yeah - that makes sense. Made the fix to DIMP 1.0.1.

06/03/2008	CVS Commit	Comment #7	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/dimp/docs/CHANGES?r1=1.96&r2=1.97&ty=u http://cvs.horde.org/diff.php/dimp/js/DraggableMail.js?r1=1.66&r2=1.67&ty=u http://cvs.horde.org/diff.php/dimp/js/src/DraggableMail.js?r1=1.49&r2=1.50&ty=u

06/03/2008	Jan Schneider	Comment #6	Reply to this comment
[Hide Quoted Text] Was this a typo? Because if Macs really send Ctrl-RightClick, then we can safely catch this, we don't use that combination anywhere, only Ctrl-LeftClick as outlined below. Nope, not a typo. Ctrl-right click should select a message without showing the preview - this was specifically coded due to feedback from users at SAPO. This allows people to delete messages that they know are SPAM without causing the preview to trigger. It is very useful. Yes, I don't want to miss it, but it already works with right-click without Ctrl.

06/03/2008	Michael Slusarz	Comment #5	Reply to this comment
Was this a typo? Because if Macs really send Ctrl-RightClick, then we can safely catch this, we don't use that combination anywhere, only Ctrl-LeftClick as outlined below. Nope, not a typo. Ctrl-right click should select a message without showing the preview - this was specifically coded due to feedback from users at SAPO. This allows people to delete messages that they know are SPAM without causing the preview to trigger. It is very useful.

06/03/2008	Jan Schneider	Comment #4	Reply to this comment
And the obvious reason why clicks are different - Macs don't have right buttons. So any Mac right button emulation sends a 'ctrl-right click' on a mousedown event. This is causing toggling of the selection of that message because that is the expected behavior for a ctrl-click on a message. Was this a typo? Because if Macs really send Ctrl-RightClick, then we can safely catch this, we don't use that combination anywhere, only Ctrl-LeftClick as outlined below. We can add an extra check to only do ctrl-click processing of a message on a left click. That will fix this problem but at the expense of disallowing multiple ctrl-click on other platforms - this can be quite useful because it allows multiple selection without worrying that a preview will be triggered. Suggestions?

06/03/2008	Michael Slusarz	Comment #3 State ⇒ Feedback	Reply to this comment
And the obvious reason why clicks are different - Macs don't have right buttons. So any Mac right button emulation sends a 'ctrl-right click' on a mousedown event. This is causing toggling of the selection of that message because that is the expected behavior for a ctrl-click on a message. We can add an extra check to only do ctrl-click processing of a message on a left click. That will fix this problem but at the expense of disallowing multiple ctrl-click on other platforms - this can be quite useful because it allows multiple selection without worrying that a preview will be triggered. Suggestions?

06/03/2008	Michael Slusarz	Comment #2	Reply to this comment
Doesn't surprise me. From experience, FF on Mac does not handle click events like other versions of FF (Linux/Windows).

05/26/2008	Jan Schneider	Comment #1 Patch ⇒ Milestone ⇒ Assigned to Michael Slusarz Assigned to Jan Schneider Queue ⇒ DIMP Summary ⇒ Strange right-click behavior with FF on Mac Type ⇒ Bug Priority ⇒ 1. Low State ⇒ Assigned	Reply to this comment
With Firefox on Mac, if you select a message in the message list, and then right-click on that message, it gets unselected and thus the context menu items don't do anything.