Tickets :: [#6669] MySQL syntax error in Group SQL driver

6.0.0-beta1

11/8/25

Summary	MySQL syntax error in Group SQL driver
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	vilius (at) lnk (dot) lt
Created	05/01/2008 (6400 days ago)
Due
Updated	05/01/2008 (6400 days ago)
Assigned
Resolved	05/01/2008 (6400 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

05/01/2008 09:14:28 PM	Michael Rubinsky	Comment #7	Reply to this comment
oops. Forgot to take that out. Thanks!

05/01/2008 09:12:08 PM	vilius (at) lnk (dot) lt	Comment #6	Reply to this comment
Correct me if I'm wrong, but AFAIK binding automatically takes care of value quoting, so there is no need for $parents[] = $this->_db->quote($name);

05/01/2008 09:00:36 PM	Michael Rubinsky	Assigned to Michael Rubinsky

05/01/2008 08:59:44 PM	Michael Rubinsky	Comment #5 State ⇒ Resolved	Reply to this comment
Fixed using bind parameters, and merged. Thanks for the testing!

05/01/2008 08:34:54 PM	Chuck Hagenbuch	Comment #4	Reply to this comment
Nope, no reason

05/01/2008 07:57:09 PM	Michael Rubinsky	Comment #3	Reply to this comment
Is there any reason not to use bind parameters here?

05/01/2008 07:48:59 PM	vilius (at) lnk (dot) lt	Comment #2 New Attachment: sql.php.patch	Reply to this comment
Possible patch.

05/01/2008 07:43:26 PM	vilius (at) lnk (dot) lt	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ MySQL syntax error in Group SQL driver Queue ⇒ Horde Framework Packages Milestone ⇒ Patch ⇒ No State ⇒ Unconfirmed	Reply to this comment
This commit http://cvs.horde.org/diff.php?r1=1.1&r2=1.2&f=framework%2FGroup%2FGroup%2Fsql.php brakes in cases where there is only one parent group. This group will be double singlequoted, e.g.: DB Error: syntax error: SELECT group_uid, group_name FROM horde_groups WHERE group_name IN (''Technikai'')