6.0.0-beta1
8/14/25

[#6586] Kolab Share driver: Bogus if call
Summary Kolab Share driver: Bogus if call
Queue Kolab
Type Bug
State Resolved
Priority 1. Low
Owners wrobel (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 04/09/2008 (6336 days ago)
Due
Updated 04/24/2008 (6321 days ago)
Assigned 04/09/2008 (6336 days ago)
Resolved 04/24/2008 (6321 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
04/24/2008 04:36:30 PM Gunnar Wrobel Comment #4
Summary ⇒ Kolab Share driver: Bogus if call
State ⇒ Resolved
Reply to this comment
In CVS, thanks.
04/23/2008 02:17:12 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #3
New Attachment: framework-Kolab-remove-bogus-if.patch Download
Reply to this comment
Hello Gunnar,



I've found and fixed the root problem, the Share code is fine, will 
open a second ticket for that. Anyway, while looking at the code it 
seems like there is a bogus if statement in there. Please have a look 
at the attached patch.



Thomas


04/21/2008 04:13:08 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #2 Reply to this comment
Gunnar,



as far as I can see there is no code to handle the attributes 
(->comment) in Horde/Share/kolab.php::_addShare(). Is there a reason 
for this? Do you see any problems if we add it there like we already 
do in ::_save()?



Thomas


04/09/2008 05:05:35 PM Jan Schneider State ⇒ Assigned
Assigned to Gunnar Wrobel
 
04/09/2008 03:52:42 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Share driver: Loss of folder comment
Queue ⇒ Kolab
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
Hello together,



when I create a new addressbook in Turba and enter a comment, that 
comment is lost when the share is created. If I later modify/add a 
comment, the comment is saved as expected. Guess it's something in 
Kolab's Share driver.



Cheers,

Thomas


Saved Queries