Alright. I finally see what your referring to, I think.  I still don't 
see where you would get an error  "pop-up in a new window".   
getImages() was just returning a PEAR_Error - and that error was only 
being logged to the horde log...that's it.



Your point is valid though about returning an error when image count 
== 0, but I have fixed it somewhat differently.  IMO, a getImages() 
method shouldn't care at all, or even have to know about, any 
subgalleries. I changed the method to return an empty array() in that 
case which makes more sense to me.  I also changed the if-clause in 
getChildren() to only call getImages() if we actually have any images. 
This will save an additional database query for each page since we 
already load the image count when we instantiate the gallery object.



http://lists.horde.org/archives/cvs/Week-of-Mon-20080407/077308.html



Thanks for the report.

yes
I'm using the default settings when I add a gallery. the error

occurs when I view the main gallery. e.g.:

http://www.humbapa.ch/horde/ansel/view.php?view=Gallery&gallery=2

(the PEAR-error should popup in a new window)
getChildren() only calls getImages() if there is room for some more 
images. so, if there is room (e.g. only 1 subgallery) getImages() 
returns "Photos not found" if there aren't any more photos. this error 
message is correct, but from my view it doesn't make much sense to 
raise an error if there are subgalleries with photos. maybe one could 
log that with PEAR_NOTICE...

Are you sure you are using the latest CVS code?  I cannot reproduce 
this. Just about *all* of my top-level galleries contain nothing but 
sub-galleries.  If you are running latest CVS, please give a detailed 
description of how to reproduce (what gallery style you are using, 
what exact page the error is thrown on etc...)



The image tiles in the gallery views are actually obtained via 
Ansel_Gallery::getChildren() - which (should) take into account any 
subgalleries before it calls getImages().

I have some galleries without images but with subgalleries. every time 
I view such a gallery I got an errormessage saying "Photos not found".



the methode getImages in lib/Ansel.php checks if there are any images 
inside a gallery an returns "PEAR::raiseError(_("Photos not found"));" 
for 0 images. my small patch changes that behaviour so that the error 
only occurs for 0 images and no subgalleries.



thanks!