| Summary | admin/setup/config.php doesn't trap invalid applicatione |
| Queue | Horde Base |
| Queue Version | HEAD |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | chuck (at) horde (dot) org |
| Requester | php (at) ideacode (dot) com |
| Created | 04/02/2008 (6303 days ago) |
| Due | |
| Updated | 04/03/2008 (6302 days ago) |
| Assigned | |
| Resolved | 04/03/2008 (6302 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
Assigned to Chuck Hagenbuch
Summary ⇒ admin/setup/config.php doesn't trap invalid applicatione
State ⇒ Resolved
Fatal error: Cannot use object of type stdClass as array in
/var/www/dev.horde.org/horde/whups/lib/Driver.php on line 393
Fatal error: Cannot use object of type stdClass as array in
/var/www/dev.horde.org/horde/whups/lib/Driver.php on line 393
Fatal error: Cannot use object of type stdClass as array in
/var/www/dev.horde.org/horde/whups/lib/Driver.php on line 393
New Attachment: issue.diff
the ticket went in. Retrying to send patch.
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ admin/setup/config.php doesn't trap invalid application
Queue ⇒ Horde Base
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
$app = Util::getFormData('app');
$appname = $registry->get('name', $app);
$title = sprintf(_("%s Setup"), $appname);
if ($app === null &&
in_array($app, $registry->listApps(array('inactive', 'hidden',
'notoolbar', 'active', 'admin')))) {
$notification->push(_("Invalid application."), 'horde.error');
$url = Horde::applicationUrl('admin/setup/index.php', true);
header('Location: ' . $url);
exit;
}
The logic doesn't capture invalid applications correctly: the logic
says throw an invalid application error when not given an app and
"null" is a listed application. In the field, if you manually alter
the app GET line variable to something non-existent, you get the horde
application setup, instead of the invalid application error.
I believe the logic should be throw an invalid application error when
not given an app or the app is not a listed application. Patch
attached.