Tickets :: [#6500] hasSubGallery

6.0.0-alpha14

7/2/25

Summary	hasSubGallery
Queue	Ansel
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	duck (at) obala (dot) net
Created	03/19/2008 (6314 days ago)
Due
Updated	03/19/2008 (6314 days ago)
Assigned	03/19/2008 (6314 days ago)
Resolved	03/19/2008 (6314 days ago)
Milestone
Patch	No

03/19/2008 03:05:41 PM	Michael Rubinsky	Comment #7	Reply to this comment
Since the galley attribute is has_subgalleries I changed it to match more closely. Plus, the way I had originally named these type of methods was with "children" so I wanted to kind of stay close to that semantically :)

03/19/2008 02:51:21 PM	Chuck Hagenbuch	Comment #6	Reply to this comment
Committed, but changed hasSubGallery() to hasSubGalleries() Not a huge deal - but why? Seems like you want to return true if the singular or plural is true, not just the plural. :)

03/19/2008 02:49:24 PM	Michael Rubinsky	Comment #5 State ⇒ Resolved	Reply to this comment
Committed, but changed hasSubGallery() to hasSubGalleries() Thanks!

03/19/2008 02:30:25 PM	Michael Rubinsky	Assigned to Michael Rubinsky State ⇒ Assigned

03/19/2008 02:30:01 PM	Michael Rubinsky	Comment #4	Reply to this comment
Doh. I reversed the order of the files in my compare tool :) Sorry - and thanks!

03/19/2008 02:28:23 PM	Duck	Comment #3	Reply to this comment
? The patch adds them. There is no sub-gallery check in *stack

03/19/2008 02:25:53 PM	Michael Rubinsky	Comment #2 State ⇒ Feedback	Reply to this comment
Why are you removing the conditional check for $gallery->hasSubGallery() in places like in the various *stack.php classes? Wouldn't that prevent an unnecessary call to Ansel_Storage::listGalleries() with it's larger SELECT along with avoiding the (admittedly small amount) of extra code in that if block?

03/19/2008 10:09:24 AM	Duck	Comment #1 State ⇒ New New Attachment: ansel-sub.diff Patch ⇒ No Milestone ⇒ Queue ⇒ Ansel Summary ⇒ hasSubGallery Type ⇒ Enhancement Priority ⇒ 1. Low	Reply to this comment
- Remove Ansel_Gallery::hasChildren - is used only in gallery delete page and hasSubGalleries does the same, but has cashed values. - We don't need to cache the hasChildren data in Shares as this data is retreived only when a gallery is removed and in the update script. - Some more places to get check of sub-galleries.