| Summary | Fail to update vacation msg (using sql driver) |
| Queue | Vacation |
| Queue Version | 3.0.1 |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | Chuck Hagenbuch <chuck (at) horde (dot) org> |
| Requester | pola (at) sol (dot) info (dot) unlp (dot) edu (dot) ar |
| Created | 03/18/2008 (54 days ago) |
| Due | 03/18/2008 (54 days ago) |
| Updated | 04/25/2008 (16 days ago) |
| Assigned | 04/23/2008 (18 days ago) |
| Resolved | 04/25/2008 (16 days ago) |
| Attachments | |
| Milestone | |
| Patch |
State ⇒ Resolved
Assigned to Chuck Hagenbuch
Excellent, thanks for the feedback.The patch worked flawlessly, using crypt algorithm.
Thank you very much.
Best regards...
> Please test this commit:
> http://lists.horde.org/archives/cvs/Week-of-Mon-20080421/077738.html
Please test this commit:http://lists.horde.org/archives/cvs/Week-of-Mon-20080421/077738.html
> If it's not for some reason, we could also make it work by fetching
> the current password value and passing it in to
> Auth::getCryptedPassword as the seed.
That seems a better solution, my fix was a fast and dirty hack.
Best regards.
State ⇒ Feedback
It looks like that code has been there from the beginning of this driver; I have to say I'm not sure why the password would be used that way (trying to support multiple people with the same email address? I doubt that works...), so removing the password checks seems like a legit option to me.
If it's not for some reason, we could also make it work by fetching the current password value and passing it in to Auth::getCryptedPassword as the seed.
Anyone know anything about this driver or have an opinion here?
Patch ⇒
Milestone ⇒
Queue ⇒ Vacation
Due ⇒ 03/18/2008
Summary ⇒ Fail to update vacation msg (using sql driver)
Type ⇒ Bug
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Vacation fails to update vacation msg using sql driver and crypt as encryption method, thats because the salt used to generate the crypted passwd for the query (WHERE part) does not match the salt in the crypted passwd in the database.
A possible solution should be to remove this lines
' AND ' . $this->_params[$realm]['pass_col'] . ' = ?';
(lines 89, 107, 147, 189)
from the sql query and just use the user email as the primary search key.
Best regards