Tickets :: [#6495] Recent images

6.0.0-beta1

7/21/25

Summary	Recent images
Queue	Ansel
Type	Enhancement
State	Rejected
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	duck (at) obala (dot) net
Created	03/18/2008 (6334 days ago)
Due
Updated	03/20/2008 (6332 days ago)
Assigned
Resolved	03/19/2008 (6333 days ago)
Milestone
Patch	No

03/20/2008 02:00:42 PM	Michael Rubinsky	Comment #4	Reply to this comment
This is not true. Your patch totally ignores permissions. Perms could be checked directly in the driver as soon as we move away from DT. Sure. But your patch just performs a SELECT statement against the gallery table with no filter...returning all galleries....and the permissions are checked in the storage driver - by filtering in Ansel_Storage::listGalleries()

03/19/2008 07:19:30 PM	Duck	Comment #3	Reply to this comment
This is not true. Your patch totally ignores permissions. Perms could be checked directly in the driver as soon as we move away from DT.

03/19/2008 03:32:40 PM	Michael Rubinsky	State ⇒ Rejected

03/18/2008 02:56:52 PM	Michael Rubinsky	Comment #2 State ⇒ Feedback Assigned to Michael Rubinsky	Reply to this comment
This is not true. Your patch totally ignores permissions. We get the gallery list via listGalleries() so we ensure the user has permissions to see the gallery. I do agree about the issue regarding listing all galleries in a drop down, but am unable to come up with a good alternative. Ideas are welcome.

03/18/2008 01:25:01 PM	Duck	Comment #1 Priority ⇒ 1. Low New Attachment: recent.diff Patch ⇒ No Milestone ⇒ Summary ⇒ Recent images Type ⇒ Enhancement State ⇒ New Queue ⇒ Ansel	Reply to this comment
Is really no-sense to get all ids to select all galleries as it the same if we do no comparison at all. And listing thousand of galleries to just select them is a "suicide" - like in all block where we create drop-downs to allow user to select which gallery to display. I had 75k galleries. I really cannot imagine such a drop-down list.