| Summary | Font and Font Size choices for Xinha editor |
| Queue | IMP |
| Queue Version | HEAD |
| Type | Enhancement |
| State | Rejected |
| Priority | 1. Low |
| Owners | |
| Requester | dimante (at) dimante (dot) net |
| Created | 03/17/2008 (6357 days ago) |
| Due | |
| Updated | 03/30/2009 (5979 days ago) |
| Assigned | |
| Resolved | 03/30/2009 (5979 days ago) |
| Milestone | |
| Patch | No |
State ⇒ Rejected
I should look to add this. I am still new to the backend of IMP. Any
pointers?
-D-
into the message. Any suggestions?
-D-
placing a body tag with the class directive for font and size?
hints on where I can find the parts that you speak of. Would this be
compose.php?
P.S. Thanks for taking the time to answer the many questions. I know
you guys are very busy.
-D-
placing a body tag with the class directive for font and size?
code so that we create a complete HTML document when sending HTML
messages. At the moment we only send HTML snippets. This HTML
document could contain a font style for the body.
placing a body tag with the class directive for font and size?
code so that we create a complete HTML document when sending HTML
messages. At the moment we only send HTML snippets. This HTML document
could contain a font style for the body.
at once. Much easier than creating a ZIP file each time.
ability to choose the font that you see in the editor, even if it does
not show on the recipients side would still be a good enhancement. I
do see that when I send messages to Outlook and other popular clients
that the fonts do stay in tact with the latest changes I uploaded.
Can you think of another way to keep the tag from getting cleaned by
horde?
-D-
is the best to provide this functionality.
class="imp-signature">' is allowed.. I am not sure how to add a
class .imp-font and provide it that way... I am assuming that '<span
class="imp-font">' may make it by the filter. Where would I go to
add that class?
this class. That's why we use the imp-signature class; it's only
rendered in IMP's compose screen.
Btw, it's possible to create patches that covers all modified files at
once. Much easier than creating a ZIP file each time.
New Attachment: impchanges3.zip
is the best to provide this functionality. If there is a way to get
that HTML cleaner to allow the span style command that would be good.
In Netscape the span work perfect. It's Internet explorer where horde
is involved the class gets scrubbed. If not I see that '<p
class="imp-signature">' is allowed.. I am not sure how to add a class
.imp-font and provide it that way... I am assuming that '<span
class="imp-font">' may make it by the filter. Where would I go to add
that class?
-D-
filter. This filters out some tags and attributes depending on the
browser version.
filter. This filters out some tags and attributes depending on the
browser version.
more consistently in Firefox but in IE7 I get:
XSSCleaned="font-family: impact;" This seems like a Horde behavior to
me.. I know IE7 does not provide this protection. So the bottom line
is I have figured out a way to get the font to display in the editor
in a chosen font and with the span tag the entire body of the message
is sent and received in the drafted font in Firefox. Not sure why the
XSSCleaned="font-family: impact;" does not work in firefox. If you
can elaborate on this I would appreciate it. I think the ability to
select the font would be a nice addition.
Thanks,
-D-
New Attachment: impchanges[1].zip
signature. I need a little help on applying it when they don't
thoughts?
Thanks
-D-
P.S. I have attached the files in the requested format in a zip file.
Thanks that will help greatly.
Jan,
I will download the latest head and I have not given up on this. I
have the editor displaying a chosen font. I just need to get that
into the <p> </p> tag in the textarea. I am reading more about
Xinha and I am going to see this through 8)
-D-
not see that before. What are the steps to create a unified diff? I
will look into this further and see if the font can carry with the
message... But if I don't know how to diff it to you I guess it won't
matter much.
-D-
upload them as attachments to this ticket.
But your patch doesn't work anyway. Unless I'm missing somthing, it's
only setting the default font for the display when composing a
message. This font should never get sent with the actual message though.
495a493,523
If this is not what is desired if you can let me know how to prepare
it I will do what is needed.
-D-
199c199,202
< $params['config']['pageStyle'] =
'body{font-size:75%;}.imp-signature{background-color: #eee;}';
---
'body{font-family:' .($GLOBALS['prefs']->getValue('XinFont')). ';
font-size:' .($GLOBALS['prefs']->getValue('XinFontSize')).
';}.imp-signature{background-color: #eee;}';
I have no idea how to do that :-(
-D-
State ⇒ Feedback
Priority ⇒ 1. Low
Priority ⇒ 2. Medium
State ⇒ New
New Attachment: impchanges.zip
Patch ⇒ No
Milestone ⇒
Queue ⇒ IMP
Summary ⇒ Font and Font Size choices for Xinha editor
Type ⇒ Enhancement
editor can now be
set in the compose options menu. I tried to send the mods through the
list but they
were too long for the post. Do you think this can be added to the
project? I have
tested in IE, Mozilla, and Safari and it seems to work for all.