A post_spam hook is a more general way to implement this request.

Changes have been made in Git for this ticket:

Bug #6455: Add post_spam hook
Partial revert of 2061e1638f4f8e98eebc43c220ec3c3a152eb44d

Previous applied code was not the subject of the ticket.  Cleanest to
provide a post_spam hook and have the admin perform the necessary
actions.

Provide the copy-to-mailbox scenario as the hook example.

http://git.horde.org/diff.php/imp/config/hooks.php.dist?rt=horde-git&r1=6095c30cc046404079b8ce1699a7d99ecc37f180&r2=4f599be8fe37e6ac0926dd003b7d12dffea44074
http://git.horde.org/diff.php/imp/config/prefs.php.dist?rt=horde-git&r1=82bccce8fadb4691aafcf803bee94164da573408&r2=4f599be8fe37e6ac0926dd003b7d12dffea44074
http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=01be6c1a9ea3abfffc6b55a02bfd7fde109c00d7&r2=4f599be8fe37e6ac0926dd003b7d12dffea44074
http://git.horde.org/diff.php/imp/lib/Message.php?rt=horde-git&r1=fe62dea49cb7c0ffef71467d4215ae915fcd131b&r2=4f599be8fe37e6ac0926dd003b7d12dffea44074
http://git.horde.org/diff.php/imp/lib/Prefs/Ui.php?rt=horde-git&r1=82bccce8fadb4691aafcf803bee94164da573408&r2=4f599be8fe37e6ac0926dd003b7d12dffea44074
http://git.horde.org/diff.php/imp/lib/Spam.php?rt=horde-git&r1=1121fb4fdde21774156cca072cbce4f6aac49313&r2=4f599be8fe37e6ac0926dd003b7d12dffea44074

This isn't what was requested, at least as I understood (and would use 
it). What I want is to have the report spam button copy messages to a 
specific folder (I use a shared IMAP folder for spam - and one for 
ham, also, so the same option for "not spam").

Added to IMP 5.0.

Changes have been made in Git for this ticket:

Request #6455: Spam reporting on mailbox move.
Add preference to allow for automatic spam reporting when explicitly
moving messages to the Spam mailbox.

http://git.horde.org/diff.php/imp/config/prefs.php.dist?rt=horde-git&r1=d0bbaeaa3bc69088ae5be2cf166ebf44637aad63&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d
http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=73d6cbe80185537f3845952d00e351a4a1b26b03&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d
http://git.horde.org/diff.php/imp/lib/Api.php?rt=horde-git&r1=5d365dac5c0677af0dba884864092918c12c7245&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d
http://git.horde.org/diff.php/imp/lib/Message.php?rt=horde-git&r1=a0ce9ace9c3114b59d4926dd43c89cd19f4794c4&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d
http://git.horde.org/diff.php/imp/lib/Prefs/Ui.php?rt=horde-git&r1=1cecd5d8a0a787eeedf60a26ce38d960bb3e06cd&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d
http://git.horde.org/diff.php/imp/lib/Spam.php?rt=horde-git&r1=a0ce9ace9c3114b59d4926dd43c89cd19f4794c4&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d
http://git.horde.org/diff.php/imp/mailbox.php?rt=horde-git&r1=9d177a34d6758515efe8b79121ce95bae0174d7f&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d
http://git.horde.org/diff.php/imp/message.php?rt=horde-git&r1=428c80cce1acba5b78156e0fe904cbe2ca2600b3&r2=2061e1638f4f8e98eebc43c220ec3c3a152eb44d

That patch is something, but it includes other local changes, things 
that are specific to your setup, and as you pointed out is against an 
old version. The ticket is still accepted - if you can clean it up and 
update it for git, all the better.



Thanks!

Okay - but this patch is against an old version (webmail groupware 
edition 1.1?) and it has our own spam flag header ("HY" stands for 
Univ. of Helsinki) hardcoded though it should probably be configurable.



Anyway, you see the idea.

Sure - this is marked accepted. If you have a patch for it, even 
better - please submit it! That might speed things up tremendouslyl

Furthermore, it's totally irrelevant for users which way their emails 
are being transferred to a spam detector. For us as admins, it's 
relevant to provide them a comfortable way for reporting emails. 
"Report as spam/innocent" works and is on production. In our setup, it 
saves messages to a dedicated global IMAP folder not visible to our 
users.



All I want is to get rid of local patches and relevant functionality, 
such as this, included in the upstream code. Any hope?

Not quite, actually - there's no keyboard shortcut for moving a 
message, and you have to select the folder each time. I'd use this also.

Because it's as easy to move the message to the spam folder.

It would be nice to be able to report spam/not spam messages by saving 
them to an IMAP folder.



It seems it only needs a very small patch to lib/Spam.php and a config 
option to conf.xml (if we assume one global imap folder with "insert" 
permission to "anyone" is enough).



We already have these "email", "bounce" and "program" reporting 
options. Why wouldn't we have something like this:



      <configstring name="imapsave" required="false" desc="Should we 
report the spam

      message by copying it to a IMAP folder."/>



I have a reference implementation if someone's intrested.