Tickets :: [#6403] Halve Kolab's Freebusy memory usage

6.0.0-beta1

7/5/25

Summary	Halve Kolab's Freebusy memory usage
Queue	Kolab
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	wrobel (at) horde (dot) org
Requester	thomas.jarosch (at) intra2net (dot) com
Created	03/08/2008 (6328 days ago)
Due
Updated	03/11/2008 (6325 days ago)
Assigned	03/08/2008 (6328 days ago)
Resolved	03/11/2008 (6325 days ago)
Milestone
Patch	No

03/11/2008 05:05:09 PM	Gunnar Wrobel	Comment #6 State ⇒ Resolved	Reply to this comment
in cvs

03/11/2008 05:04:56 PM	Gunnar Wrobel	Comment #5	Reply to this comment
I didn't trace this stuff before so now that I looked at it I'd like to suggest the attached patch in addition to your fix. Can you check it on your side? Wow, I first thought your change wouldn't make much difference but now it takes only 0.983s instead of 2.340s for 10.000 events on a P4 3 GHz :-) Yeah. Cool, thanks for testing. Closing this one then.

03/11/2008 03:32:23 PM	thomas (dot) jarosch (at) intra2net (dot) com	Comment #4	Reply to this comment
I didn't trace this stuff before so now that I looked at it I'd like to suggest the attached patch in addition to your fix. Can you check it on your side? Wow, I first thought your change wouldn't make much difference but now it takes only 0.983s instead of 2.340s for 10.000 events on a P4 3 GHz :-) Yeah.

03/11/2008 10:42:15 AM	Gunnar Wrobel	State ⇒ Feedback

03/11/2008 10:23:33 AM	Gunnar Wrobel	Comment #3 New Attachment: HK-GW-freebusy_improve.patch	Reply to this comment
Hello together, attached patch almost halves Kolab's freebusy memory usage. 10.000 events now use 25mb instead of 44mb. Makes sense. Thanks! In CVS. I didn't trace this stuff before so now that I looked at it I'd like to suggest the attached patch in addition to your fix. Can you check it on your side? There is probably more potential to get the thing less memory/cpu time hungry. [Show Quoted Text - 15 lines][Hide Quoted Text] I also experimented with splitting "$objects = store->getObjects()" into "$ids = store->getObjectIds(); foreach($object = store->getObjectById())" but it turned out to be slower and PHP5 seems to implement copy-on-write as it didn't make a difference from a memory usage point of view. I did some whitespace cleanup while I was at it... Cheers, Thomas PS: I almost queued this one for the framework package again ;-)

03/08/2008 12:13:19 PM	Jan Schneider	Comment #2 Assigned to Gunnar Wrobel State ⇒ Assigned	Reply to this comment
This could probably be further optimized not using a foreach loop at all: http://www.horde.org/horde/docs/?f=CODING_STANDARDS.html#loops

03/08/2008 09:28:34 AM	thomas (dot) jarosch (at) intra2net (dot) com	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Halve Kolab's Freebusy memory usage Queue ⇒ Kolab New Attachment: framework-kolab-fix-freebusy-memusage.patch State ⇒ New	Reply to this comment
Hello together, attached patch almost halves Kolab's freebusy memory usage. 10.000 events now use 25mb instead of 44mb. I also experimented with splitting "$objects = store->getObjects()" into "$ids = store->getObjectIds(); foreach($object = store->getObjectById())" but it turned out to be slower and PHP5 seems to implement copy-on-write as it didn't make a difference from a memory usage point of view. I did some whitespace cleanup while I was at it... Cheers, Thomas PS: I almost queued this one for the framework package again ;-)