Tickets :: [#6403] Halve Kolab's Freebusy memory usage

6.0.0-RC7

6/18/26

History
Attachments
Comment
Watch
Download

Summary	Halve Kolab's Freebusy memory usage
Queue	Kolab
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	wrobel (at) horde (dot) org
Requester	thomas.jarosch (at) intra2net (dot) com
Created	3/8/08 (6676 days ago)
Due
Updated	3/11/08 (6673 days ago)
Assigned	3/8/08 (6676 days ago)
Resolved	3/11/08 (6673 days ago)
Milestone
Patch	No

95	Gunnar Wrobel	Comment #6 State ⇒ Resolved	Reply to this comment
in cvs

565	Gunnar Wrobel	Comment #5	Reply to this comment
I didn't trace this stuff before so now that I looked at it I'd like to suggest the attached patch in addition to your fix. Can you check it on your side? Wow, I first thought your change wouldn't make much difference but now it takes only 0.983s instead of 2.340s for 10.000 events on a P4 3 GHz :-) Yeah. Cool, thanks for testing. Closing this one then.

233	thomas (dot) jarosch (at) intra2net (dot) com	Comment #4	Reply to this comment
I didn't trace this stuff before so now that I looked at it I'd like to suggest the attached patch in addition to your fix. Can you check it on your side? Wow, I first thought your change wouldn't make much difference but now it takes only 0.983s instead of 2.340s for 10.000 events on a P4 3 GHz :-) Yeah.

1510	Gunnar Wrobel	State ⇒ Feedback

3310	Gunnar Wrobel	Comment #3 New Attachment: HK-GW-freebusy_improve.patch	Reply to this comment
Hello together, attached patch almost halves Kolab's freebusy memory usage. 10.000 events now use 25mb instead of 44mb. Makes sense. Thanks! In CVS. I didn't trace this stuff before so now that I looked at it I'd like to suggest the attached patch in addition to your fix. Can you check it on your side? There is probably more potential to get the thing less memory/cpu time hungry. [Show Quoted Text - 15 lines][Hide Quoted Text] I also experimented with splitting "$objects = store->getObjects()" into "$ids = store->getObjectIds(); foreach($object = store->getObjectById())" but it turned out to be slower and PHP5 seems to implement copy-on-write as it didn't make a difference from a memory usage point of view. I did some whitespace cleanup while I was at it... Cheers, Thomas PS: I almost queued this one for the framework package again ;-)

1912	Jan Schneider	Comment #2 Assigned to Gunnar Wrobel State ⇒ Assigned	Reply to this comment
This could probably be further optimized not using a foreach loop at all: http://www.horde.org/horde/docs/?f=CODING_STANDARDS.html#loops

349	thomas (dot) jarosch (at) intra2net (dot) com	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Halve Kolab's Freebusy memory usage Queue ⇒ Kolab New Attachment: framework-kolab-fix-freebusy-memusage.patch State ⇒ New	Reply to this comment
Hello together, attached patch almost halves Kolab's freebusy memory usage. 10.000 events now use 25mb instead of 44mb. I also experimented with splitting "$objects = store->getObjects()" into "$ids = store->getObjectIds(); foreach($object = store->getObjectById())" but it turned out to be slower and PHP5 seems to implement copy-on-write as it didn't make a difference from a memory usage point of view. I did some whitespace cleanup while I was at it... Cheers, Thomas PS: I almost queued this one for the framework package again ;-)