6.0.0-alpha12
6/10/25

[#6394] Freebusy.php: Fix wrong return value
Summary Freebusy.php: Fix wrong return value
Queue Kolab
Type Bug
State Resolved
Priority 1. Low
Owners wrobel (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 03/07/2008 (6304 days ago)
Due
Updated 03/11/2008 (6300 days ago)
Assigned 03/07/2008 (6304 days ago)
Resolved 03/07/2008 (6304 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
03/11/2008 01:29:23 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #6 Reply to this comment
I believe generate() should always return a vCal object. If it is
empty and the upstream code has a problem with that, I'll need to
deal with that upstream. In CVS.
Looks good, that's the proper solution. Thanks.


03/11/2008 10:20:50 AM Gunnar Wrobel Comment #5 Reply to this comment

[Show Quoted Text - 9 lines]
I believe generate() should always return a vCal object. If it is 
empty and the upstream code has a problem with that, I'll need to deal 
with that upstream. In CVS.
03/07/2008 01:07:09 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #4 Reply to this comment
Another option would be to remove the empty check completely:



I'm currently debugging why I'm getting an error from Kolab's 
"pfb.php" for an empty calendar folder. The reason is the empty check 
-> no calendar.pvc file get's created.



Guess the code is in there to clean up removed calendars, though this 
was the wrong fix IMHO. I'll investigate further...


03/07/2008 12:59:47 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #3 Reply to this comment
Thanks! Slightly fixed and commited to CVS.
Something still looks wrong: The return value of generate() is listed 
as "string".

If all is fine the function returns the $vCal variable which is of 
type Horde_iCalendar, right?



What about either returning Horde_iCalendar or "false" if the calendar 
is empty?


03/07/2008 12:57:07 PM Gunnar Wrobel State ⇒ Resolved
 
03/07/2008 12:41:34 PM Gunnar Wrobel Comment #2 Reply to this comment
Thanks! Slightly fixed and commited to CVS.
03/07/2008 11:05:56 AM Jan Schneider Assigned to Gunnar Wrobel
State ⇒ Assigned
 
03/07/2008 11:00:22 AM thomas (dot) jarosch (at) intra2net (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Freebusy.php: Fix wrong return value
Queue ⇒ Kolab
New Attachment: framework-kolab-fix-return-value.patch Download
State ⇒ Unconfirmed
Reply to this comment
Hello together,



attached patch fixes a wrong return value which should be a string 
instead of an array (returned by listEvents()).



Cheers,

Thomas


Saved Queries