Tickets :: [#6394] Freebusy.php: Fix wrong return value

6.0.0-RC7

6/22/26

History
Attachments
Comment
Watch
Download

Summary	Freebusy.php: Fix wrong return value
Queue	Kolab
Type	Bug
State	Resolved
Priority	1. Low
Owners	wrobel (at) horde (dot) org
Requester	thomas.jarosch (at) intra2net (dot) com
Created	3/7/08 (6681 days ago)
Due
Updated	3/11/08 (6677 days ago)
Assigned	3/7/08 (6681 days ago)
Resolved	3/7/08 (6681 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

231	thomas (dot) jarosch (at) intra2net (dot) com	Comment #6	Reply to this comment
I believe generate() should always return a vCal object. If it is empty and the upstream code has a problem with that, I'll need to deal with that upstream. In CVS. Looks good, that's the proper solution. Thanks.

5010	Gunnar Wrobel	Comment #5	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] Another option would be to remove the empty check completely: I'm currently debugging why I'm getting an error from Kolab's "pfb.php" for an empty calendar folder. The reason is the empty check -> no calendar.pvc file get's created. Guess the code is in there to clean up removed calendars, though this was the wrong fix IMHO. I'll investigate further... I believe generate() should always return a vCal object. If it is empty and the upstream code has a problem with that, I'll need to deal with that upstream. In CVS.

91	thomas (dot) jarosch (at) intra2net (dot) com	Comment #4	Reply to this comment
Another option would be to remove the empty check completely: I'm currently debugging why I'm getting an error from Kolab's "pfb.php" for an empty calendar folder. The reason is the empty check -> no calendar.pvc file get's created. Guess the code is in there to clean up removed calendars, though this was the wrong fix IMHO. I'll investigate further...

4712	thomas (dot) jarosch (at) intra2net (dot) com	Comment #3	Reply to this comment
Thanks! Slightly fixed and commited to CVS. Something still looks wrong: The return value of generate() is listed as "string". If all is fine the function returns the $vCal variable which is of type Horde_iCalendar, right? What about either returning Horde_iCalendar or "false" if the calendar is empty?

712	Gunnar Wrobel	State ⇒ Resolved

3412	Gunnar Wrobel	Comment #2	Reply to this comment
Thanks! Slightly fixed and commited to CVS.

5611	Jan Schneider	Assigned to Gunnar Wrobel State ⇒ Assigned

2211	thomas (dot) jarosch (at) intra2net (dot) com	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Freebusy.php: Fix wrong return value Queue ⇒ Kolab New Attachment: framework-kolab-fix-return-value.patch State ⇒ Unconfirmed	Reply to this comment
Hello together, attached patch fixes a wrong return value which should be a string instead of an array (returned by listEvents()). Cheers, Thomas