Rejecting - browser bug from 2+ years ago.

Looking at http://dev.rubyonrails.org/ticket/10532 the issue is far 
from being fixed/resolved in prototypejs.  So hacking Horde's 
prototypejs version is premature (not to mention my same reservations 
previously made in this ticket - prototype bugs should be worked 
around in our code rather than hacking the prototype code).

I've been running the patch for a week now with no noticable side 
effects. I'm still in favor of fixing it as imp is not usable without 
it.

I believe the opposite.  I think we should simply wait until 
prototype.js is fixed.  Additionally, I have worked around a bunch of 
prototype bugs in DIMP without resorting to hacking the code, so 
that's a better option.

I think we should patch it, if it's foreseeable that it's gonna be 
fixed in a future version of prototype.

I would rather not patch prototype, but this seems to be sitting for 
them for a while. I think http://dev.rubyonrails.org/ticket/11262 is 
the proper fix... anyone else have opinions here?

Using horde-js-compress from the devtools framework package.

Here's the patch I've used for my horde HEAD installation.



btw: How can I rebuild the "compressed" Javascript source?

Right now I'm copying the js/src/prototype.js file to js/prototype.js.

After the "create new folder" popup in IMP was missing, too, I 
investigated the issue.

I've debugged the problem by stripping down the javascript code and it 
turned out it's the "prototype" javascript framework that doesn't 
properly detect konqueror as "WebKit". See bug reports like this:



http://dev.rubyonrails.org/ticket/11262



or



http://dev.rubyonrails.org/ticket/10532



I've developed the same patch as in #11262 and now I can create folders again

and even the expand of email addresses works in konqueror 3.5.9 :-)



Should we include the patch until it's fixed upstream?

It could potentially trigger code that works in Safari only

but IMHO this is much better than not working at all.



Cheers,

Thomas

Probably. Thanks.

Ok, I enabled the sidebar and set the "menu_refresh" pref to 15 
seconds. Guess that's what you meant, right? Works ok in Firefox and 
Konqueror 3.5.8



I've also checked expanding with KDE4, it works, too. Should we leave 
it at that?

Ajax features (xmlhttprequest) need to be present and working. Do any 
of those, like Horde's sidebar automatically updating, work for you?

Other features work, like I get the spinning wheel when I create a new 
ticket at bugs.horde.org or the tab switching in Turba's contact view 
also works.



I've now enabled to report Javascript errors, so far nothing popped 
up. If I tamper with the JS code I get a nice dialog box with the 
syntax error :o)



Is there any special feature needed from the browser to get expanding working?

Safari works fine. Do other javascript features work for you (does the 
sidebar refresh, for example)? Do you get any javascript errors? 
(Safari at least has a js console, not sure about Konqueror)

Hello together,



expanding of email addresses doesn't work in konqueror 3.5.8. It works 
fine using the same horde/imp installation with Firefox. Konqueror 
does not show the spinning wheel when I finish typing the name, so I 
guess it could be a) lack of the proper javascript features in 
konqueror or b) Browser.php doesn't detect it yet.



I tried lurking around the code to find out what is needed for 
expanding to work but didn't have much luck, so some hints would be 
nice. It would also be interesting f.e. if it works with Safari (which 
got an improved JS implementation than Konqueror IIRC).



The latest live CD of Knoppix features a preview of KDE4, I'll also 
try that the next days.



Cheers,

Thomas